Fix ruff format failures across all Python files #14

New issue

Closed

opened 2026-03-09 22:34:11 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-09 22:34:11 +00:00

Owner

Lineage

plan-2026-03-08-tryout-prep → Phase 1a (CI pipeline fix)

Repo

forgejo_admin/basketball-api

User Story

As a developer
I want CI to pass on the current codebase
So that PRs can be merged and the app can be deployed for the client

Context

Woodpecker CI pipelines fail on ruff format --check with 6 unformatted files. Discovered 2026-03-09 during Woodpecker log investigation — logs were empty due to upstream K8s backend bug (#4409), actual failure found by querying SQLite DB directly. The formatting failures block all builds and deployments.

File Targets

Files the agent should modify:

src/basketball_api/models.py -- ruff format
src/basketball_api/routes/coach.py -- ruff format
src/basketball_api/routes/register.py -- ruff format
src/basketball_api/services/coach_onboarding.py -- ruff format
tests/test_coach.py -- ruff format
tests/test_register.py -- ruff format

Acceptance Criteria

ruff format --check . passes with zero reformats needed
ruff check . passes (already passing)
No functional code changes — formatting only

Test Expectations

Run ruff format --check . — should report 0 files to reformat
Run ruff check . — should report all checks passed
Run command: ruff format --check . && ruff check .

Constraints

Formatting only — no logic changes, no refactoring
Must not break existing tests

Checklist

PR opened
Tests pass
No unrelated changes

plan-2026-03-08-tryout-prep -- tryout prep plan
pal-e-platform #29 -- Python repo standards (platform-level fix)

### Lineage `plan-2026-03-08-tryout-prep` → Phase 1a (CI pipeline fix) ### Repo `forgejo_admin/basketball-api` ### User Story As a developer I want CI to pass on the current codebase So that PRs can be merged and the app can be deployed for the client ### Context Woodpecker CI pipelines fail on `ruff format --check` with 6 unformatted files. Discovered 2026-03-09 during Woodpecker log investigation — logs were empty due to upstream K8s backend bug (#4409), actual failure found by querying SQLite DB directly. The formatting failures block all builds and deployments. ### File Targets Files the agent should modify: - `src/basketball_api/models.py` -- ruff format - `src/basketball_api/routes/coach.py` -- ruff format - `src/basketball_api/routes/register.py` -- ruff format - `src/basketball_api/services/coach_onboarding.py` -- ruff format - `tests/test_coach.py` -- ruff format - `tests/test_register.py` -- ruff format ### Acceptance Criteria - [ ] `ruff format --check .` passes with zero reformats needed - [ ] `ruff check .` passes (already passing) - [ ] No functional code changes — formatting only ### Test Expectations - [ ] Run `ruff format --check .` — should report 0 files to reformat - [ ] Run `ruff check .` — should report all checks passed - Run command: `ruff format --check . && ruff check .` ### Constraints - Formatting only — no logic changes, no refactoring - Must not break existing tests ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - `plan-2026-03-08-tryout-prep` -- tryout prep plan - pal-e-platform #29 -- Python repo standards (platform-level fix)