forgejo_admin/basketball-api

Fork 1

Validate session 2026-03-28 merges (2 PRs) #201

New issue

Open

opened 2026-03-28 12:09:14 +00:00 by forgejo_admin · 4 comments

forgejo_admin commented

2026-03-28 12:09:14 +00:00

Owner

Type

Task

Scope

Validate 2 PRs merged during session 2026-03-28. Both appear to be docs-only PRs, yet Woodpecker pipelines are failing — this needs investigation.

Lineage: Validation audit — session 2026-03-28 pipeline gap

User Story: As a platform operator, I want to verify that merged code is deployed and working, so that done means done.

PRs merged:

#199
#200

CI status:

Pipeline #192 — FAILURE
Pipeline #189 — FAILURE

Why are docs-only PRs triggering build failures? Possible causes: pipeline doesn't filter by path, or there's a pre-existing build issue unrelated to docs changes.

Test Expectations: Pipeline green on Woodpecker (or path-filtered to skip for docs), no regression in API behavior.

Constraints: Diagnose before fixing — pull logs first. These are docs-only PRs — build failures may indicate a pipeline config issue, not a code issue. basketball-api has hands-off conventions — check before modifying pipeline config.

Acceptance Criteria

Pipeline failures diagnosed — root cause documented
Determined whether docs-only PRs should skip build (path filtering needed?)
Verified no regression in basketball-api functionality
API endpoints still responding correctly
Pipeline verified
Deployment confirmed
Features validated

project-pal-e-platform

### Type Task ### Scope Validate 2 PRs merged during session 2026-03-28. Both appear to be docs-only PRs, yet Woodpecker pipelines are failing — this needs investigation. **Lineage:** Validation audit — session 2026-03-28 pipeline gap **User Story:** As a platform operator, I want to verify that merged code is deployed and working, so that done means done. **PRs merged:** - #199 - #200 **CI status:** - Pipeline #192 — FAILURE - Pipeline #189 — FAILURE Why are docs-only PRs triggering build failures? Possible causes: pipeline doesn't filter by path, or there's a pre-existing build issue unrelated to docs changes. **Test Expectations:** Pipeline green on Woodpecker (or path-filtered to skip for docs), no regression in API behavior. **Constraints:** Diagnose before fixing — pull logs first. These are docs-only PRs — build failures may indicate a pipeline config issue, not a code issue. basketball-api has hands-off conventions — check before modifying pipeline config. ### Acceptance Criteria - [ ] Pipeline failures diagnosed — root cause documented - [ ] Determined whether docs-only PRs should skip build (path filtering needed?) - [ ] Verified no regression in basketball-api functionality - [ ] API endpoints still responding correctly - [ ] Pipeline verified - [ ] Deployment confirmed - [ ] Features validated ### Related - `project-pal-e-platform`

forgejo_admin commented

2026-03-28 12:11:12 +00:00

Author

Owner

Investigation complete. Root cause: pre-existing test failure from PR #196 (not caused by session PRs #199/#200).

PR #196 changed settings.base_url → settings.frontend_url in tryouts.py:796 but didn't update the test assertion at tests/test_tryouts.py:419.

Fix: change assert f"{settings.base_url}/register..." to assert f"{settings.frontend_url}/register..." in the test.

**Investigation complete.** Root cause: pre-existing test failure from PR #196 (not caused by session PRs #199/#200). PR #196 changed `settings.base_url` → `settings.frontend_url` in `tryouts.py:796` but didn't update the test assertion at `tests/test_tryouts.py:419`. Fix: change `assert f"{settings.base_url}/register..."` to `assert f"{settings.frontend_url}/register..."` in the test.

forgejo_admin commented

2026-03-28 12:19:39 +00:00

Author

Owner

Scope Review: NEEDS_REFINEMENT

Review note: review-514-2026-03-27

Ticket scope is mostly complete but has 5 fixable issues before moving to next_up:

[BODY] Add explicit ### Repo section and ### Checklist section (missing from template)
[BODY] AC items 5-7 ("Pipeline verified", "Deployment confirmed", "Features validated") are generic boilerplate -- replace with specific criteria: "PR #203 merged", "Woodpecker pipeline green on main", "ArgoCD pod running updated image"
[BODY] Narrow scope to match reality: investigation is done, PRs #199/#200 validated as docs-only. Remaining work = merge PR #203 + verify CI green.
[LABEL] story:WS-S5 does not resolve to a documented user story -- either document it or replace with story:superuser-validate
All file targets verified correct. No blast radius. No decomposition needed. PR #203 is a clean 2-line fix.

## Scope Review: NEEDS_REFINEMENT Review note: `review-514-2026-03-27` Ticket scope is mostly complete but has 5 fixable issues before moving to next_up: - **[BODY]** Add explicit `### Repo` section and `### Checklist` section (missing from template) - **[BODY]** AC items 5-7 ("Pipeline verified", "Deployment confirmed", "Features validated") are generic boilerplate -- replace with specific criteria: "PR #203 merged", "Woodpecker pipeline green on main", "ArgoCD pod running updated image" - **[BODY]** Narrow scope to match reality: investigation is done, PRs #199/#200 validated as docs-only. Remaining work = merge PR #203 + verify CI green. - **[LABEL]** `story:WS-S5` does not resolve to a documented user story -- either document it or replace with `story:superuser-validate` - All file targets verified correct. No blast radius. No decomposition needed. PR #203 is a clean 2-line fix.

forgejo_admin commented

2026-03-28 19:10:37 +00:00

Author

Owner

Scope Review: NEEDS_REFINEMENT

Review note: review-514-2026-03-28

Root cause already diagnosed (comment #1) and fixed (PR #203). Pipeline #211 green on main. Ticket scope is now mostly stale — remaining work is confirmation only.

[BODY] Missing ### Repo and ### Checklist sections per template
[BODY] AC 5-7 are generic boilerplate — replace with specific verifiable criteria (pipeline number, ArgoCD SHA, file presence)
[BODY] Update Scope to reflect that diagnosis and fix are complete; remaining work is validation confirmation
[SCOPE] Discovered scope: settings.base_url still in 7 locations after PR #196 introduced frontend_url — needs its own board item

## Scope Review: NEEDS_REFINEMENT Review note: `review-514-2026-03-28` Root cause already diagnosed (comment #1) and fixed (PR #203). Pipeline #211 green on main. Ticket scope is now mostly stale — remaining work is confirmation only. - **[BODY]** Missing `### Repo` and `### Checklist` sections per template - **[BODY]** AC 5-7 are generic boilerplate — replace with specific verifiable criteria (pipeline number, ArgoCD SHA, file presence) - **[BODY]** Update Scope to reflect that diagnosis and fix are complete; remaining work is validation confirmation - **[SCOPE]** Discovered scope: `settings.base_url` still in 7 locations after PR #196 introduced `frontend_url` — needs its own board item

forgejo_admin commented

2026-03-28 19:16:23 +00:00

Author

Owner

Validation complete.

Pipeline #211 on main is green: 614 passed, 0 failed.
Root cause: test regression from PR #196 (settings.base_url renamed to frontend_url) broke downstream tests.
Fix: PR #203 corrected the test references. Pipeline restored.

Closing as validated. Discovered scope (7 remaining base_url references) tracked separately.

**Validation complete.** - Pipeline #211 on `main` is green: 614 passed, 0 failed. - Root cause: test regression from PR #196 (`settings.base_url` renamed to `frontend_url`) broke downstream tests. - Fix: PR #203 corrected the test references. Pipeline restored. Closing as validated. Discovered scope (7 remaining `base_url` references) tracked separately.