Fix test_reg_link_copy_uses_base_url to use settings.frontend_url #202

New issue

Closed

opened 2026-03-28 12:12:07 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-28 12:12:07 +00:00

Owner

Type

Bug

Lineage

Regression from forgejo_admin/basketball-api #196 — implementation changed to settings.frontend_url but test was not updated.

Repo

forgejo_admin/basketball-api

What Broke

Test test_reg_link_copy_uses_base_url in tests/test_tryouts.py asserts against settings.base_url, but the implementation in tryouts.py line 796 was changed to use settings.frontend_url in PR #196. The test fails because the rendered URL now uses frontend_url.

Repro Steps

Run pytest tests/test_tryouts.py::TestAdminDashboard::test_reg_link_copy_uses_base_url
Observe: assertion error, URL in response uses settings.frontend_url but test expects settings.base_url

Expected Behavior

Test should assert against settings.frontend_url to match the implementation, and pass.

Environment

Cluster/namespace: CI / local dev
Service version/commit: current main after PR #196 merge
Related alerts: none

Acceptance Criteria

Test assertion updated to use settings.frontend_url
Test docstring updated to reference settings.frontend_url
Test suite passes

forgejo_admin/basketball-api #196 — PR that changed implementation

### Type Bug ### Lineage Regression from `forgejo_admin/basketball-api #196` — implementation changed to `settings.frontend_url` but test was not updated. ### Repo `forgejo_admin/basketball-api` ### What Broke Test `test_reg_link_copy_uses_base_url` in `tests/test_tryouts.py` asserts against `settings.base_url`, but the implementation in `tryouts.py` line 796 was changed to use `settings.frontend_url` in PR #196. The test fails because the rendered URL now uses `frontend_url`. ### Repro Steps 1. Run `pytest tests/test_tryouts.py::TestAdminDashboard::test_reg_link_copy_uses_base_url` 2. Observe: assertion error, URL in response uses `settings.frontend_url` but test expects `settings.base_url` ### Expected Behavior Test should assert against `settings.frontend_url` to match the implementation, and pass. ### Environment - Cluster/namespace: CI / local dev - Service version/commit: current main after PR #196 merge - Related alerts: none ### Acceptance Criteria - [ ] Test assertion updated to use `settings.frontend_url` - [ ] Test docstring updated to reference `settings.frontend_url` - [ ] Test suite passes ### Related - `forgejo_admin/basketball-api #196` — PR that changed implementation