settings.base_url still used in 7 locations after frontend_url migration #215

New issue

Open

opened 2026-03-28 19:17:07 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-28 19:17:07 +00:00

Owner

Type

Feature

Lineage

Standalone — discovered during validation of forgejo_admin/basketball-api#201 (review-514-2026-03-28).

Repo

forgejo_admin/basketball-api

User Story

As a developer maintaining basketball-api
I want all references to settings.base_url migrated to settings.frontend_url
So that the codebase is consistent after the rename in PR #196 and no compatibility shims are needed.

Context

PR #196 renamed settings.base_url to settings.frontend_url in the config model. PR #203 fixed the test regression this caused, restoring the pipeline to green (614 passed). However, the validation review found that 7 non-test locations still reference settings.base_url (or base_url from settings). These likely work via a compatibility alias or property, creating confusion and technical debt.

File Targets

Files the agent should modify:

All files containing settings.base_url or importing base_url from settings — replace with settings.frontend_url / frontend_url
Settings model file — remove any base_url compatibility alias/property if present

Files the agent should NOT touch:

Test files that were already fixed in PR #203

Acceptance Criteria

All settings.base_url references replaced with settings.frontend_url
Any compatibility alias/property for base_url removed from the settings model
All 614 tests pass
Pipeline green on PR branch

Test Expectations

Existing test suite passes with no modifications (614 tests)
No new tests needed — this is a rename cleanup
Run command: pytest tests/ -x -q

Constraints

Match existing import/reference patterns in the codebase
Pure rename — no behavioral changes
Verify with grep -r "base_url" src/ that zero references remain after cleanup

Checklist

PR opened
Tests pass
No unrelated changes

westside-basketball — project this affects
forgejo_admin/basketball-api#196 — original rename PR
forgejo_admin/basketball-api#203 — test fix PR
forgejo_admin/basketball-api#201 — validation issue (now closed)

### Type Feature ### Lineage Standalone — discovered during validation of `forgejo_admin/basketball-api#201` (review-514-2026-03-28). ### Repo `forgejo_admin/basketball-api` ### User Story As a developer maintaining basketball-api I want all references to `settings.base_url` migrated to `settings.frontend_url` So that the codebase is consistent after the rename in PR #196 and no compatibility shims are needed. ### Context PR #196 renamed `settings.base_url` to `settings.frontend_url` in the config model. PR #203 fixed the test regression this caused, restoring the pipeline to green (614 passed). However, the validation review found that 7 non-test locations still reference `settings.base_url` (or `base_url` from settings). These likely work via a compatibility alias or property, creating confusion and technical debt. ### File Targets Files the agent should modify: - All files containing `settings.base_url` or importing `base_url` from settings — replace with `settings.frontend_url` / `frontend_url` - Settings model file — remove any `base_url` compatibility alias/property if present Files the agent should NOT touch: - Test files that were already fixed in PR #203 ### Acceptance Criteria - [ ] All `settings.base_url` references replaced with `settings.frontend_url` - [ ] Any compatibility alias/property for `base_url` removed from the settings model - [ ] All 614 tests pass - [ ] Pipeline green on PR branch ### Test Expectations - [ ] Existing test suite passes with no modifications (614 tests) - [ ] No new tests needed — this is a rename cleanup - Run command: `pytest tests/ -x -q` ### Constraints - Match existing import/reference patterns in the codebase - Pure rename — no behavioral changes - Verify with `grep -r "base_url" src/` that zero references remain after cleanup ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - `westside-basketball` — project this affects - `forgejo_admin/basketball-api#196` — original rename PR - `forgejo_admin/basketball-api#203` — test fix PR - `forgejo_admin/basketball-api#201` — validation issue (now closed)