Fix 9 pre-existing jersey/checkout test failures blocking CI deploy #272

Open
opened 2026-03-31 01:13:40 +00:00 by forgejo_admin · 0 comments

Type

Bug

Lineage

Standalone — discovered during contract reminder deploy (pipeline #274). Regression from forgejo_admin/basketball-api #265 (remove opt-out from jersey ordering).

Repo

forgejo_admin/basketball-api

What Broke

9 jersey/checkout tests fail with 422 (Unprocessable Entity) because test fixtures still send "option": "opt_out" which was removed as a valid jersey option in #265. This blocks update-kustomize-tag in CI, preventing auto-deploy.

Failing tests:

  • tests/test_jersey.py::TestPlayerIdJerseyCheckout — 3 failures
  • tests/test_checkout.py::TestPlayerIdCheckoutCreateSession — 3 failures
  • tests/test_dual_auth.py::TestJerseyCheckoutDualAuth + TestCheckoutCreateSessionDualAuth — 3 failures

Repro Steps

  1. Run pytest tests/test_jersey.py tests/test_checkout.py tests/test_dual_auth.py -v
  2. Observe: 9 tests fail with assert 422 == 200 or assert 422 == 403

Expected Behavior

All 745 tests pass. CI pipeline completes and triggers kustomize tag update for ArgoCD deploy.

Environment

  • Cluster/namespace: prod / basketball-api
  • Service version/commit: 5ed3220 introduced the regression, 23902fe is current main
  • Related alerts: none — CI gate caught it before deploy

Acceptance Criteria

  • All 9 failing tests pass
  • Full suite 0 failures
  • CI pipeline succeeds and deploys
  • westside-basketball — project this affects
  • forgejo_admin/basketball-api #265 — PR that removed opt-out, causing the test regression
### Type Bug ### Lineage Standalone — discovered during contract reminder deploy (pipeline #274). Regression from `forgejo_admin/basketball-api #265` (remove opt-out from jersey ordering). ### Repo `forgejo_admin/basketball-api` ### What Broke 9 jersey/checkout tests fail with 422 (Unprocessable Entity) because test fixtures still send `"option": "opt_out"` which was removed as a valid jersey option in #265. This blocks `update-kustomize-tag` in CI, preventing auto-deploy. Failing tests: - `tests/test_jersey.py::TestPlayerIdJerseyCheckout` — 3 failures - `tests/test_checkout.py::TestPlayerIdCheckoutCreateSession` — 3 failures - `tests/test_dual_auth.py::TestJerseyCheckoutDualAuth` + `TestCheckoutCreateSessionDualAuth` — 3 failures ### Repro Steps 1. Run `pytest tests/test_jersey.py tests/test_checkout.py tests/test_dual_auth.py -v` 2. Observe: 9 tests fail with `assert 422 == 200` or `assert 422 == 403` ### Expected Behavior All 745 tests pass. CI pipeline completes and triggers kustomize tag update for ArgoCD deploy. ### Environment - Cluster/namespace: prod / basketball-api - Service version/commit: `5ed3220` introduced the regression, `23902fe` is current main - Related alerts: none — CI gate caught it before deploy ### Acceptance Criteria - [ ] All 9 failing tests pass - [ ] Full suite 0 failures - [ ] CI pipeline succeeds and deploys ### Related - `westside-basketball` — project this affects - `forgejo_admin/basketball-api #265` — PR that removed opt-out, causing the test regression
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo_admin/basketball-api#272
No description provided.