Add parent_phone to SubscriptionListItem response model #286

New issue

Closed

opened 2026-04-03 16:57:58 +00:00 by forgejo_admin · 1 comment

forgejo_admin commented

2026-04-03 16:57:58 +00:00

Owner

Type

Feature

Lineage

Related to forgejo_admin/basketball-api#278 (spike: audit API response contract mismatches with westside-landing frontend)

Repo

forgejo_admin/basketball-api

User Story

As an admin/coach/parent, I want the app to display complete player, parent, and coach information so that I can manage the program without missing data.

Context

Spike Mismatch 6: The subscription list endpoint returns SubscriptionListItem which is missing parent_phone. The admin subscription management view needs parent contact info for follow-up on payment issues.

File Targets

src/basketball_api/routes/subscriptions.py — SubscriptionListItem model

Acceptance Criteria

SubscriptionListItem includes parent_phone: Optional[str]
Field populated from player's parent relationship
All existing tests pass

Test Expectations

Unit test verifying parent_phone appears in subscription list response
Test with subscription where player has no parent (field should be null)

Constraints

Priority: LOW

Checklist

Implementation complete
Tests written and passing
ruff format and ruff check clean
PR submitted

Spike: forgejo_admin/basketball-api#278 (Mismatch 6)

### Type Feature ### Lineage Related to forgejo_admin/basketball-api#278 (spike: audit API response contract mismatches with westside-landing frontend) ### Repo forgejo_admin/basketball-api ### User Story As an admin/coach/parent, I want the app to display complete player, parent, and coach information so that I can manage the program without missing data. ### Context Spike Mismatch 6: The subscription list endpoint returns `SubscriptionListItem` which is missing `parent_phone`. The admin subscription management view needs parent contact info for follow-up on payment issues. ### File Targets - `src/basketball_api/routes/subscriptions.py` — `SubscriptionListItem` model ### Acceptance Criteria - [ ] `SubscriptionListItem` includes `parent_phone: Optional[str]` - [ ] Field populated from player's parent relationship - [ ] All existing tests pass ### Test Expectations - Unit test verifying `parent_phone` appears in subscription list response - Test with subscription where player has no parent (field should be null) ### Constraints - Priority: LOW ### Checklist - [ ] Implementation complete - [ ] Tests written and passing - [ ] `ruff format` and `ruff check` clean - [ ] PR submitted ### Related - Spike: forgejo_admin/basketball-api#278 (Mismatch 6)

forgejo_admin commented

2026-04-03 17:05:13 +00:00

Author

Owner

Scope Review: READY

Review note: review-746-2026-04-03
Simplest ticket in the batch. Single field addition to SubscriptionListItem (line 57). Confirmed missing parent_phone.

[SCOPE] Create architecture note arch-basketball-api

## Scope Review: READY Review note: `review-746-2026-04-03` Simplest ticket in the batch. Single field addition to SubscriptionListItem (line 57). Confirmed missing parent_phone. - `[SCOPE]` Create architecture note arch-basketball-api