Fix scaffold to match SERVICE_ONBOARDING.md conventions #3

New issue

Closed

opened 2026-02-23 17:21:12 +00:00 by forgejo_admin · 1 comment

forgejo_admin commented

2026-02-23 17:21:12 +00:00

Owner

Context

PR #2 (scaffold) passed a 4-round review but diverges from SERVICE_ONBOARDING.md in multiple ways. basketball-api should be a reference implementation of the platform, not a deviation.

Deviations to Fix

.woodpecker.yaml

Uses docker:27 instead of woodpeckerci/plugin-kaniko:2.3.0
Uses ${CI_COMMIT_SHA:0:7} (7-char) instead of $CI_COMMIT_SHA (full SHA)
Path exclude uses k8s/.argocd-source-* needs to be full path pattern
Missing pytest test step

k8s manifests

Missing namespace: basketball-api on all resources
Missing resource requests/limits (10m/32Mi req, 64Mi limit)
Service missing port: 8000, targetPort: 8000, name: http
Missing servicemonitor.yaml
kustomization.yaml missing servicemonitor resource

Application

Missing /metrics endpoint stub (Prometheus scraping)
Port should be 8000 everywhere (container, Service, tfvars)

Part of Plan: 2026-02-23-systematize-planning-basketball-api-deployment
pal-e-services issue #24 (GitHub): platform improvements
PROJ-17 Basketball Program SaaS (Notion)

## Context PR #2 (scaffold) passed a 4-round review but diverges from SERVICE_ONBOARDING.md in multiple ways. basketball-api should be a reference implementation of the platform, not a deviation. ## Deviations to Fix ### .woodpecker.yaml 1. Uses `docker:27` instead of `woodpeckerci/plugin-kaniko:2.3.0` 2. Uses `${CI_COMMIT_SHA:0:7}` (7-char) instead of `$CI_COMMIT_SHA` (full SHA) 3. Path exclude uses `k8s/.argocd-source-*` needs to be full path pattern 4. Missing `pytest` test step ### k8s manifests 5. Missing `namespace: basketball-api` on all resources 6. Missing resource requests/limits (10m/32Mi req, 64Mi limit) 7. Service missing `port: 8000, targetPort: 8000, name: http` 8. Missing `servicemonitor.yaml` 9. `kustomization.yaml` missing servicemonitor resource ### Application 10. Missing `/metrics` endpoint stub (Prometheus scraping) 11. Port should be 8000 everywhere (container, Service, tfvars) ## Related - Part of Plan: 2026-02-23-systematize-planning-basketball-api-deployment - pal-e-services issue #24 (GitHub): platform improvements - PROJ-17 Basketball Program SaaS (Notion)

forgejo_admin referenced this issue from a commit

2026-02-23 17:32:13 +00:00

Fix scaffold to match SERVICE_ONBOARDING.md conventions (Closes #3)

forgejo_admin commented

2026-03-13 19:51:16 +00:00

Author

Owner

Closing — app is deployed and running in production. Scaffold divergences from SERVICE_ONBOARDING.md are not blocking and not worth retrofitting at this point. Future repos should use the onboarding SOP from the start.

forgejo_admin closed this issue

2026-03-13 19:51:17 +00:00