feat: generic coach signup page + JWT auth fix

forgejo_admin commented

2026-03-10 04:23:01 +00:00

Owner

Summary

Adds open-access coach signup routes (/coach/signup) so Marcus can share one link for all coaches, and fixes JWT token_issuer in AuthConfig so admin endpoints authenticate correctly against pal-e-auth tokens.

Changes

src/basketball_api/main.py -- Added token_issuer="pal-e-auth" to AuthConfig constructor so JWT decode validates the iss claim correctly.
src/basketball_api/routes/coach.py -- Added GET /coach/signup (renders branded agreement form with empty fields, no token required) and POST /coach/signup (creates Coach record with tenant_id=1, signs agreement, generates invite token, redirects to Stripe Connect onboarding). Handles duplicate emails: unsigned coaches get updated, signed coaches see "already registered" page.
tests/test_coach_signup.py -- Tests for GET signup page, POST happy path with Stripe redirect, agreement checkbox validation, Stripe failure error display, duplicate email handling for both signed and unsigned coaches.

Test Plan

ruff check src/ tests/ passes
ruff format --check src/ tests/ passes
pytest tests/ -v passes (requires Postgres -- verified via CI)
Visit /coach/signup -- should render branded agreement form
Submit signup form -- should create coach and redirect to Stripe
Submit with existing signed email -- should show "Already Registered"
Admin endpoints now accept JWT tokens with iss: pal-e-auth

Review Checklist

No new Alembic migration needed (no schema changes)
Ruff check and format pass
New routes are unauthenticated (by design -- open coach signup)
Hardcoded tenant_id=1 for Westside (matches issue spec)
Existing /coach/onboard/* routes unchanged
Stripe calls mocked in tests

Closes #30
Plan: plan-2026-03-08-tryout-prep (Phase 3a-iii)

## Summary Adds open-access coach signup routes (`/coach/signup`) so Marcus can share one link for all coaches, and fixes JWT `token_issuer` in `AuthConfig` so admin endpoints authenticate correctly against `pal-e-auth` tokens. ## Changes - **`src/basketball_api/main.py`** -- Added `token_issuer="pal-e-auth"` to `AuthConfig` constructor so JWT decode validates the `iss` claim correctly. - **`src/basketball_api/routes/coach.py`** -- Added `GET /coach/signup` (renders branded agreement form with empty fields, no token required) and `POST /coach/signup` (creates Coach record with `tenant_id=1`, signs agreement, generates invite token, redirects to Stripe Connect onboarding). Handles duplicate emails: unsigned coaches get updated, signed coaches see "already registered" page. - **`tests/test_coach_signup.py`** -- Tests for GET signup page, POST happy path with Stripe redirect, agreement checkbox validation, Stripe failure error display, duplicate email handling for both signed and unsigned coaches. ## Test Plan - [ ] `ruff check src/ tests/` passes - [ ] `ruff format --check src/ tests/` passes - [ ] `pytest tests/ -v` passes (requires Postgres -- verified via CI) - [ ] Visit `/coach/signup` -- should render branded agreement form - [ ] Submit signup form -- should create coach and redirect to Stripe - [ ] Submit with existing signed email -- should show "Already Registered" - [ ] Admin endpoints now accept JWT tokens with `iss: pal-e-auth` ## Review Checklist - [x] No new Alembic migration needed (no schema changes) - [x] Ruff check and format pass - [x] New routes are unauthenticated (by design -- open coach signup) - [x] Hardcoded `tenant_id=1` for Westside (matches issue spec) - [x] Existing `/coach/onboard/*` routes unchanged - [x] Stripe calls mocked in tests ## Related - Closes #30 - Plan: `plan-2026-03-08-tryout-prep` (Phase 3a-iii)

forgejo_admin added 1 commit

2026-03-10 04:23:01 +00:00

feat: generic coach signup page + JWT auth fix

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

fcf6ebf0cb

- Add /coach/signup routes for open-access coach registration
- Fix JWT token_issuer in AuthConfig for admin endpoint auth
- Add tests for signup flow

Closes #30

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>