Bug: CI broken — test_all_expected_values missing first_payment EmailType #381

New issue

Closed

opened 2026-04-07 18:15:49 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-04-07 18:15:49 +00:00

Owner

Type

Bug

Lineage

Regression from PR #370 which added first_payment EmailType but didn't update the test.

Repo

forgejo_admin/basketball-api

What Broke

test_templated_email.py::TestEmailTypeEnumValues::test_all_expected_values fails because the expected set has 10 values but the enum now has 11 (first_payment was added in PR #370). This blocks CI for all subsequent merges — update-kustomize-tag gets skipped, so ArgoCD never deploys.

Repro Steps

Push any commit to main
CI runs tests
test_all_expected_values fails: Extra items in the right set: 'first_payment'
update-kustomize-tag skipped → no deployment

Expected Behavior

CI passes. All EmailType enum values are reflected in the test's expected set.

Environment

CI: Woodpecker pipeline #382, #384 both failed
Commit: any commit after PR #370 merge

Acceptance Criteria

test_all_expected_values includes first_payment
CI pipeline passes end-to-end including update-kustomize-tag

westside-basketball — blocked deploys for #372 and #374
PR #370 — introduced the regression

### Type Bug ### Lineage Regression from PR #370 which added `first_payment` EmailType but didn't update the test. ### Repo `forgejo_admin/basketball-api` ### What Broke `test_templated_email.py::TestEmailTypeEnumValues::test_all_expected_values` fails because the expected set has 10 values but the enum now has 11 (`first_payment` was added in PR #370). This blocks CI for all subsequent merges — `update-kustomize-tag` gets skipped, so ArgoCD never deploys. ### Repro Steps 1. Push any commit to main 2. CI runs tests 3. `test_all_expected_values` fails: `Extra items in the right set: 'first_payment'` 4. `update-kustomize-tag` skipped → no deployment ### Expected Behavior CI passes. All EmailType enum values are reflected in the test's expected set. ### Environment - CI: Woodpecker pipeline #382, #384 both failed - Commit: any commit after PR #370 merge ### Acceptance Criteria - [ ] `test_all_expected_values` includes `first_payment` - [ ] CI pipeline passes end-to-end including `update-kustomize-tag` ### Related - `westside-basketball` — blocked deploys for #372 and #374 - PR #370 — introduced the regression