Pass division-specific jersey image URLs in jersey reminder email #394

New issue

Closed

opened 2026-04-08 21:01:16 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-04-08 21:01:16 +00:00

Owner

Type

enhancement

Lineage

Part 2 of forgejo_admin/westside-emails#10

Repo

forgejo_admin/basketball-api

User Story

As a parent receiving a jersey reminder email, I see jersey images matching my child's division (Kings for boys, Queens for girls) so the email feels personalized and relevant.

Context

send_jersey_reminder_email currently passes only name and jersey_url to the template. The MJML template in westside-emails now supports jersey_image_1 and jersey_image_2 placeholders for division-specific jersey photos.

File Targets

src/basketball_api/services/email.py (~line 1282): update template data dict in send_jersey_reminder_email

Acceptance Criteria

Boys division emails pass kings home/away image URLs
Girls division emails pass queens home/away image URLs
Falls back to boys (kings) if division is not set

Test Expectations

Existing tests continue to pass
No new tests required (template rendering is integration-level)

Constraints

No new dependencies
Image URLs use existing minio-api asset paths

Checklist

Code change in email.py
ruff format + ruff check pass
Tests pass

forgejo_admin/westside-emails#10

### Type enhancement ### Lineage Part 2 of forgejo_admin/westside-emails#10 ### Repo forgejo_admin/basketball-api ### User Story As a parent receiving a jersey reminder email, I see jersey images matching my child's division (Kings for boys, Queens for girls) so the email feels personalized and relevant. ### Context `send_jersey_reminder_email` currently passes only `name` and `jersey_url` to the template. The MJML template in westside-emails now supports `jersey_image_1` and `jersey_image_2` placeholders for division-specific jersey photos. ### File Targets - `src/basketball_api/services/email.py` (~line 1282): update template data dict in `send_jersey_reminder_email` ### Acceptance Criteria - [x] Boys division emails pass kings home/away image URLs - [x] Girls division emails pass queens home/away image URLs - [x] Falls back to boys (kings) if division is not set ### Test Expectations - Existing tests continue to pass - No new tests required (template rendering is integration-level) ### Constraints - No new dependencies - Image URLs use existing minio-api asset paths ### Checklist - [ ] Code change in email.py - [ ] ruff format + ruff check pass - [ ] Tests pass ### Related - forgejo_admin/westside-emails#10