Fix: ruff format failure blocking all push pipelines #475

New issue

Closed

opened 2026-04-13 21:56:36 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-04-13 21:56:36 +00:00

Owner

Type

Bug

Lineage

Standalone — discovered during deploy validation of #473 (409 fix). All push pipelines failing on ruff format check since at least #471.

Repo

forgejo_admin/basketball-api

What Broke

Every push-to-main pipeline fails at ruff format --check . because tests/test_players.py needs reformatting. The build-and-push step runs anyway (status filter allows failure), but the pipeline shows red, masking real failures and eroding CI trust.

Repro Steps

Merge any PR to main
Woodpecker push pipeline triggers
Test step runs ruff format --check .
tests/test_players.py fails format check
Pipeline status: failure

Expected Behavior

ruff format --check . passes. Pipeline shows green when tests pass.

Environment

Cluster/namespace: woodpecker
Service version/commit: 0f5016a (current main HEAD on Forgejo)
Related alerts: none

File Targets

Files to modify:

tests/test_players.py — run ruff format on it

Files to NOT touch:

Everything else

Acceptance Criteria

ruff format --check . passes locally
Push pipeline goes green after merge

westside-basketball — project this affects
forgejo_admin/basketball-api#473 — the 409 fix waiting on this deploy

### Type Bug ### Lineage Standalone — discovered during deploy validation of #473 (409 fix). All push pipelines failing on ruff format check since at least #471. ### Repo `forgejo_admin/basketball-api` ### What Broke Every push-to-main pipeline fails at `ruff format --check .` because `tests/test_players.py` needs reformatting. The build-and-push step runs anyway (status filter allows failure), but the pipeline shows red, masking real failures and eroding CI trust. ### Repro Steps 1. Merge any PR to main 2. Woodpecker push pipeline triggers 3. Test step runs `ruff format --check .` 4. `tests/test_players.py` fails format check 5. Pipeline status: failure ### Expected Behavior `ruff format --check .` passes. Pipeline shows green when tests pass. ### Environment - Cluster/namespace: woodpecker - Service version/commit: `0f5016a` (current main HEAD on Forgejo) - Related alerts: none ### File Targets Files to modify: - `tests/test_players.py` — run `ruff format` on it Files to NOT touch: - Everything else ### Acceptance Criteria - [ ] `ruff format --check .` passes locally - [ ] Push pipeline goes green after merge ### Related - `westside-basketball` — project this affects - forgejo_admin/basketball-api#473 — the 409 fix waiting on this deploy