Remove deprecated agent types and exempt QA from spawn gate #124

New issue

Closed

opened 2026-03-18 16:03:40 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-18 16:03:40 +00:00

Contributor

Lineage

todo-agent-spawn-qa-exception (no plan ancestry)

Repo

forgejo_admin/claude-custom

User Story

As Betty Sue
I want QA agents to bypass the scoping gate and deprecated agent types removed from the schema
So that testing/validation workflows run without unnecessary friction and the schema reflects the current 5-agent model

Context

Phase 12 of plan-pal-e-agency deprecated 6 specialized agent types (dev-backend, dev-frontend, devops, dev-qa, frontend-qa, devops-qa), consolidating back to single Dev + single QA. The schema in agent-spawn-requirements.json still contains all 6 deprecated entries.

Additionally, the QA agent type currently requires both an issue reference AND a PR reference in the spawn prompt. QA agents cannot write code (Write/Edit/Bash excluded from toolset), so the scoping gate doesn't serve its purpose — it only adds friction during validation workflows (e.g. Playwright testing, deployment verification).

Decision: QA is read-only by toolset enforcement, so the gate is redundant. Remove it.

File Targets

Files to modify:

schemas/agent-spawn-requirements.json — remove 6 deprecated types, set QA required_patterns to []

Files NOT to touch:

hooks/check-agent-spawn.sh — no changes needed, it's schema-driven

Acceptance Criteria

Schema contains only: dev, qa, dottie, general-purpose, Explore, claude-code-guide
QA type has required_patterns: [] (pass-through)
Dev type still requires issue reference pattern
QA description updated to explain why no gate

Test Expectations

Manual: spawn a QA agent without issue/PR references — should succeed
Manual: spawn a Dev agent without issue reference — should still be blocked

Constraints

Keep JSON formatting consistent with existing entries
Update QA description to document the rationale (can't write code → no gate needed)

Checklist

PR opened
No unrelated changes

todo-agent-spawn-qa-exception — the TODO that tracks this work
agent-spawn-conventions — the SOP this enforces
plan-pal-e-agency — Phase 12 deprecated the specialized agents

### Lineage `todo-agent-spawn-qa-exception` (no plan ancestry) ### Repo `forgejo_admin/claude-custom` ### User Story As Betty Sue I want QA agents to bypass the scoping gate and deprecated agent types removed from the schema So that testing/validation workflows run without unnecessary friction and the schema reflects the current 5-agent model ### Context Phase 12 of `plan-pal-e-agency` deprecated 6 specialized agent types (dev-backend, dev-frontend, devops, dev-qa, frontend-qa, devops-qa), consolidating back to single Dev + single QA. The schema in `agent-spawn-requirements.json` still contains all 6 deprecated entries. Additionally, the QA agent type currently requires both an issue reference AND a PR reference in the spawn prompt. QA agents cannot write code (Write/Edit/Bash excluded from toolset), so the scoping gate doesn't serve its purpose — it only adds friction during validation workflows (e.g. Playwright testing, deployment verification). Decision: QA is read-only by toolset enforcement, so the gate is redundant. Remove it. ### File Targets Files to modify: - `schemas/agent-spawn-requirements.json` — remove 6 deprecated types, set QA `required_patterns` to `[]` Files NOT to touch: - `hooks/check-agent-spawn.sh` — no changes needed, it's schema-driven ### Acceptance Criteria - [ ] Schema contains only: `dev`, `qa`, `dottie`, `general-purpose`, `Explore`, `claude-code-guide` - [ ] QA type has `required_patterns: []` (pass-through) - [ ] Dev type still requires issue reference pattern - [ ] QA description updated to explain why no gate ### Test Expectations - [ ] Manual: spawn a QA agent without issue/PR references — should succeed - [ ] Manual: spawn a Dev agent without issue reference — should still be blocked ### Constraints - Keep JSON formatting consistent with existing entries - Update QA description to document the rationale (can't write code → no gate needed) ### Checklist - [ ] PR opened - [ ] No unrelated changes ### Related - `todo-agent-spawn-qa-exception` — the TODO that tracks this work - `agent-spawn-conventions` — the SOP this enforces - `plan-pal-e-agency` — Phase 12 deprecated the specialized agents