forgejo_admin/pal-e-api

Fork 1

Validate: run alembic upgrade head for NoteType + validation column migrations #232

New issue

Closed

opened 2026-03-28 16:03:01 +00:00 by forgejo_admin · 2 comments

forgejo_admin commented

2026-03-28 16:03:01 +00:00

Owner

Type

Task

User Story

As the superuser, I need the 3 merged pal-e-api migrations applied so the new NoteType system (4 new types + validation BoardColumn) is active in production. PRs #226, #230, #231 added types and a data migration but alembic upgrade head hasn't been run.

Context

Three migrations merged but unapplied:

PR #226: Add 4 new NoteTypes + validation BoardColumn to schema
PR #230: Data migration to retype doc notes to new NoteType values
PR #231: Remove 7 deprecated NoteTypes from enum

The validation BoardColumn is required for the right-side enforcement pipeline (tickets #209, #210 on board-pal-e-agency). Without it, boards can't use the validation column.

Scope

Verify current alembic head vs. deployed revision
Run alembic upgrade head via kubectl exec into pal-e-api pod
Verify NoteType enum has new values (sop, convention, doc, project-page)
Verify deprecated types removed (sprint, todo, bug, issue, template, phase, plan)
Verify validation column available in board API
Restart MCP server to pick up schema changes

File Targets

No file changes — this is an operational apply of already-merged migrations

Acceptance Criteria

alembic current shows head revision
GET /boards/{slug} returns validation column in schema
list_notes(tags="sop") returns notes with correct note_type
MCP tools reflect new NoteTypes

Test Expectations

pal-e-docs API healthcheck returns 200
Board sync works with validation column present

PRs validated: pal-e-api #226, #230, #231
Blocks: board-pal-e-agency #209 (validation pipeline needs validation column)
Blocks: board-pal-e-agency #210 (validation-gate hook needs validation column)

### Type Task ### User Story As the superuser, I need the 3 merged pal-e-api migrations applied so the new NoteType system (4 new types + validation BoardColumn) is active in production. PRs #226, #230, #231 added types and a data migration but `alembic upgrade head` hasn't been run. ### Context Three migrations merged but unapplied: - PR #226: Add 4 new NoteTypes + validation BoardColumn to schema - PR #230: Data migration to retype doc notes to new NoteType values - PR #231: Remove 7 deprecated NoteTypes from enum The validation BoardColumn is required for the right-side enforcement pipeline (tickets #209, #210 on board-pal-e-agency). Without it, boards can't use the validation column. ### Scope 1. Verify current alembic head vs. deployed revision 2. Run `alembic upgrade head` via kubectl exec into pal-e-api pod 3. Verify NoteType enum has new values (sop, convention, doc, project-page) 4. Verify deprecated types removed (sprint, todo, bug, issue, template, phase, plan) 5. Verify validation column available in board API 6. Restart MCP server to pick up schema changes ### File Targets - No file changes — this is an operational apply of already-merged migrations ### Acceptance Criteria - [ ] `alembic current` shows head revision - [ ] `GET /boards/{slug}` returns validation column in schema - [ ] `list_notes(tags="sop")` returns notes with correct note_type - [ ] MCP tools reflect new NoteTypes ### Test Expectations - pal-e-docs API healthcheck returns 200 - Board sync works with validation column present ### Related - PRs validated: pal-e-api #226, #230, #231 - Blocks: board-pal-e-agency #209 (validation pipeline needs validation column) - Blocks: board-pal-e-agency #210 (validation-gate hook needs validation column)

forgejo_admin commented

2026-03-28 16:11:25 +00:00

Author

Owner

Investigation Update (2026-03-28)

Database: Already at head (p6k7l8m9n0o1). Migrations applied.

Running code: OLD image. BoardColumn enum has 7 values (no validation). NoteType doesn't exist in running code (still NoteTag).

Root cause: CI pipeline hasn't built a new image since PRs #226/#230/#231 merged. The pod is running a pre-NoteType image.

Revised scope: This ticket doesn't need alembic upgrade head — it needs a successful pal-e-api CI pipeline run to build and deploy a new image. Check if CI clone step works (may be blocked by the same cross-namespace networking issue as pal-e-app).

## Investigation Update (2026-03-28) **Database:** Already at head (`p6k7l8m9n0o1`). Migrations applied. **Running code:** OLD image. `BoardColumn` enum has 7 values (no `validation`). `NoteType` doesn't exist in running code (still `NoteTag`). **Root cause:** CI pipeline hasn't built a new image since PRs #226/#230/#231 merged. The pod is running a pre-NoteType image. **Revised scope:** This ticket doesn't need `alembic upgrade head` — it needs a successful pal-e-api CI pipeline run to build and deploy a new image. Check if CI clone step works (may be blocked by the same cross-namespace networking issue as pal-e-app).

forgejo_admin referenced this issue

2026-03-28 16:13:35 +00:00

Fix 12 failing board_sync tests blocking CI deployment #233

forgejo_admin referenced this issue from a commit

2026-03-28 17:13:16 +00:00

chore: document CI secrets rotation to trigger fresh pipeline

forgejo_admin referenced this issue from a pull request that will close it,

2026-03-28 17:13:40 +00:00

chore: document CI secrets rotation to trigger fresh pipeline #237

forgejo_admin closed this issue

2026-03-28 17:25:32 +00:00

forgejo_admin commented

2026-03-28 18:38:07 +00:00

Author

Owner

Scope Review: READY

Review note: review-522-2026-03-28
Ticket is well-scoped, traceable, and was successfully executed. All dependencies satisfied, all AC verifiable.

Minor template nits (non-blocking, for future reference):

Missing ### Repo section (implied by issue location)
Missing ### Lineage section (standalone validation task)
Related references "board-pal-e-agency #209, #210" could clarify they are claude-custom issue numbers to avoid ambiguity with board item IDs

## Scope Review: READY Review note: `review-522-2026-03-28` Ticket is well-scoped, traceable, and was successfully executed. All dependencies satisfied, all AC verifiable. Minor template nits (non-blocking, for future reference): - Missing `### Repo` section (implied by issue location) - Missing `### Lineage` section (standalone validation task) - Related references "board-pal-e-agency #209, #210" could clarify they are claude-custom issue numbers to avoid ambiguity with board item IDs

forgejo_admin referenced this issue

2026-03-28 22:57:40 +00:00

Audit and clean up review notes: type consistency, naming, and lifecycle #246