Review fixes: tag-row CSS, tests, repos sort order (#51) #53

New issue

Closed

opened 2026-02-27 19:06:23 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-02-27 19:06:23 +00:00

Owner

Plan

plan-2026-02-27-browse-ux-enhancements — Phase 1 review fixes

Repo

pal-e-docs — fixes go on the existing 51-recency-project-detail branch (PR #52)

User Story

As a reviewer of PR #52
I found three issues that need fixing before merge
So that the code is correct, tested, and consistent

Acceptance Criteria

tag-row CSS class: either defined in base.html CSS or removed from templates. Must be consistent across all templates that use it.
New tests covering: project detail page with page_note_id set (page note content renders), page note excluded from notes feed, repos appear on project detail page, landing page sort order is by recency not alphabetical.
Repos on project detail page sorted by created_at descending (not alphabetical) — consistent with landing page sort order.

Additional Information

These are review-fix items from the QA review of PR #52
The tag-row class was reportedly added in PR #48 across multiple templates — agent should verify whether it's actually defined in base.html CSS or just used without a definition
Tests should use the existing test fixtures and patterns in the test suite
Repos sort: change .order_by(Repo.name) to .order_by(Repo.created_at.desc()) in browse_project_notes()

Checklist

All three fixes implemented
Tests pass
ruff format clean

project-pal-e-docs — parent project
issue-pal-e-docs-recency-project-detail — parent issue

### Plan `plan-2026-02-27-browse-ux-enhancements` — Phase 1 review fixes ### Repo `pal-e-docs` — fixes go on the existing `51-recency-project-detail` branch (PR #52) ### User Story As a reviewer of PR #52 I found three issues that need fixing before merge So that the code is correct, tested, and consistent ### Acceptance Criteria 1. `tag-row` CSS class: either defined in `base.html` CSS or removed from templates. Must be consistent across all templates that use it. 2. New tests covering: project detail page with `page_note_id` set (page note content renders), page note excluded from notes feed, repos appear on project detail page, landing page sort order is by recency not alphabetical. 3. Repos on project detail page sorted by `created_at` descending (not alphabetical) — consistent with landing page sort order. ### Additional Information - These are review-fix items from the QA review of PR #52 - The `tag-row` class was reportedly added in PR #48 across multiple templates — agent should verify whether it's actually defined in `base.html` CSS or just used without a definition - Tests should use the existing test fixtures and patterns in the test suite - Repos sort: change `.order_by(Repo.name)` to `.order_by(Repo.created_at.desc())` in `browse_project_notes()` ### Checklist - [ ] All three fixes implemented - [ ] Tests pass - [ ] ruff format clean ### Related - `project-pal-e-docs` — parent project - `issue-pal-e-docs-recency-project-detail` — parent issue