forgejo_admin/pal-e-docs-app
1
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Delete stale pal-e-app overlay from pal-e-deployments #58

New issue
Closed
opened 2026-03-27 02:17:53 +00:00 by forgejo_admin · 2 comments
forgejo_admin commented 2026-03-27 02:17:53 +00:00
Owner
Copy link

Moved to forgejo_admin/pal-e-deployments#54 (correct repo).

Moved to forgejo_admin/pal-e-deployments#54 (correct repo).
forgejo_admin commented 2026-03-27 03:31:37 +00:00
Author
Owner
Copy link

Scope Review: NEEDS_REFINEMENT

Review note: review-427-2026-03-26

File targets reference non-existent files (deployment.yaml, service.yaml) — actual files are deployment-patch.yaml and inline kustomization patches. Three additional files need targeting (ingress.yaml, deployment-patch.yaml, pal-e-auth-secrets.enc.yaml).

  • Wrong file names: deployment.yaml should be deployment-patch.yaml; service.yaml doesn't exist (port is in kustomization.yaml inline patches)
  • Missing targets: ingress.yaml (port 3000→80), deployment-patch.yaml (env vars, probes, secrets), pal-e-auth-secrets.enc.yaml (delete)
  • Repo placement: Issue filed on pal-e-app but work is on pal-e-deployments — agent will target wrong repo
  • Scope decision needed: In-repo k8s/ is now self-contained; overlay may be entirely redundant — decide update vs delete
  • Missing scope: env var removal (PAL_E_DOCS_API_URL, AUTH_TRUST_HOST), probe port changes, memory limit reduction, ArgoCD sync criterion
## Scope Review: NEEDS_REFINEMENT Review note: `review-427-2026-03-26` File targets reference non-existent files (`deployment.yaml`, `service.yaml`) — actual files are `deployment-patch.yaml` and inline kustomization patches. Three additional files need targeting (`ingress.yaml`, `deployment-patch.yaml`, `pal-e-auth-secrets.enc.yaml`). - **Wrong file names**: `deployment.yaml` should be `deployment-patch.yaml`; `service.yaml` doesn't exist (port is in `kustomization.yaml` inline patches) - **Missing targets**: `ingress.yaml` (port 3000→80), `deployment-patch.yaml` (env vars, probes, secrets), `pal-e-auth-secrets.enc.yaml` (delete) - **Repo placement**: Issue filed on pal-e-app but work is on pal-e-deployments — agent will target wrong repo - **Scope decision needed**: In-repo k8s/ is now self-contained; overlay may be entirely redundant — decide update vs delete - **Missing scope**: env var removal (PAL_E_DOCS_API_URL, AUTH_TRUST_HOST), probe port changes, memory limit reduction, ArgoCD sync criterion
forgejo_admin changed title from Update pal-e-deployments overlay for adapter-static port change to Delete stale pal-e-app overlay from pal-e-deployments 2026-03-27 03:33:00 +00:00
forgejo_admin commented 2026-03-27 03:49:02 +00:00
Author
Owner
Copy link

Scope Re-Review: NEEDS_REFINEMENT

Review note: review-427-2026-03-26 (updated)

Rewrite addressed 4 of 5 original issues. File targets, scope decision, acceptance criteria, and change scope are all solid. One issue remains.

Resolved:

  • File targets now list all 5 actual files — all verified to exist
  • Scope correctly changed from "update" to "delete entire directory"
  • ArgoCD sync criterion added to test expectations
  • Delete-all approach eliminates the env var/probe/memory scope gap

Still open:

  • Repo placement: Issue is filed on forgejo_admin/pal-e-app but all work targets forgejo_admin/pal-e-deployments. Agent spawn hook reads the issue URL to determine clone target — an agent will clone the wrong repo. Must move issue to pal-e-deployments or create new issue there.

New finding (discovered scope):

  • In-repo pal-e-app/k8s/deployment.yaml still has stale port 3000, server env vars, and auth secrets. Needs its own cleanup ticket on pal-e-app.

Bonus validation:

  • harbor-creds secret in pal-e-app namespace is managed by Terraform, not the overlay. Safe to delete overlay copy.
  • ArgoCD confirmed: repoURL: forgejo_admin/pal-e-app.git, path: k8s — overlay is genuinely unused.
## Scope Re-Review: NEEDS_REFINEMENT Review note: `review-427-2026-03-26` (updated) Rewrite addressed 4 of 5 original issues. File targets, scope decision, acceptance criteria, and change scope are all solid. One issue remains. **Resolved:** - File targets now list all 5 actual files — all verified to exist - Scope correctly changed from "update" to "delete entire directory" - ArgoCD sync criterion added to test expectations - Delete-all approach eliminates the env var/probe/memory scope gap **Still open:** - **Repo placement**: Issue is filed on `forgejo_admin/pal-e-app` but all work targets `forgejo_admin/pal-e-deployments`. Agent spawn hook reads the issue URL to determine clone target — an agent will clone the wrong repo. Must move issue to pal-e-deployments or create new issue there. **New finding (discovered scope):** - In-repo `pal-e-app/k8s/deployment.yaml` still has stale port 3000, server env vars, and auth secrets. Needs its own cleanup ticket on pal-e-app. **Bonus validation:** - harbor-creds secret in pal-e-app namespace is managed by Terraform, not the overlay. Safe to delete overlay copy. - ArgoCD confirmed: `repoURL: forgejo_admin/pal-e-app.git, path: k8s` — overlay is genuinely unused.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
226-fix-wget-auth
No results found.
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend
No labels
domain:backend
domain:devops
domain:frontend
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo_admin/pal-e-docs-app#58
No description provided.