Add missing status parameter to search_notes tool #20

New issue

Closed

opened 2026-03-07 12:48:02 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-07 12:48:02 +00:00

Owner

Plan

plan-2026-02-26-tf-modularize-postgres -- Phase 5 follow-up

Repo

forgejo_admin/pal-e-docs-mcp

User Story

As an AI agent
I want to filter search results by status (e.g. active, completed, in-progress)
So that I can narrow search results without post-filtering

Context

QA review of PR #19 found that the search_notes MCP tool is missing the status parameter. The API endpoint GET /notes/search accepts status as an optional query parameter, and the sibling list_notes tool exposes it, but search_notes does not. This was a nit from post-merge QA — not a blocker but should be consistent.

File Targets

Files the agent should modify:

src/pal_e_docs_mcp/tools/notes.py -- add status optional parameter to search_notes, matching the pattern used in list_notes

Files the agent should NOT touch:

Everything else

Acceptance Criteria

search_notes(query="postgres", status="completed") filters results by status
Parameter follows the same pattern as list_notes (optional, str, Field with description)

Test Expectations

ruff check and ruff format --check pass
Module imports successfully

Constraints

Follow the exact same parameter pattern as list_notes for status
Single parameter addition, no other changes

Checklist

PR opened
Tests pass
No unrelated changes

pal-e-docs-mcp -- project
PR #19 -- the PR that added search_notes (missing this param)

### Plan `plan-2026-02-26-tf-modularize-postgres` -- Phase 5 follow-up ### Repo `forgejo_admin/pal-e-docs-mcp` ### User Story As an AI agent I want to filter search results by status (e.g. active, completed, in-progress) So that I can narrow search results without post-filtering ### Context QA review of PR #19 found that the `search_notes` MCP tool is missing the `status` parameter. The API endpoint `GET /notes/search` accepts `status` as an optional query parameter, and the sibling `list_notes` tool exposes it, but `search_notes` does not. This was a nit from post-merge QA — not a blocker but should be consistent. ### File Targets Files the agent should modify: - `src/pal_e_docs_mcp/tools/notes.py` -- add `status` optional parameter to `search_notes`, matching the pattern used in `list_notes` Files the agent should NOT touch: - Everything else ### Acceptance Criteria - [ ] `search_notes(query="postgres", status="completed")` filters results by status - [ ] Parameter follows the same pattern as `list_notes` (optional, str, Field with description) ### Test Expectations - [ ] `ruff check` and `ruff format --check` pass - [ ] Module imports successfully ### Constraints - Follow the exact same parameter pattern as `list_notes` for `status` - Single parameter addition, no other changes ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - `pal-e-docs-mcp` -- project - PR #19 -- the PR that added search_notes (missing this param)