forgejo_admin/pal-e-platform

Fork 1

feat: Keycloak theme polish — QA nits from PR #130 #131

New issue

Closed

opened 2026-03-21 16:42:41 +00:00 by forgejo_admin · 2 comments

forgejo_admin commented

2026-03-21 16:42:41 +00:00

Owner

Type

Feature

Lineage

plan-wkq → Phase 15 → discovered scope from PR #130 QA review

Repo

forgejo_admin/pal-e-platform

User Story

As a developer maintaining the Westside Keycloak theme
I want all CSS values to follow the design system conventions
So that the theme is production-ready and maintainable

Context

QA review of PR #130 (Westside Keycloak login theme) approved with 4 nits. These are polish items discovered during review that should be addressed before production hardening.

Dev-only cache flags — --spi-theme-static-max-age=-1 and --spi-theme-cache-themes=false in Keycloak args are correct for iteration but need production toggle
Off-palette hover color — .select-auth-box-parent:hover uses #1a1a1a, not in Westside design tokens
Redundant border shorthand — .card-pf sets both border-top and border-color, likely intent was red top border only
Magic number font-size — #kc-header-wrapper uses font-size: 29px instead of rem units

File Targets

Files the agent should modify:

terraform/main.tf — document or conditionalize cache flags
keycloak/themes/westside/login/resources/css/westside.css — fix hover color, border shorthand, font-size unit

Files the agent should NOT touch:

~/westside-app/src/app.css — design token source of truth, read-only

Acceptance Criteria

No off-palette colors — all hex values traceable to westside-app design tokens
Border renders as red top only, not red all sides
Font size uses rem units
Cache flags documented with TODO or removed

Test Expectations

Visual: Playwright screenshot before/after to confirm no regression
Infra: tofu validate passes
Run command: cd ~/pal-e-platform/terraform && tofu validate

Constraints

Do not change the overall dark theme — this is polish only
Cache flag removal may be deferred to platform hardening phase

Checklist

PR opened
Tests pass
No unrelated changes

project-westside-basketball
PR #130 — parent PR where nits were identified

### Type Feature ### Lineage `plan-wkq` → Phase 15 → discovered scope from PR #130 QA review ### Repo `forgejo_admin/pal-e-platform` ### User Story As a developer maintaining the Westside Keycloak theme I want all CSS values to follow the design system conventions So that the theme is production-ready and maintainable ### Context QA review of PR #130 (Westside Keycloak login theme) approved with 4 nits. These are polish items discovered during review that should be addressed before production hardening. 1. **Dev-only cache flags** — `--spi-theme-static-max-age=-1` and `--spi-theme-cache-themes=false` in Keycloak args are correct for iteration but need production toggle 2. **Off-palette hover color** — `.select-auth-box-parent:hover` uses `#1a1a1a`, not in Westside design tokens 3. **Redundant border shorthand** — `.card-pf` sets both `border-top` and `border-color`, likely intent was red top border only 4. **Magic number font-size** — `#kc-header-wrapper` uses `font-size: 29px` instead of `rem` units ### File Targets Files the agent should modify: - `terraform/main.tf` — document or conditionalize cache flags - `keycloak/themes/westside/login/resources/css/westside.css` — fix hover color, border shorthand, font-size unit Files the agent should NOT touch: - `~/westside-app/src/app.css` — design token source of truth, read-only ### Acceptance Criteria - [ ] No off-palette colors — all hex values traceable to westside-app design tokens - [ ] Border renders as red top only, not red all sides - [ ] Font size uses rem units - [ ] Cache flags documented with TODO or removed ### Test Expectations - [ ] Visual: Playwright screenshot before/after to confirm no regression - [ ] Infra: `tofu validate` passes - Run command: `cd ~/pal-e-platform/terraform && tofu validate` ### Constraints - Do not change the overall dark theme — this is polish only - Cache flag removal may be deferred to platform hardening phase ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - `project-westside-basketball` - PR #130 — parent PR where nits were identified

forgejo_admin referenced this issue

2026-03-21 21:24:43 +00:00

feat: secrets pillar validation gate + missing Woodpecker secrets #140

forgejo_admin commented

2026-03-27 21:32:50 +00:00

Author

Owner

Scope Review: NEEDS_REFINEMENT

Review note: review-243-2026-03-27

All 4 CSS/infra nits verified in the codebase. Template is complete. Two fixable issues found:

Wrong file target: terraform/main.tf is now a module orchestrator. Cache flags are in terraform/modules/keycloak/main.tf (line 101). Update the File Targets section.
Missing traceability labels: Board item #243 has no story: or arch: labels. Recommend arch:keycloak + a maintenance story label.

All acceptance criteria are testable. Scope fits a single agent pass. No decomposition needed. No blockers on the board.

## Scope Review: NEEDS_REFINEMENT Review note: `review-243-2026-03-27` All 4 CSS/infra nits verified in the codebase. Template is complete. Two fixable issues found: - **Wrong file target**: `terraform/main.tf` is now a module orchestrator. Cache flags are in `terraform/modules/keycloak/main.tf` (line 101). Update the File Targets section. - **Missing traceability labels**: Board item #243 has no `story:` or `arch:` labels. Recommend `arch:keycloak` + a maintenance story label. All acceptance criteria are testable. Scope fits a single agent pass. No decomposition needed. No blockers on the board.

forgejo_admin commented

2026-03-27 21:58:00 +00:00

Author

Owner

Scope Review: READY

Review note: review-243-2026-03-27

Solid ticket. Template complete, all 4 CSS nits verified in codebase, well-scoped for single-agent execution.

Minor note (non-blocking): Cache flags are in terraform/modules/keycloak/main.tf line 101, not terraform/main.tf. Agent will find via grep.

All 4 patterns confirmed:

Line 221: #1a1a1a hover color -- off-palette
Lines 49-50: redundant border-top + border-color -- confirmed
Line 40: font-size: 29px -- magic number, needs rem

2 files, 1 repo, 4 acceptance criteria. No decomposition needed. Ready for next_up.

## Scope Review: READY Review note: `review-243-2026-03-27` Solid ticket. Template complete, all 4 CSS nits verified in codebase, well-scoped for single-agent execution. Minor note (non-blocking): Cache flags are in `terraform/modules/keycloak/main.tf` line 101, not `terraform/main.tf`. Agent will find via grep. All 4 patterns confirmed: - Line 221: `#1a1a1a` hover color -- off-palette - Lines 49-50: redundant `border-top` + `border-color` -- confirmed - Line 40: `font-size: 29px` -- magic number, needs rem 2 files, 1 repo, 4 acceptance criteria. No decomposition needed. Ready for next_up.

forgejo_admin referenced this issue from a commit

2026-03-27 22:01:03 +00:00

fix: Keycloak theme QA nits — palette, border, rem units, cache docs

forgejo_admin referenced this issue from a pull request that will close it,

2026-03-27 22:01:58 +00:00

fix: Keycloak theme QA nits from PR #130 #208

forgejo_admin referenced this issue

2026-03-27 22:03:01 +00:00

fix: Keycloak theme QA nits from PR #130 #208

forgejo_admin closed this issue

2026-03-27 22:04:22 +00:00