Cleanup: remove dead force-unlock retry block from CI apply step #136

New issue

Closed

opened 2026-03-21 17:40:17 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-21 17:40:17 +00:00

Owner

Type

Bug

Lineage

plan-pal-e-platform — discovered during QA review of PR #134

Repo

forgejo_admin/pal-e-platform

What Broke

Not broken — dead code. PR #134 added -lock=false to both tofu apply calls. With -lock=false, the "state is already locked" error can never occur, making the force-unlock retry block (.woodpecker.yaml lines 148-161) unreachable.

Repro Steps

Read .woodpecker.yaml lines 142-161
Note that -lock=false on the initial apply means the grep -q "the state is already locked" condition is always false
The entire if block (force-unlock + retry) is dead code

Expected Behavior

Dead code should be removed to keep the pipeline readable. The apply step should be a simple one-liner.

Environment

File: .woodpecker.yaml
After PR #134 merges

Acceptance Criteria

Force-unlock retry block removed from apply step
Apply step simplified to single tofu apply -auto-approve -lock=false -no-color

Discovered during QA of PR #134
Original retry block added in PR #100 (lock-aware retry)

### Type Bug ### Lineage `plan-pal-e-platform` — discovered during QA review of PR #134 ### Repo `forgejo_admin/pal-e-platform` ### What Broke Not broken — dead code. PR #134 added `-lock=false` to both `tofu apply` calls. With `-lock=false`, the "state is already locked" error can never occur, making the force-unlock retry block (`.woodpecker.yaml` lines 148-161) unreachable. ### Repro Steps 1. Read `.woodpecker.yaml` lines 142-161 2. Note that `-lock=false` on the initial apply means the `grep -q "the state is already locked"` condition is always false 3. The entire `if` block (force-unlock + retry) is dead code ### Expected Behavior Dead code should be removed to keep the pipeline readable. The apply step should be a simple one-liner. ### Environment - File: `.woodpecker.yaml` - After PR #134 merges ### Acceptance Criteria - [ ] Force-unlock retry block removed from apply step - [ ] Apply step simplified to single `tofu apply -auto-approve -lock=false -no-color` ### Related - Discovered during QA of PR #134 - Original retry block added in PR #100 (lock-aware retry)