ldraney/pal-e-platform
1
0
Fork 0
Code Issues 91 Pull requests 5 Projects Releases Packages Wiki Activity Actions

Apply ruff standard to gmail-mcp (missed from #29 rollout) #244

New issue
Open
opened 2026-03-28 23:23:50 +00:00 by forgejo_admin · 3 comments
forgejo_admin commented 2026-03-28 23:23:50 +00:00
Contributor
Copy link

Type

Feature

Lineage

  • Board: board-pal-e-platform
  • Story: story:superuser-deploy
  • Arch: arch:ci-pipeline
  • Discovered from: #29 (Python repo standards rollout, 5/6 complete)

Repo

forgejo_admin/gmail-mcp (code changes target this repo; issue tracked on pal-e-platform for board alignment)

User Story

As the platform operator, I need all Python repos to follow the ruff standard documented in convention-python-ruff-standard, so CI linting is consistent across the platform.

Context

Issue #29 rolled out ruff to 5/6 repos. gmail-mcp was skipped because the issue body listed "TBD" for its local path. Current state: line-length=120 (should be 88), target-version="py310" (should be py312), no .pre-commit-config.yaml. Woodpecker CI already has a ruff lint step (AC4 pre-satisfied).

File Targets

  • ~/gmail-mcp/pyproject.toml — update ruff config (line-length=88, target-version="py312", select=["E","F","I","W"])
  • ~/gmail-mcp/.pre-commit-config.yaml — create with ruff hook
  • Reference: convention-python-ruff-standard note in pal-e-docs

Acceptance Criteria

  • pyproject.toml ruff config matches convention (line-length=88, py312, E/F/I/W)
  • .pre-commit-config.yaml exists with ruff hook
  • ruff check . passes clean
  • CI pipeline includes ruff step (pre-satisfied — .woodpecker.yml already has it)

Test Expectations

  • ruff check . — 0 errors
  • ruff format --check . — 0 changes needed

Constraints

  • Follow convention-python-ruff-standard exactly
  • May need to fix existing lint violations after config change
  • Line-length change 120→88 will require reformatting — run ruff format . after config update

Checklist

  • Update pyproject.toml ruff config
  • Run ruff format . to reformat for new line-length
  • Fix any remaining lint violations from ruff check .
  • Create .pre-commit-config.yaml
  • Create PR on gmail-mcp repo

Related

  • #29 — parent rollout issue (5/6 complete)
  • convention-python-ruff-standard — the standard to apply
### Type Feature ### Lineage - Board: board-pal-e-platform - Story: story:superuser-deploy - Arch: arch:ci-pipeline - Discovered from: #29 (Python repo standards rollout, 5/6 complete) ### Repo `forgejo_admin/gmail-mcp` (code changes target this repo; issue tracked on pal-e-platform for board alignment) ### User Story As the platform operator, I need all Python repos to follow the ruff standard documented in `convention-python-ruff-standard`, so CI linting is consistent across the platform. ### Context Issue #29 rolled out ruff to 5/6 repos. gmail-mcp was skipped because the issue body listed "TBD" for its local path. Current state: line-length=120 (should be 88), target-version="py310" (should be py312), no .pre-commit-config.yaml. Woodpecker CI already has a ruff lint step (AC4 pre-satisfied). ### File Targets - `~/gmail-mcp/pyproject.toml` — update ruff config (line-length=88, target-version="py312", select=["E","F","I","W"]) - `~/gmail-mcp/.pre-commit-config.yaml` — create with ruff hook - Reference: `convention-python-ruff-standard` note in pal-e-docs ### Acceptance Criteria - [ ] pyproject.toml ruff config matches convention (line-length=88, py312, E/F/I/W) - [ ] .pre-commit-config.yaml exists with ruff hook - [ ] `ruff check .` passes clean - [ ] CI pipeline includes ruff step (pre-satisfied — .woodpecker.yml already has it) ### Test Expectations - [ ] `ruff check .` — 0 errors - [ ] `ruff format --check .` — 0 changes needed ### Constraints - Follow convention-python-ruff-standard exactly - May need to fix existing lint violations after config change - Line-length change 120→88 will require reformatting — run `ruff format .` after config update ### Checklist - [ ] Update pyproject.toml ruff config - [ ] Run `ruff format .` to reformat for new line-length - [ ] Fix any remaining lint violations from `ruff check .` - [ ] Create .pre-commit-config.yaml - [ ] Create PR on gmail-mcp repo ### Related - #29 — parent rollout issue (5/6 complete) - `convention-python-ruff-standard` — the standard to apply
forgejo_admin commented 2026-03-28 23:28:42 +00:00
Author
Contributor
Copy link

Scope Review: NEEDS_REFINEMENT

Review note: review-640-2026-03-28

File targets verified, template complete, traceability labels present. Two issues found:

  • Repo placement mismatch: Issue is filed on pal-e-platform but all code changes are in forgejo_admin/gmail-mcp. Should be moved to gmail-mcp for PR-to-issue traceability.
  • Missing checklist item: Explicit ruff format . step needed after line-length 120→88 change (implied but not stated).
  • Blast radius: minio-sdk also has line-length=120 with no remediation ticket. Discovered scope — needs its own issue.
  • Convention note gap: gmail-mcp is not listed in convention-python-ruff-standard "Repos In Scope" table. Needs update after remediation.
## Scope Review: NEEDS_REFINEMENT Review note: `review-640-2026-03-28` File targets verified, template complete, traceability labels present. Two issues found: - **Repo placement mismatch**: Issue is filed on `pal-e-platform` but all code changes are in `forgejo_admin/gmail-mcp`. Should be moved to gmail-mcp for PR-to-issue traceability. - **Missing checklist item**: Explicit `ruff format .` step needed after line-length 120→88 change (implied but not stated). - **Blast radius**: `minio-sdk` also has `line-length=120` with no remediation ticket. Discovered scope — needs its own issue. - **Convention note gap**: `gmail-mcp` is not listed in `convention-python-ruff-standard` "Repos In Scope" table. Needs update after remediation.
forgejo_admin commented 2026-03-28 23:30:14 +00:00
Author
Contributor
Copy link

Scope Refinement Applied (review-640-2026-03-28)

2 body changes per review recommendations:

  1. Repo clarification: Added note that code targets forgejo_admin/gmail-mcp, issue tracked on pal-e-platform for board alignment
  2. Added ruff format . step: Checklist now includes explicit reformat step after line-length 120→88 change

Re-running scope review.

## Scope Refinement Applied (review-640-2026-03-28) 2 body changes per review recommendations: 1. **Repo clarification**: Added note that code targets `forgejo_admin/gmail-mcp`, issue tracked on pal-e-platform for board alignment 2. **Added `ruff format .` step**: Checklist now includes explicit reformat step after line-length 120→88 change Re-running scope review.
forgejo_admin commented 2026-03-29 03:17:41 +00:00
Author
Contributor
Copy link

Scope Review: APPROVED

Review note: review-640-v2-2026-03-28

Re-review after refinement. Both body fixes from previous NEEDS_REFINEMENT review independently verified:

  1. Repo clarification applied — cross-repo tracking documented
  2. ruff format . checklist item added

All template sections complete, traceability triangle satisfied, all 4 file targets verified against filesystem, 4 AC machine-verifiable, no decomposition needed (<3 min estimated). Ready for dispatch.

## Scope Review: APPROVED Review note: `review-640-v2-2026-03-28` Re-review after refinement. Both body fixes from previous NEEDS_REFINEMENT review independently verified: 1. Repo clarification applied — cross-repo tracking documented 2. `ruff format .` checklist item added All template sections complete, traceability triangle satisfied, all 4 file targets verified against filesystem, 4 AC machine-verifiable, no decomposition needed (<3 min estimated). Ready for dispatch.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix-gem-bin-path
netpol-westside-ror
fix-woodpecker-multi-pipeline
345-harbor-mobile-css
290-payment-pipeline-observability
spec-board-centric-renderer
284-fix-add-pal-e-docs-namespace-to-postgres
284-add-pal-e-docs-postgres-netpol
188-cross-repo-worktree-isolation-for-parall
111-fix-keycloak-probe
86-fix-rotate-woodpecker-api-token-in-salt
71-feat-deploy-pyrra-slo-manager-with-servi
64-hotfix-woodpecker-oauth-login-broken-for
18-fix-grafana-duplicate-default-datasource-v2
18-fix-grafana-duplicate-default-datasource
13-fix-cnpg-all-parameters
No results found.
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend

   
status:approved

QA passed, awaiting merge approval

  
status:in-progress

Dev agent is actively working

  
status:needs-fix

QA found issues, back to dev

  
status:qa

PR submitted, awaiting QA review

  
type:bug

Bug fix

  
type:devops

Infrastructure/CI/config work

  
type:feature

New functionality

No labels
domain:backend
domain:devops
domain:frontend
status:approved
status:in-progress
status:needs-fix
status:qa
type:bug
type:devops
type:feature
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/pal-e-platform#244
No description provided.