forgejo_admin/westside-app

Fork 0

Rename westside-app repo to westside-landing #109

New issue

Open

opened 2026-03-27 06:21:43 +00:00 by forgejo_admin · 4 comments

forgejo_admin commented

2026-03-27 06:21:43 +00:00

Owner

Type

Feature

Lineage

Standalone — architectural decision from 2026-03-27 session. Public landing site and authenticated portal need separate repos.

Repo

forgejo_admin/westside-app

User Story

As a superadmin
I want the public landing site repo named westside-landing instead of westside-app
So that westside-app is freed up for the authenticated portal (admin, coach, parent, player dashboards) which will become the App Store target.

Context

westside-app currently holds both (public) routes (8-page landing site) and (app) routes (13 authenticated pages). The name westside-app implies the authenticated app, not the public site. Renaming to westside-landing makes the architecture self-documenting:

westside-landing = public brand site at westsidekingsandqueens.tail5b443a.ts.net
westside-app (future, separate ticket) = auth portal, App Store target
basketball-api = backend API

This is Phase 1 of a 3-phase split. Phase 2 (extract (app) routes to new westside-app) and Phase 3 (separate funnels) are separate tickets.

File Targets

Files the agent should modify:

Forgejo repo settings (rename via API)
pal-e-services/terraform/k3s.tfvars — service key + forgejo_repo reference
pal-e-deployments/overlays/westsidekingsandqueens/ — ArgoCD source references
pal-e-platform/terraform/main.tf — blackbox probe service name if referenced
.woodpecker.yaml — clone URL uses ${CI_REPO} (auto-adjusts, verify only)
Woodpecker webhook + secrets (may need re-creation after rename)

Files the agent should NOT touch:

basketball-api/ — no changes needed, it references westside by hostname not repo name
Keycloak config — realm/client names are independent of repo name
~/westside-app local directory — local clone rename is manual

Acceptance Criteria

Repo renamed to westside-landing on Forgejo
CI pipeline builds and pushes successfully under new name
ArgoCD syncs under new repo reference
Site remains live at westsidekingsandqueens.tail5b443a.ts.net
No broken webhooks or secrets
Harbor project updated or new project created

Test Expectations

Manual: push a no-op commit, verify CI pipeline runs end-to-end
Manual: verify westsidekingsandqueens.tail5b443a.ts.net still serves pages
Manual: verify ArgoCD app shows Synced status
Run command: curl -s -o /dev/null -w '%{http_code}' https://westsidekingsandqueens.tail5b443a.ts.net/

Constraints

Must be done in a single coordinated session (rename + all infra updates atomically)
Woodpecker webhook URL changes automatically on Forgejo repo rename — verify, don't fight it
${CI_REPO} in .woodpecker.yaml auto-adjusts — no code change needed
Harbor project naming follows feedback_harbor_project_naming.md — derive from image_repo prefix
tofu plan -lock=false before any terraform changes

Checklist

PR opened (for pal-e-services + pal-e-deployments changes)
Tests pass
No unrelated changes

project-westside-basketball
pal-e-services#35 — dead funnel ingress (related cleanup)
Phase 2: Extract (app) routes to new westside-app repo (future ticket)
Phase 3: Separate funnels for landing vs app (future ticket)

### Type Feature ### Lineage Standalone — architectural decision from 2026-03-27 session. Public landing site and authenticated portal need separate repos. ### Repo `forgejo_admin/westside-app` ### User Story As a superadmin I want the public landing site repo named `westside-landing` instead of `westside-app` So that `westside-app` is freed up for the authenticated portal (admin, coach, parent, player dashboards) which will become the App Store target. ### Context `westside-app` currently holds both `(public)` routes (8-page landing site) and `(app)` routes (13 authenticated pages). The name `westside-app` implies the authenticated app, not the public site. Renaming to `westside-landing` makes the architecture self-documenting: - `westside-landing` = public brand site at `westsidekingsandqueens.tail5b443a.ts.net` - `westside-app` (future, separate ticket) = auth portal, App Store target - `basketball-api` = backend API This is Phase 1 of a 3-phase split. Phase 2 (extract `(app)` routes to new `westside-app`) and Phase 3 (separate funnels) are separate tickets. ### File Targets Files the agent should modify: - Forgejo repo settings (rename via API) - `pal-e-services/terraform/k3s.tfvars` — service key + forgejo_repo reference - `pal-e-deployments/overlays/westsidekingsandqueens/` — ArgoCD source references - `pal-e-platform/terraform/main.tf` — blackbox probe service name if referenced - `.woodpecker.yaml` — clone URL uses `${CI_REPO}` (auto-adjusts, verify only) - Woodpecker webhook + secrets (may need re-creation after rename) Files the agent should NOT touch: - `basketball-api/` — no changes needed, it references westside by hostname not repo name - Keycloak config — realm/client names are independent of repo name - `~/westside-app` local directory — local clone rename is manual ### Acceptance Criteria - [ ] Repo renamed to `westside-landing` on Forgejo - [ ] CI pipeline builds and pushes successfully under new name - [ ] ArgoCD syncs under new repo reference - [ ] Site remains live at `westsidekingsandqueens.tail5b443a.ts.net` - [ ] No broken webhooks or secrets - [ ] Harbor project updated or new project created ### Test Expectations - [ ] Manual: push a no-op commit, verify CI pipeline runs end-to-end - [ ] Manual: verify `westsidekingsandqueens.tail5b443a.ts.net` still serves pages - [ ] Manual: verify ArgoCD app shows Synced status - Run command: `curl -s -o /dev/null -w '%{http_code}' https://westsidekingsandqueens.tail5b443a.ts.net/` ### Constraints - Must be done in a single coordinated session (rename + all infra updates atomically) - Woodpecker webhook URL changes automatically on Forgejo repo rename — verify, don't fight it - `${CI_REPO}` in `.woodpecker.yaml` auto-adjusts — no code change needed - Harbor project naming follows `feedback_harbor_project_naming.md` — derive from image_repo prefix - `tofu plan -lock=false` before any terraform changes ### Checklist - [ ] PR opened (for pal-e-services + pal-e-deployments changes) - [ ] Tests pass - [ ] No unrelated changes ### Related - `project-westside-basketball` - `pal-e-services#35` — dead funnel ingress (related cleanup) - Phase 2: Extract `(app)` routes to new `westside-app` repo (future ticket) - Phase 3: Separate funnels for landing vs app (future ticket)

forgejo_admin commented

2026-03-27 06:57:30 +00:00

Author

Owner

Scope Review: NEEDS_REFINEMENT

Review note: review-450-2026-03-26
Issue template is complete and traceability is solid, but four refinements needed before READY:

Missing file targets: k8s/deployment.yaml, k8s/ingress.yaml (in-repo manifests), and keycloak-import.sh should be acknowledged in the do-not-touch list
Ambiguous Harbor criterion: Harbor project is westsidekingsandqueens (from image_repo prefix), not tied to Forgejo repo name -- clarify or remove "Harbor project updated" criterion
Missing tofu plan criterion: Add acceptance criterion for tofu plan -lock=false showing zero drift after k3s.tfvars update
(Minor) Explicitly document that k8s resource names stay westside-app in Phase 1, deferred to Phase 2

## Scope Review: NEEDS_REFINEMENT Review note: `review-450-2026-03-26` Issue template is complete and traceability is solid, but four refinements needed before READY: - **Missing file targets**: `k8s/deployment.yaml`, `k8s/ingress.yaml` (in-repo manifests), and `keycloak-import.sh` should be acknowledged in the do-not-touch list - **Ambiguous Harbor criterion**: Harbor project is `westsidekingsandqueens` (from image_repo prefix), not tied to Forgejo repo name -- clarify or remove "Harbor project updated" criterion - **Missing tofu plan criterion**: Add acceptance criterion for `tofu plan -lock=false` showing zero drift after k3s.tfvars update - **(Minor)** Explicitly document that k8s resource names stay `westside-app` in Phase 1, deferred to Phase 2

forgejo_admin commented

2026-03-27 06:58:06 +00:00

Author

Owner

Refinement (post review-450)

Addressed findings:

Missing file targets added to "do not touch" list:
- k8s/deployment.yaml, k8s/ingress.yaml — hardcoded westside-app references are k8s resource names, independent of Forgejo repo name. Unchanged in Phase 1, renamed in Phase 2.
- pal-e-services/keycloak-import.sh — westside-app is a Keycloak client key, not a repo reference. No change needed.
Harbor criterion clarified: Harbor project westsidekingsandqueens derives from image_repo prefix (westsidekingsandqueens/app), not the Forgejo repo name. No Harbor changes needed. Removed misleading criterion.
tofu plan criterion added: After updating forgejo_repo in k3s.tfvars, run tofu plan -var-file=k3s.tfvars -lock=false and verify only the ArgoCD app source URL changes.
Phase 1 vs Phase 2 boundary explicit: K8s resource names (westside-app Deployment, Service, Ingress, Secret) remain unchanged in Phase 1. Phase 2 creates the new westside-app repo for the auth portal, at which point k8s names get reassigned. No collision risk in Phase 1.

Updated AC

Repo renamed to westside-landing on Forgejo
pal-e-services/k3s.tfvars forgejo_repo updated to forgejo_admin/westside-landing
tofu plan shows only ArgoCD app source URL change (no Harbor, no namespace)
CI pipeline triggers on push to westside-landing repo
Site remains live at westsidekingsandqueens.tail5b443a.ts.net
No orphaned Woodpecker webhooks

Status: READY

## Refinement (post review-450) ### Addressed findings: 1. **Missing file targets added to "do not touch" list:** - `k8s/deployment.yaml`, `k8s/ingress.yaml` — hardcoded `westside-app` references are k8s resource names, independent of Forgejo repo name. Unchanged in Phase 1, renamed in Phase 2. - `pal-e-services/keycloak-import.sh` — `westside-app` is a Keycloak client key, not a repo reference. No change needed. 2. **Harbor criterion clarified:** Harbor project `westsidekingsandqueens` derives from `image_repo` prefix (`westsidekingsandqueens/app`), not the Forgejo repo name. **No Harbor changes needed.** Removed misleading criterion. 3. **tofu plan criterion added:** After updating `forgejo_repo` in k3s.tfvars, run `tofu plan -var-file=k3s.tfvars -lock=false` and verify only the ArgoCD app source URL changes. 4. **Phase 1 vs Phase 2 boundary explicit:** K8s resource names (`westside-app` Deployment, Service, Ingress, Secret) remain unchanged in Phase 1. Phase 2 creates the new `westside-app` repo for the auth portal, at which point k8s names get reassigned. No collision risk in Phase 1. ### Updated AC - [ ] Repo renamed to `westside-landing` on Forgejo - [ ] `pal-e-services/k3s.tfvars` `forgejo_repo` updated to `forgejo_admin/westside-landing` - [ ] `tofu plan` shows only ArgoCD app source URL change (no Harbor, no namespace) - [ ] CI pipeline triggers on push to `westside-landing` repo - [ ] Site remains live at `westsidekingsandqueens.tail5b443a.ts.net` - [ ] No orphaned Woodpecker webhooks ### Status: READY

forgejo_admin commented

2026-03-27 21:08:56 +00:00

Author

Owner

Scope Review: NEEDS_REFINEMENT

Review note: review-450-2026-03-27

Well-structured ticket with all template sections present and full traceability triangle. However, 5 issues need clarification before dispatch:

K8s resource naming ambiguity (critical) — Ticket conflates Forgejo repo name with k8s resource names (Deployment, Service, Ingress, Secret all named westside-app). Must clarify: are k8s names also renamed to westside-landing? This determines whether the blast radius is 3 files or 10+, and whether decomposition is needed.
Keycloak client_id collision — keycloak_clients["westside-app"] and client_id = "westside-app" will conflict with the future auth portal. Needs explicit acknowledgment as Phase 2/3 scope or addressed here.
PR scope unclear — "PR opened (for pal-e-services + pal-e-deployments changes)" implies one PR for two repos. Forgejo PRs are per-repo. Enumerate which repos get PRs.
Harbor criterion likely no-op — Harbor project is already westsidekingsandqueens (from image_repo prefix), not westside-app. Confirm or remove criterion.
Missing file target — Dev overlay at pal-e-deployments/overlays/westsidekingsandqueens/dev/deployment.yaml:50 has hostPath /home/ldraney/westside-app.

If k8s names stay unchanged, this is a clean single-agent ticket (~3 changes). If k8s names also change, recommend decomposition via template-board.

## Scope Review: NEEDS_REFINEMENT Review note: `review-450-2026-03-27` Well-structured ticket with all template sections present and full traceability triangle. However, 5 issues need clarification before dispatch: 1. **K8s resource naming ambiguity (critical)** — Ticket conflates Forgejo repo name with k8s resource names (Deployment, Service, Ingress, Secret all named `westside-app`). Must clarify: are k8s names also renamed to `westside-landing`? This determines whether the blast radius is 3 files or 10+, and whether decomposition is needed. 2. **Keycloak client_id collision** — `keycloak_clients["westside-app"]` and `client_id = "westside-app"` will conflict with the future auth portal. Needs explicit acknowledgment as Phase 2/3 scope or addressed here. 3. **PR scope unclear** — "PR opened (for pal-e-services + pal-e-deployments changes)" implies one PR for two repos. Forgejo PRs are per-repo. Enumerate which repos get PRs. 4. **Harbor criterion likely no-op** — Harbor project is already `westsidekingsandqueens` (from `image_repo` prefix), not `westside-app`. Confirm or remove criterion. 5. **Missing file target** — Dev overlay at `pal-e-deployments/overlays/westsidekingsandqueens/dev/deployment.yaml:50` has hostPath `/home/ldraney/westside-app`. If k8s names stay unchanged, this is a clean single-agent ticket (~3 changes). If k8s names also change, recommend decomposition via `template-board`.

forgejo_admin commented

2026-03-28 11:40:52 +00:00

Author

Owner

Scope Review: NEEDS_REFINEMENT

Review note: review-450-2026-03-27
Three fixable issues found in file targets and acceptance criteria.

Wrong file path: pal-e-platform/terraform/main.tf has no westside-app reference. Actual location is terraform/modules/monitoring/main.tf (lines 366-368, blackbox probe name + URL).
Missing AC: No acceptance criterion for the pal-e-platform monitoring module update (blackbox probe service name/URL). An agent following AC literally would skip this.
Multi-repo PRs not explicit: Issue touches 4 repos but doesn't explicitly state that 3 separate PRs are needed (pal-e-services, pal-e-deployments, pal-e-platform).

## Scope Review: NEEDS_REFINEMENT Review note: `review-450-2026-03-27` Three fixable issues found in file targets and acceptance criteria. - **Wrong file path**: `pal-e-platform/terraform/main.tf` has no westside-app reference. Actual location is `terraform/modules/monitoring/main.tf` (lines 366-368, blackbox probe name + URL). - **Missing AC**: No acceptance criterion for the pal-e-platform monitoring module update (blackbox probe service name/URL). An agent following AC literally would skip this. - **Multi-repo PRs not explicit**: Issue touches 4 repos but doesn't explicitly state that 3 separate PRs are needed (pal-e-services, pal-e-deployments, pal-e-platform).