fix: swap logo JPEG for transparent PNGs + optimize coach photos (#107) #108

Merged

forgejo_admin merged 1 commit from 107-fix-logo-and-coach-assets into main

2026-03-27 06:19:50 +00:00

forgejo_admin commented

2026-03-27 06:17:07 +00:00

Owner

Summary

Replace the opaque logo.jpeg with transparent PNG variants across all 9 files that reference the logo, and swap 4 oversized coach photos for optimized 800w copies on the staff page. Only src attribute values changed -- no HTML structure, CSS, or layout modifications.

Changes

src/routes/(public)/+layout.svelte: nav logo logo.jpeg -> logo-transparent.png
src/routes/(public)/+page.svelte: hero logo logo.jpeg -> logo-hero-transparent.png
src/routes/(app)/+layout.svelte: authenticated nav logo logo.jpeg -> logo-transparent.png
src/routes/(app)/signin/+page.svelte: sign-in logo logo.jpeg -> logo-transparent.png
src/routes/(app)/register/+page.svelte: registration logo logo.jpeg -> logo-transparent.png
src/routes/(app)/forgot-password/+page.svelte: forgot-password logo logo.jpeg -> logo-transparent.png
src/routes/(app)/reset-password/+page.svelte: reset-password logo logo.jpeg -> logo-transparent.png
src/routes/(app)/checkout/+page.svelte: checkout logo logo.jpeg -> logo-transparent.png
src/routes/(app)/jersey/+page.svelte: jersey page logo logo.jpeg -> logo-transparent.png
src/routes/(public)/staff/+page.svelte: 4 coach photos swapped to -800w.jpg optimized variants (james-taylor, ken-seka, kj-ng, abbie-sa); marcus.jpg unchanged (already 44KB)

Test Plan

All 9 logo images render with transparent backgrounds on dark UI
Hero logo on home page uses the larger hero-specific transparent asset
All 4 updated coach photos load on the staff page
marcus.jpg is unchanged on the staff page
No remaining references to logo.jpeg in the codebase

Review Checklist

No secrets committed
No unnecessary file changes
Commit messages are descriptive
Only src attribute values changed -- no HTML structure, CSS, or layout touched

forgejo_admin/westside-app #107 -- Bug: wrong logo assets
Closes #107

## Summary Replace the opaque `logo.jpeg` with transparent PNG variants across all 9 files that reference the logo, and swap 4 oversized coach photos for optimized 800w copies on the staff page. Only `src` attribute values changed -- no HTML structure, CSS, or layout modifications. ## Changes - `src/routes/(public)/+layout.svelte`: nav logo `logo.jpeg` -> `logo-transparent.png` - `src/routes/(public)/+page.svelte`: hero logo `logo.jpeg` -> `logo-hero-transparent.png` - `src/routes/(app)/+layout.svelte`: authenticated nav logo `logo.jpeg` -> `logo-transparent.png` - `src/routes/(app)/signin/+page.svelte`: sign-in logo `logo.jpeg` -> `logo-transparent.png` - `src/routes/(app)/register/+page.svelte`: registration logo `logo.jpeg` -> `logo-transparent.png` - `src/routes/(app)/forgot-password/+page.svelte`: forgot-password logo `logo.jpeg` -> `logo-transparent.png` - `src/routes/(app)/reset-password/+page.svelte`: reset-password logo `logo.jpeg` -> `logo-transparent.png` - `src/routes/(app)/checkout/+page.svelte`: checkout logo `logo.jpeg` -> `logo-transparent.png` - `src/routes/(app)/jersey/+page.svelte`: jersey page logo `logo.jpeg` -> `logo-transparent.png` - `src/routes/(public)/staff/+page.svelte`: 4 coach photos swapped to `-800w.jpg` optimized variants (`james-taylor`, `ken-seka`, `kj-ng`, `abbie-sa`); `marcus.jpg` unchanged (already 44KB) ## Test Plan - [ ] All 9 logo images render with transparent backgrounds on dark UI - [ ] Hero logo on home page uses the larger hero-specific transparent asset - [ ] All 4 updated coach photos load on the staff page - [ ] `marcus.jpg` is unchanged on the staff page - [ ] No remaining references to `logo.jpeg` in the codebase ## Review Checklist - [x] No secrets committed - [x] No unnecessary file changes - [x] Commit messages are descriptive - [x] Only `src` attribute values changed -- no HTML structure, CSS, or layout touched ## Related Notes - `forgejo_admin/westside-app #107` -- Bug: wrong logo assets - Closes #107

forgejo_admin added 1 commit

2026-03-27 06:17:07 +00:00

fix: swap logo JPEG for transparent PNGs + optimize coach photos

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

34070d87ff

Replace logo.jpeg with logo-transparent.png across 9 files (hero uses
logo-hero-transparent.png). Replace 4 oversized coach photos with
optimized 800w variants on staff page.

Closes #107

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented

2026-03-27 06:19:03 +00:00

Author

Owner

PR #108 Review

DOMAIN REVIEW

Tech stack: SvelteKit (static adapter), HTML/CSS, external image assets via MinIO.

This PR is a pure asset-reference change: 13 lines added, 13 lines removed, all modifying src attribute values on <img> tags. No HTML structure, CSS, JavaScript logic, or component architecture changes.

Correctness:

All 9 logo references (logo.jpeg) have been replaced: 8 files use logo-transparent.png, 1 file (hero on +page.svelte) correctly uses the larger logo-hero-transparent.png variant. Verified via codebase grep -- zero remaining logo.jpeg references.
All 4 coach photos updated to -800w.jpg optimized variants (james-taylor, ken-seka, kj-ng, abbie-sa). marcus.jpg correctly left unchanged.
width and height attributes preserved on all <img> tags -- no layout shift (CLS) regressions introduced.

Accessibility:

alt attributes unchanged and appropriate. The empty alt="" on the app layout nav logo is correct (decorative image adjacent to text "Westside" which provides the accessible name).
Public layout logo retains descriptive alt="Westside Kings & Queens" -- correct.

Performance:

Coach photo optimization (full-res to 800w variants) is a positive change for page load time, especially on mobile.
Format change from .png/.jpeg to .jpg for coaches is fine (lossy format appropriate for photos).

Pre-existing observation (not introduced by this PR):
The MinIO base URL https://minio-api.tail5b443a.ts.net/assets/westside/ is hardcoded across 22 occurrences in 12 .svelte files. Extracting this to a constant or environment variable would reduce future maintenance burden and make asset host migration a one-line change. This is not scope for this PR -- noting for future consideration.

BLOCKERS

None.

This is a pure asset-reference swap with no new functionality, no logic changes, and no user input handling. None of the BLOCKER criteria apply:

No new functionality requiring test coverage (string literal changes only)
No user input involved
No secrets or credentials
No auth/security path changes

NITS

Coach photo width/height accuracy after resize: The width="400" height="266" on kj-ng-800w.jpg and width="400" height="711" on abbie-sa-800w.jpg reflect the original aspect ratios. If the 800w resize changed the aspect ratio, these attributes should be updated to match. If the resize was proportional (which is typical), these are fine. Worth a quick visual check.

SOP COMPLIANCE

Branch named after issue: 107-fix-logo-and-coach-assets references issue #107
PR body has Summary, Changes, Test Plan, Related sections
Related section references issue #107, includes Closes #107
No secrets committed
No unnecessary file changes -- all 10 files directly relevant to the bug fix
Commit messages are descriptive

PROCESS OBSERVATIONS

Change failure risk: Very low. Pure string-literal changes to image src attributes. The only failure mode is a 404 if the new assets do not exist in MinIO at the referenced paths -- this is validated by the Test Plan's visual checks rather than automated tests, which is appropriate for static assets.
Deployment frequency: Clean bug fix, small diff, no merge conflicts. Fast to review and ship.
Documentation: No docs impact. The change is self-documenting through the PR body.

VERDICT: APPROVED

## PR #108 Review ### DOMAIN REVIEW **Tech stack:** SvelteKit (static adapter), HTML/CSS, external image assets via MinIO. This PR is a pure asset-reference change: 13 lines added, 13 lines removed, all modifying `src` attribute values on `<img>` tags. No HTML structure, CSS, JavaScript logic, or component architecture changes. **Correctness:** - All 9 logo references (`logo.jpeg`) have been replaced: 8 files use `logo-transparent.png`, 1 file (hero on `+page.svelte`) correctly uses the larger `logo-hero-transparent.png` variant. Verified via codebase grep -- zero remaining `logo.jpeg` references. - All 4 coach photos updated to `-800w.jpg` optimized variants (`james-taylor`, `ken-seka`, `kj-ng`, `abbie-sa`). `marcus.jpg` correctly left unchanged. - `width` and `height` attributes preserved on all `<img>` tags -- no layout shift (CLS) regressions introduced. **Accessibility:** - `alt` attributes unchanged and appropriate. The empty `alt=""` on the app layout nav logo is correct (decorative image adjacent to text "Westside" which provides the accessible name). - Public layout logo retains descriptive `alt="Westside Kings & Queens"` -- correct. **Performance:** - Coach photo optimization (full-res to 800w variants) is a positive change for page load time, especially on mobile. - Format change from `.png`/`.jpeg` to `.jpg` for coaches is fine (lossy format appropriate for photos). **Pre-existing observation (not introduced by this PR):** The MinIO base URL `https://minio-api.tail5b443a.ts.net/assets/westside/` is hardcoded across 22 occurrences in 12 `.svelte` files. Extracting this to a constant or environment variable would reduce future maintenance burden and make asset host migration a one-line change. This is not scope for this PR -- noting for future consideration. ### BLOCKERS None. This is a pure asset-reference swap with no new functionality, no logic changes, and no user input handling. None of the BLOCKER criteria apply: - No new functionality requiring test coverage (string literal changes only) - No user input involved - No secrets or credentials - No auth/security path changes ### NITS 1. **Coach photo `width`/`height` accuracy after resize:** The `width="400" height="266"` on `kj-ng-800w.jpg` and `width="400" height="711"` on `abbie-sa-800w.jpg` reflect the original aspect ratios. If the 800w resize changed the aspect ratio, these attributes should be updated to match. If the resize was proportional (which is typical), these are fine. Worth a quick visual check. ### SOP COMPLIANCE - [x] Branch named after issue: `107-fix-logo-and-coach-assets` references issue #107 - [x] PR body has Summary, Changes, Test Plan, Related sections - [x] Related section references issue #107, includes `Closes #107` - [x] No secrets committed - [x] No unnecessary file changes -- all 10 files directly relevant to the bug fix - [x] Commit messages are descriptive ### PROCESS OBSERVATIONS - **Change failure risk:** Very low. Pure string-literal changes to image `src` attributes. The only failure mode is a 404 if the new assets do not exist in MinIO at the referenced paths -- this is validated by the Test Plan's visual checks rather than automated tests, which is appropriate for static assets. - **Deployment frequency:** Clean bug fix, small diff, no merge conflicts. Fast to review and ship. - **Documentation:** No docs impact. The change is self-documenting through the PR body. ### VERDICT: APPROVED