Remove date field from contract signing section #13

New issue

Closed

opened 2026-03-24 20:16:24 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-24 20:16:24 +00:00

Owner

Type

Feature

Lineage

plan-wkq → Phase 14 (Billing Tiers & Contracts) — simplification from E2E testing

Repo

forgejo_admin/westside-contracts

User Story

As a parent signing a contract on mobile
I want a clean signing experience without a non-functional date field
So that I'm not confused by UI elements I can't interact with

Context

The date field on the contract signing page adds no value. The server records contract_signed_at = NOW() independently. The display date is cosmetic. The field has caused two bugs (#9 SSR timezone, #11 no calendar picker) and still shows raw ISO format on some browsers. Remove it entirely. The success overlay already shows "Signed on {date}" which is sufficient.

File Targets

src/routes/contract/[token]/+page.svelte — remove the date form-group div (the label + input for "Date"), remove dateStr state variable and its onMount logic, keep displayDate derived for the success overlay

Acceptance Criteria

No date field visible in the signing section
Success overlay still shows "Signed on March 24, 2026" (human-readable)
No regression in form validation or submit flow
Build passes, tests pass

Test Expectations

Playwright: navigate to contract, check agree, sign, submit — no date field present, success overlay shows date
Run command: npm run build && npm test

Constraints

Keep the displayDate derived value for the success overlay
Remove dateStr $state and its onMount block if no longer needed
Do not touch any other functionality

Checklist

PR opened
Tests pass
No unrelated changes

project-westside-basketball
forgejo_admin/westside-contracts #9 — SSR timezone fix (now moot)
forgejo_admin/westside-contracts #11 — calendar picker fix (now moot)

### Type Feature ### Lineage `plan-wkq` → Phase 14 (Billing Tiers & Contracts) — simplification from E2E testing ### Repo `forgejo_admin/westside-contracts` ### User Story As a parent signing a contract on mobile I want a clean signing experience without a non-functional date field So that I'm not confused by UI elements I can't interact with ### Context The date field on the contract signing page adds no value. The server records `contract_signed_at = NOW()` independently. The display date is cosmetic. The field has caused two bugs (#9 SSR timezone, #11 no calendar picker) and still shows raw ISO format on some browsers. Remove it entirely. The success overlay already shows "Signed on {date}" which is sufficient. ### File Targets - `src/routes/contract/[token]/+page.svelte` — remove the date form-group div (the label + input for "Date"), remove `dateStr` state variable and its onMount logic, keep `displayDate` derived for the success overlay ### Acceptance Criteria - [ ] No date field visible in the signing section - [ ] Success overlay still shows "Signed on March 24, 2026" (human-readable) - [ ] No regression in form validation or submit flow - [ ] Build passes, tests pass ### Test Expectations - [ ] Playwright: navigate to contract, check agree, sign, submit — no date field present, success overlay shows date - Run command: `npm run build && npm test` ### Constraints - Keep the `displayDate` derived value for the success overlay - Remove `dateStr` $state and its onMount block if no longer needed - Do not touch any other functionality ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - `project-westside-basketball` - `forgejo_admin/westside-contracts #9` — SSR timezone fix (now moot) - `forgejo_admin/westside-contracts #11` — calendar picker fix (now moot)