forgejo_admin/westside-playground
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

feat: coach page tab navigation + remove browse teams #20

Merged
forgejo_admin merged 1 commit from 19-feat-coach-page-tab-navigation-team-play into main 2026-03-16 22:41:34 +00:00
Conversation 1 Commits 1 Files changed 1 +202 -179
forgejo_admin commented 2026-03-16 22:36:13 +00:00
Owner
Copy link

Summary

Adds two-tab navigation (Team / Plays) to the coach dashboard and removes the Browse Teams section entirely. Coaches now see only their roster and plays -- nothing else.

Changes

  • coach.html: Added tab bar with Team (default active) and Plays tabs using role="tablist" / role="tab" / role="tabpanel" ARIA attributes. Team tab wraps the existing search bar and roster grid unchanged. Plays tab shows a "Coming Soon" placeholder. Removed the Browse Teams section and the coach-actions quick links row. Added minimal JS (14 lines) for tab switching. All styles use existing design tokens from shared/app.css.

Test Plan

  • Open coach.html in a browser
  • Team tab is active by default with the full 8-player roster grid
  • Click Plays tab -- roster hides, placeholder appears
  • Click Team tab again -- roster returns
  • Browse Teams section is gone
  • No other files modified

Review Checklist

  • Passed automated review-fix loop
  • No secrets committed
  • No unnecessary file changes
  • Commit messages are descriptive

Related

  • Closes #19
  • Plan: plan-wkq
## Summary Adds two-tab navigation (Team / Plays) to the coach dashboard and removes the Browse Teams section entirely. Coaches now see only their roster and plays -- nothing else. ## Changes - `coach.html`: Added tab bar with Team (default active) and Plays tabs using `role="tablist"` / `role="tab"` / `role="tabpanel"` ARIA attributes. Team tab wraps the existing search bar and roster grid unchanged. Plays tab shows a "Coming Soon" placeholder. Removed the Browse Teams section and the coach-actions quick links row. Added minimal JS (14 lines) for tab switching. All styles use existing design tokens from `shared/app.css`. ## Test Plan - [ ] Open `coach.html` in a browser - [ ] Team tab is active by default with the full 8-player roster grid - [ ] Click Plays tab -- roster hides, placeholder appears - [ ] Click Team tab again -- roster returns - [ ] Browse Teams section is gone - [ ] No other files modified ## Review Checklist - [x] Passed automated review-fix loop - [x] No secrets committed - [x] No unnecessary file changes - [x] Commit messages are descriptive ## Related - Closes #19 - Plan: `plan-wkq`
Add two-tab navigation to the coach dashboard so coaches see only their
roster and plays. Team tab is default active with the existing roster grid.
Plays tab shows a "Coming Soon" placeholder. The Browse Teams section is
removed entirely to simplify the coach experience.

Closes #19

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
forgejo_admin commented 2026-03-16 22:36:44 +00:00
Author
Owner
Copy link

Review -- Pass

Scope: Only coach.html modified (1 file, +202/-179 lines).

Correctness: All #19 requirements met -- two-tab navigation (Team default active, Plays placeholder), Browse Teams section fully removed.

Accessibility: Proper ARIA pattern -- role="tablist" container, role="tab" buttons with aria-selected/aria-controls, role="tabpanel" on panels. Tabs are native <button> elements (keyboard-accessible).

CSS: All styles use existing design tokens from shared/app.css. No hardcoded values. Removed stale .coach-actions and a.team-card CSS that was only used in deleted sections.

JS: Minimal (14 lines), no dependencies, straightforward class toggling.

No issues found.

## Review -- Pass **Scope**: Only `coach.html` modified (1 file, +202/-179 lines). **Correctness**: All #19 requirements met -- two-tab navigation (Team default active, Plays placeholder), Browse Teams section fully removed. **Accessibility**: Proper ARIA pattern -- `role="tablist"` container, `role="tab"` buttons with `aria-selected`/`aria-controls`, `role="tabpanel"` on panels. Tabs are native `<button>` elements (keyboard-accessible). **CSS**: All styles use existing design tokens from `shared/app.css`. No hardcoded values. Removed stale `.coach-actions` and `a.team-card` CSS that was only used in deleted sections. **JS**: Minimal (14 lines), no dependencies, straightforward class toggling. **No issues found.**
forgejo_admin deleted branch 19-feat-coach-page-tab-navigation-team-play 2026-03-16 22:41:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo_admin/westside-playground!20
No description provided.