Bug: /public/teams endpoint may not filter by is_public #254

New issue

Open

opened 2026-03-29 22:31:34 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-29 22:31:34 +00:00

Contributor

Type

Bug

Lineage

Discovered during westside-landing#111 validation. The admin toggle was built but the public endpoint may not respect it.

Repo

forgejo_admin/basketball-api

What Broke

The /public/teams API returns 37 players across 7 teams. The response does not include an is_public field, and it's unclear whether the endpoint filters by Player.is_public. If it doesn't, then the admin bulk visibility toggle (westside-landing#111) has no effect on the public /teams page.

Repro Steps

curl -s https://basketball-api.tail5b443a.ts.net/public/teams | python3 -m json.tool
Observe: 37 players returned, no is_public field in response
Check source: does the query filter by is_public=True?

Expected Behavior

/public/teams should only return players where is_public=True. Teams with zero public players should be excluded.

Environment

Cluster/namespace: prod
Service: basketball-api
Endpoint: GET /public/teams

Acceptance Criteria

/public/teams filters players by is_public=True
Teams with zero public players are excluded from response
Admin toggling is_public via #111 UI reflects on public /teams page
Verify with Chrome DevTools on https://westsidekingsandqueens.tail5b443a.ts.net/teams

forgejo_admin/westside-landing#111 — admin toggle (merged)
project-westside-basketball

### Type Bug ### Lineage Discovered during westside-landing#111 validation. The admin toggle was built but the public endpoint may not respect it. ### Repo `forgejo_admin/basketball-api` ### What Broke The `/public/teams` API returns 37 players across 7 teams. The response does not include an `is_public` field, and it's unclear whether the endpoint filters by `Player.is_public`. If it doesn't, then the admin bulk visibility toggle (westside-landing#111) has no effect on the public /teams page. ### Repro Steps 1. `curl -s https://basketball-api.tail5b443a.ts.net/public/teams | python3 -m json.tool` 2. Observe: 37 players returned, no `is_public` field in response 3. Check source: does the query filter by `is_public=True`? ### Expected Behavior `/public/teams` should only return players where `is_public=True`. Teams with zero public players should be excluded. ### Environment - Cluster/namespace: prod - Service: basketball-api - Endpoint: `GET /public/teams` ### Acceptance Criteria - [ ] `/public/teams` filters players by `is_public=True` - [ ] Teams with zero public players are excluded from response - [ ] Admin toggling `is_public` via #111 UI reflects on public /teams page - [ ] Verify with Chrome DevTools on https://westsidekingsandqueens.tail5b443a.ts.net/teams ### Related - `forgejo_admin/westside-landing#111` — admin toggle (merged) - `project-westside-basketball`