Clean up QA nits from dual-auth and jersey profile PRs #260

New issue

Open

opened 2026-03-30 21:01:51 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-30 21:01:51 +00:00

Contributor

Type

Feature

Lineage

Discovered scope from QA reviews of PR #258 and PR #259 (2026-03-30).

Repo

forgejo_admin/basketball-api

User Story

As a developer
I want auth and profile code to follow consistent type annotation patterns
So that the codebase stays clean and self-documenting

Context

QA reviews of PR #258 (dual-auth) and PR #259 (jersey profile fields) flagged three non-blocking nits that were approved but deferred.

File Targets

Files the agent should modify:

src/basketball_api/auth.py -- (1) Add return type annotation to get_parent_dual_auth, (2) Remove redundant alias on token query param if Query default already matches
src/basketball_api/routes/players.py -- (3) Change jersey_order_status: str | None to str in PlayerProfileResponse since the model server default guarantees non-null

Files the agent should NOT touch:

Any other files -- these are scoped nits only

Acceptance Criteria

get_parent_dual_auth has a return type annotation
Token query param has no redundant alias
jersey_order_status is typed as str (non-optional) in PlayerProfileResponse

Test Expectations

Existing tests pass with no changes needed
Run command: pytest tests/ -x -q

Constraints

Cosmetic only -- no behavioral changes
Must not break any existing tests

Checklist

PR opened
Tests pass
No unrelated changes

project-westside-basketball
PR #258, PR #259 -- source of these nits

### Type Feature ### Lineage Discovered scope from QA reviews of PR #258 and PR #259 (2026-03-30). ### Repo `forgejo_admin/basketball-api` ### User Story As a developer I want auth and profile code to follow consistent type annotation patterns So that the codebase stays clean and self-documenting ### Context QA reviews of PR #258 (dual-auth) and PR #259 (jersey profile fields) flagged three non-blocking nits that were approved but deferred. ### File Targets Files the agent should modify: - `src/basketball_api/auth.py` -- (1) Add return type annotation to `get_parent_dual_auth`, (2) Remove redundant `alias` on token query param if Query default already matches - `src/basketball_api/routes/players.py` -- (3) Change `jersey_order_status: str | None` to `str` in PlayerProfileResponse since the model server default guarantees non-null Files the agent should NOT touch: - Any other files -- these are scoped nits only ### Acceptance Criteria - [ ] `get_parent_dual_auth` has a return type annotation - [ ] Token query param has no redundant alias - [ ] `jersey_order_status` is typed as `str` (non-optional) in PlayerProfileResponse ### Test Expectations - [ ] Existing tests pass with no changes needed - Run command: `pytest tests/ -x -q` ### Constraints - Cosmetic only -- no behavioral changes - Must not break any existing tests ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - `project-westside-basketball` - PR #258, PR #259 -- source of these nits