fix: remove unreachable pal-e-docs refs + add claude-code-guide to spawn schema #105

New issue

Closed

opened 2026-03-15 01:43:51 +00:00 by forgejo_admin · 1 comment

forgejo_admin commented

2026-03-15 01:43:51 +00:00

Contributor

Lineage

plan-pal-e-agency → Phase 12 → Phase 12v (validation gate)

Repo

forgejo_admin/claude-custom

User Story

As Betty Sue
I want agent configs that don't produce guaranteed-to-fail tool calls
So that every agent spawn is clean, token-efficient, and the spawn gate allows all built-in agent types

Context

Phase 12v L1 smoke tests found two issues blocking validation:

Finding 5: Six agent configs (dev-backend, dev-frontend, devops, dev-qa, devops-qa, frontend-qa) contain Read your full profile: mcp__pal-e-docs__get_note(slug="agent-...") but these agents only have mcpServers: [forgejo]. Every spawn produces a failed tool call — wasted tokens and noise. Dottie is the only agent with pal-e-docs access and already has the correct instruction.

Finding 4: schemas/agent-spawn-requirements.json has Explore (empty required_patterns) but is missing claude-code-guide. The spawn gate hook blocks claude-code-guide spawns for help queries.

File Targets

Files the agent should modify:

agents/dev-backend.md — remove the Read your full profile and pal-e-docs get_note line (lines 12-13)
agents/dev-frontend.md — remove the same lines (lines 12-13)
agents/devops.md — remove the same lines (lines 12-13)
agents/dev-qa.md — remove the same lines (lines 18-19)
agents/devops-qa.md — remove the same lines (lines 18-19)
agents/frontend-qa.md — remove the same lines (lines 18-19)
schemas/agent-spawn-requirements.json — add claude-code-guide entry with empty required_patterns

Files the agent should NOT touch:

agents/dottie.md — Dottie HAS pal-e-docs access, its instruction is correct
agents/betty-sue.md — Betty Sue's config is separate
agents/dev.md.deprecated — already deprecated
agents/qa.md.deprecated — already deprecated

Acceptance Criteria

No agent config references mcp__pal-e-docs__get_note unless the agent has pal-e-docs in its mcpServers frontmatter
claude-code-guide entry exists in schemas/agent-spawn-requirements.json with required_patterns: []
All 6 agent configs still have complete Role, Access, MCP Tools, Constraints, and Output sections
JSON schema is valid (no trailing commas, proper structure)

Test Expectations

Manual: verify jq . schemas/agent-spawn-requirements.json parses without error
Manual: grep all agent .md files for mcp__pal-e-docs__get_note — should only match dottie.md
Run command: grep -r "mcp__pal-e-docs__get_note" agents/ should return only agents/dottie.md

Constraints

Match the existing Explore entry pattern for claude-code-guide (read-only, no gate)
Do not change any other content in the agent configs — only remove the unreachable pal-e-docs lines
Keep the # Agent: X heading and role description intact

Checklist

PR opened
Tests pass (jq validation + grep check)
No unrelated changes

project-pal-e-agency — Agency project
Phase 12v memory: project_phase12v_progress.md Findings 4+5

### Lineage `plan-pal-e-agency` → Phase 12 → Phase 12v (validation gate) ### Repo `forgejo_admin/claude-custom` ### User Story As Betty Sue I want agent configs that don't produce guaranteed-to-fail tool calls So that every agent spawn is clean, token-efficient, and the spawn gate allows all built-in agent types ### Context Phase 12v L1 smoke tests found two issues blocking validation: **Finding 5:** Six agent configs (dev-backend, dev-frontend, devops, dev-qa, devops-qa, frontend-qa) contain `Read your full profile: mcp__pal-e-docs__get_note(slug="agent-...")` but these agents only have `mcpServers: [forgejo]`. Every spawn produces a failed tool call — wasted tokens and noise. Dottie is the only agent with pal-e-docs access and already has the correct instruction. **Finding 4:** `schemas/agent-spawn-requirements.json` has `Explore` (empty required_patterns) but is missing `claude-code-guide`. The spawn gate hook blocks claude-code-guide spawns for help queries. ### File Targets Files the agent should modify: - `agents/dev-backend.md` — remove the `Read your full profile` and pal-e-docs get_note line (lines 12-13) - `agents/dev-frontend.md` — remove the same lines (lines 12-13) - `agents/devops.md` — remove the same lines (lines 12-13) - `agents/dev-qa.md` — remove the same lines (lines 18-19) - `agents/devops-qa.md` — remove the same lines (lines 18-19) - `agents/frontend-qa.md` — remove the same lines (lines 18-19) - `schemas/agent-spawn-requirements.json` — add `claude-code-guide` entry with empty required_patterns Files the agent should NOT touch: - `agents/dottie.md` — Dottie HAS pal-e-docs access, its instruction is correct - `agents/betty-sue.md` — Betty Sue's config is separate - `agents/dev.md.deprecated` — already deprecated - `agents/qa.md.deprecated` — already deprecated ### Acceptance Criteria - [ ] No agent config references `mcp__pal-e-docs__get_note` unless the agent has `pal-e-docs` in its mcpServers frontmatter - [ ] `claude-code-guide` entry exists in `schemas/agent-spawn-requirements.json` with `required_patterns: []` - [ ] All 6 agent configs still have complete Role, Access, MCP Tools, Constraints, and Output sections - [ ] JSON schema is valid (no trailing commas, proper structure) ### Test Expectations - [ ] Manual: verify `jq . schemas/agent-spawn-requirements.json` parses without error - [ ] Manual: grep all agent .md files for `mcp__pal-e-docs__get_note` — should only match dottie.md - Run command: `grep -r "mcp__pal-e-docs__get_note" agents/` should return only `agents/dottie.md` ### Constraints - Match the existing `Explore` entry pattern for `claude-code-guide` (read-only, no gate) - Do not change any other content in the agent configs — only remove the unreachable pal-e-docs lines - Keep the `# Agent: X` heading and role description intact ### Checklist - [ ] PR opened - [ ] Tests pass (jq validation + grep check) - [ ] No unrelated changes ### Related - `project-pal-e-agency` — Agency project - Phase 12v memory: `project_phase12v_progress.md` Findings 4+5