Clean up remaining deprecated agent type references #126

New issue

Closed

opened 2026-03-18 18:02:10 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-18 18:02:10 +00:00

Contributor

Lineage

Discovered scope from PR #125 (QA review nits)

Repo

forgejo_admin/claude-custom

User Story

As Betty Sue
I want dead references to deprecated agent types removed from hooks and settings
So that the codebase reflects the current 5-agent model and doesn't confuse future readers

Context

PR #125 removed the 6 deprecated agent types from agent-spawn-requirements.json. QA review found two files that still reference them. These are non-functional (the schema drives behavior), but they're dead code that should be cleaned up for clarity.

File Targets

Files to modify:

hooks/inject-subagent-context.sh — remove case branches for dev-backend, dev-frontend, devops, dev-qa, frontend-qa, devops-qa
settings.json — remove deprecated agent types from matcher around line 232

Files NOT to touch:

schemas/agent-spawn-requirements.json — already cleaned up in PR #125
hooks/check-agent-spawn.sh — schema-driven, no changes needed

Acceptance Criteria

No references to dev-backend, dev-frontend, devops, dev-qa, frontend-qa, or devops-qa remain in hooks or settings
Existing agent types (dev, qa, dottie, general-purpose, Explore, claude-code-guide) still work correctly

Test Expectations

Manual: spawn each current agent type — should still work
Manual: grep for deprecated type names — should return zero matches

Constraints

Only remove deprecated references. Do not refactor or restructure surrounding code.

Checklist

PR opened
Tests pass
No unrelated changes

plan-pal-e-agency — Phase 12 deprecated the specialized agents
PR #125 — the schema cleanup that surfaced this

### Lineage Discovered scope from PR #125 (QA review nits) ### Repo `forgejo_admin/claude-custom` ### User Story As Betty Sue I want dead references to deprecated agent types removed from hooks and settings So that the codebase reflects the current 5-agent model and doesn't confuse future readers ### Context PR #125 removed the 6 deprecated agent types from `agent-spawn-requirements.json`. QA review found two files that still reference them. These are non-functional (the schema drives behavior), but they're dead code that should be cleaned up for clarity. ### File Targets Files to modify: - `hooks/inject-subagent-context.sh` — remove case branches for `dev-backend`, `dev-frontend`, `devops`, `dev-qa`, `frontend-qa`, `devops-qa` - `settings.json` — remove deprecated agent types from matcher around line 232 Files NOT to touch: - `schemas/agent-spawn-requirements.json` — already cleaned up in PR #125 - `hooks/check-agent-spawn.sh` — schema-driven, no changes needed ### Acceptance Criteria - [ ] No references to `dev-backend`, `dev-frontend`, `devops`, `dev-qa`, `frontend-qa`, or `devops-qa` remain in hooks or settings - [ ] Existing agent types (`dev`, `qa`, `dottie`, `general-purpose`, `Explore`, `claude-code-guide`) still work correctly ### Test Expectations - [ ] Manual: spawn each current agent type — should still work - [ ] Manual: grep for deprecated type names — should return zero matches ### Constraints - Only remove deprecated references. Do not refactor or restructure surrounding code. ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - `plan-pal-e-agency` — Phase 12 deprecated the specialized agents - PR #125 — the schema cleanup that surfaced this