Nit-bundle: PR #140 — update-docs skill polish #142

New issue

Open

opened 2026-03-21 17:31:49 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-21 17:31:49 +00:00

Contributor

Type

Nit-Bundle

Source

PR #140 on forgejo_admin/claude-custom — QA verdict: APPROVED with nits

Original Work

plan-pal-e-agency → Phase 18 → 18e → Forgejo Issue #138

Nits

Step 2 bash snippet incomplete — The Woodpecker pipeline check snippet is less complete than other steps that provide full commands. Should include a concrete mcp__woodpecker__list_pipelines or curl example.
Step 9 cross-PR dependency — Step 9 references template-issue-nit-bundle which required PR #139 to merge first. This is correct behavior but could note the dependency explicitly.
Missing plan slug in PR Related — PR body's Related section didn't reference plan-pal-e-agency. Same process gap as PR #139 — dev agent prompt pattern.
Escaped newlines in step 9 — ### Type\\nNit-Bundle uses escaped newlines that could confuse agents. Should use a code block or clearer formatting.

Segmentation Notes

Nits 1, 2, 4 are all in commands/update-docs.md — one PR. Nit 3 is a process gap (dev agent prompt), not a code change. Recommend keeping bundled.

Acceptance Criteria

Step 2 has a complete Woodpecker check command
Step 9 newline formatting is agent-friendly
No regression in other steps

plan-pal-e-agency — parent plan
phase-pal-e-agency-18-enterprise-definitions — parent phase
forgejo_admin/claude-custom #138 — original issue
forgejo_admin/claude-custom #140 — the PR where nits were identified

### Type Nit-Bundle ### Source PR #140 on `forgejo_admin/claude-custom` — QA verdict: APPROVED with nits ### Original Work `plan-pal-e-agency` → Phase 18 → 18e → Forgejo Issue #138 ### Nits 1. **Step 2 bash snippet incomplete** — The Woodpecker pipeline check snippet is less complete than other steps that provide full commands. Should include a concrete `mcp__woodpecker__list_pipelines` or curl example. 2. **Step 9 cross-PR dependency** — Step 9 references `template-issue-nit-bundle` which required PR #139 to merge first. This is correct behavior but could note the dependency explicitly. 3. **Missing plan slug in PR Related** — PR body's Related section didn't reference `plan-pal-e-agency`. Same process gap as PR #139 — dev agent prompt pattern. 4. **Escaped newlines in step 9** — `### Type\\nNit-Bundle` uses escaped newlines that could confuse agents. Should use a code block or clearer formatting. ### Segmentation Notes Nits 1, 2, 4 are all in `commands/update-docs.md` — one PR. Nit 3 is a process gap (dev agent prompt), not a code change. Recommend keeping bundled. ### Acceptance Criteria - [ ] Step 2 has a complete Woodpecker check command - [ ] Step 9 newline formatting is agent-friendly - [ ] No regression in other steps ### Related - `plan-pal-e-agency` — parent plan - `phase-pal-e-agency-18-enterprise-definitions` — parent phase - `forgejo_admin/claude-custom #138` — original issue - `forgejo_admin/claude-custom #140` — the PR where nits were identified