Nit-bundle: PR #144 — orphan plan fail-open + minor polish #145

New issue

Open

opened 2026-03-22 06:57:31 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-22 06:57:31 +00:00

Contributor

Type

Nit-Bundle

Source

PR #144 on forgejo_admin/claude-custom — QA verdict: APPROVED with nits

Original Work

plan-pal-e-agency → Phase 20 → Forgejo Issue #143

Nits

Dropped orphan plan fail-open — Plans without project.slug (orphan plans) previously got TOC injection via a fail-open clause. The 20b refactor removed this clause. Such plans now silently lose TOC injection in both scoped and unscoped paths. Should add: elif [[ -z "$plan_project_slug" ]]; then inject_toc=true in the unscoped branch.
Missing plan slug in PR Related — PR body's Related section didn't reference plan-pal-e-agency. Same dev agent prompt pattern gap as PRs #139 and #140.
Efficiency nit — Board items are fetched per-board in the scoped path even for non-matching boards. Could skip fetching full items for non-matching boards and just fetch counts.
Consistency nit — Minor observation from QA (details in PR comment).

Segmentation Notes

Nit #1 is the most important — a real behavioral regression for orphan plans. Should be fixed. Nits #2-4 are minor polish. Recommend keeping bundled since all are in the same file.

Acceptance Criteria

Orphan plans (no project.slug) get TOC injection via fail-open
No regression in project-scoped behavior
Tests pass

plan-pal-e-agency — parent plan
phase-pal-e-agency-20-context-scoped-sessions — parent phase
forgejo_admin/claude-custom #143 — original issue
forgejo_admin/claude-custom #144 — the PR where nits were identified

### Type Nit-Bundle ### Source PR #144 on `forgejo_admin/claude-custom` — QA verdict: APPROVED with nits ### Original Work `plan-pal-e-agency` → Phase 20 → Forgejo Issue #143 ### Nits 1. **Dropped orphan plan fail-open** — Plans without `project.slug` (orphan plans) previously got TOC injection via a fail-open clause. The 20b refactor removed this clause. Such plans now silently lose TOC injection in both scoped and unscoped paths. Should add: `elif [[ -z "$plan_project_slug" ]]; then inject_toc=true` in the unscoped branch. 2. **Missing plan slug in PR Related** — PR body's Related section didn't reference `plan-pal-e-agency`. Same dev agent prompt pattern gap as PRs #139 and #140. 3. **Efficiency nit** — Board items are fetched per-board in the scoped path even for non-matching boards. Could skip fetching full items for non-matching boards and just fetch counts. 4. **Consistency nit** — Minor observation from QA (details in PR comment). ### Segmentation Notes Nit #1 is the most important — a real behavioral regression for orphan plans. Should be fixed. Nits #2-4 are minor polish. Recommend keeping bundled since all are in the same file. ### Acceptance Criteria - [ ] Orphan plans (no project.slug) get TOC injection via fail-open - [ ] No regression in project-scoped behavior - [ ] Tests pass ### Related - `plan-pal-e-agency` — parent plan - `phase-pal-e-agency-20-context-scoped-sessions` — parent phase - `forgejo_admin/claude-custom #143` — original issue - `forgejo_admin/claude-custom #144` — the PR where nits were identified