Nit-bundle: PR #149 — origin fallback hardcoding + long line #150

New issue

Open

opened 2026-03-22 09:51:50 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-22 09:51:50 +00:00

Contributor

Type

Nit-Bundle

Source

PR #149 on forgejo_admin/claude-custom — QA verdict: APPROVED with nits

Original Work

plan-pal-e-agency → Phase 20 validation → Forgejo Issue #148

Nits

Pre-existing origin hardcoding in fallback functions — Lines 22 and 29 (is_forgejo_repo and is_github_repo inline fallbacks) still hardcode origin. Out of scope for #148 but should use the same remote fallback pattern.
Long line — Line 71 (the new fallback) is a dense one-liner. Multi-line form would improve readability.

Segmentation Notes

Both in the same file, related to remote detection. Keep bundled.

Acceptance Criteria

Fallback functions at lines 22/29 use the same remote detection pattern
Line 71 reformatted for readability
No regression

plan-pal-e-agency — parent plan
forgejo_admin/claude-custom #148 — original issue
forgejo_admin/claude-custom #149 — the PR where nits were identified

### Type Nit-Bundle ### Source PR #149 on `forgejo_admin/claude-custom` — QA verdict: APPROVED with nits ### Original Work `plan-pal-e-agency` → Phase 20 validation → Forgejo Issue #148 ### Nits 1. **Pre-existing `origin` hardcoding in fallback functions** — Lines 22 and 29 (`is_forgejo_repo` and `is_github_repo` inline fallbacks) still hardcode `origin`. Out of scope for #148 but should use the same remote fallback pattern. 2. **Long line** — Line 71 (the new fallback) is a dense one-liner. Multi-line form would improve readability. ### Segmentation Notes Both in the same file, related to remote detection. Keep bundled. ### Acceptance Criteria - [ ] Fallback functions at lines 22/29 use the same remote detection pattern - [ ] Line 71 reformatted for readability - [ ] No regression ### Related - `plan-pal-e-agency` — parent plan - `forgejo_admin/claude-custom #148` — original issue - `forgejo_admin/claude-custom #149` — the PR where nits were identified