Bug: review-ticket SKILL.md lists 'incident' as valid item_type but it does not exist in BoardItemType enum #192

New issue

Open

opened 2026-03-28 04:01:25 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-28 04:01:25 +00:00

Contributor

Type

Bug

Lineage

Standalone -- discovered during file target verification for forgejo_admin/claude-custom#181 (BoardItemType rename decomposition).

Repo

forgejo_admin/claude-custom

What Broke

skills/review-ticket/SKILL.md line 27 lists the valid item_type values as:

(phase, issue, incident, repo)

The value incident does not exist in the BoardItemType enum. The actual enum values are: plan, phase, issue, repo, project, todo.

Additionally, plan, project, and todo are missing from the SKILL.md list despite being valid enum values.

This means the skill documentation is misleading agents -- if an agent tries to route an incident-type board item, the routing logic will not match any known type.

Repro Steps

Read skills/review-ticket/SKILL.md line 27
Compare against BoardItemType enum in pal-e-api at src/pal_e_docs/models.py lines 34-40
Observe: incident is listed in SKILL.md but does not exist in the enum; plan, project, todo are in the enum but missing from SKILL.md

Expected Behavior

Line 27 should list only values that exist in BoardItemType. After the rename (if #181 lands first):

- `item_type` (plan, phase, ticket, repo, project, todo)

If this bug is fixed before #181, use issue instead of ticket.

Environment

File: skills/review-ticket/SKILL.md line 27
Source of truth: src/pal_e_docs/models.py lines 34-40 in pal-e-api

Acceptance Criteria

incident is removed from SKILL.md line 27
All valid BoardItemType values are listed
No phantom enum values referenced anywhere in the skill

forgejo_admin/claude-custom#181 -- parent rename ticket where this was discovered
pal-e-agency -- project this affects

### Type Bug ### Lineage Standalone -- discovered during file target verification for `forgejo_admin/claude-custom#181` (BoardItemType rename decomposition). ### Repo `forgejo_admin/claude-custom` ### What Broke `skills/review-ticket/SKILL.md` line 27 lists the valid `item_type` values as: ``` (phase, issue, incident, repo) ``` The value `incident` does not exist in the `BoardItemType` enum. The actual enum values are: `plan`, `phase`, `issue`, `repo`, `project`, `todo`. Additionally, `plan`, `project`, and `todo` are missing from the SKILL.md list despite being valid enum values. This means the skill documentation is misleading agents -- if an agent tries to route an `incident`-type board item, the routing logic will not match any known type. ### Repro Steps 1. Read `skills/review-ticket/SKILL.md` line 27 2. Compare against `BoardItemType` enum in `pal-e-api` at `src/pal_e_docs/models.py` lines 34-40 3. Observe: `incident` is listed in SKILL.md but does not exist in the enum; `plan`, `project`, `todo` are in the enum but missing from SKILL.md ### Expected Behavior Line 27 should list only values that exist in `BoardItemType`. After the rename (if #181 lands first): ``` - `item_type` (plan, phase, ticket, repo, project, todo) ``` If this bug is fixed before #181, use `issue` instead of `ticket`. ### Environment - File: `skills/review-ticket/SKILL.md` line 27 - Source of truth: `src/pal_e_docs/models.py` lines 34-40 in pal-e-api ### Acceptance Criteria - [ ] `incident` is removed from SKILL.md line 27 - [ ] All valid `BoardItemType` values are listed - [ ] No phantom enum values referenced anywhere in the skill ### Related - `forgejo_admin/claude-custom#181` -- parent rename ticket where this was discovered - `pal-e-agency` -- project this affects