Enhance skill-review-ticket: verify arch/story notes exist, auto-decompose #217

New issue

Closed

opened 2026-03-28 19:09:34 +00:00 by forgejo_admin · 2 comments

forgejo_admin commented

2026-03-28 19:09:34 +00:00

Contributor

Type

Feature

Lineage

Discovered during westside roster session 2026-03-28. Review skill checks labels but not backing notes. Decomposition is recommended but not executed.

Repo

forgejo_admin/claude-custom

User Story

As Ava, I want the ticket review to verify that architecture and user story notes actually exist in pal-e-docs so that traceability is real, not just labels.

Context

Current skill-review-ticket (in pal-e-docs) checks:

Template completeness
Traceability triangle (story: label, arch: label, issue URL)
File targets, decomposition need

Gaps identified:

arch:X label is checked but the corresponding arch note (e.g. arch-groupme, arch-westside-app) is never verified to exist in pal-e-docs
story:X label is checked but the backing user story is never verified to exist on the project page
When decomposition is recommended (NEEDS_REFINEMENT + DECOMPOSE tag), the sub-tickets are not auto-created -- a human or separate agent must do it manually
No check for whether child boards (template-board) are needed for complex work

Proposed changes to skill-review-ticket:

Step 4 (traceability): After checking labels, call search_notes(query="arch-{X}") and get_section(slug="project-{project}", anchor_id="user-stories") to verify backing notes exist. If missing, add [SCOPE] recommendation to create them.
Step 10 (decomposition): When verdict is NEEDS_REFINEMENT with [DECOMPOSE], auto-create sub-tickets on the appropriate repos and add to board in backlog. Or alternatively, create a skill-decompose-ticket that the review routes to.

File Targets

Files the agent should modify:

skill-review-ticket note in pal-e-docs (the skill definition)

Potentially create:

skill-decompose-ticket note in pal-e-docs (new skill for auto-decomposition)

Acceptance Criteria

Review checks that arch note exists in pal-e-docs for the arch: label value
Review checks that story note/entry exists on project page for the story: label value
Missing arch/story notes flagged as [SCOPE] recommendations
Decomposition path is documented (auto-create sub-tickets or route to decompose skill)

Test Expectations

Run /review-ticket on a ticket with a nonexistent arch: label -- should flag it
Run /review-ticket on a ticket needing decomposition -- should provide actionable next step

Constraints

This is a pal-e-docs note update, not a code change
Must not break existing review flow
Decomposition should be opt-in (recommendation), not forced

Checklist

Skill note updated
Tested with real tickets
No unrelated changes

skill-review-ticket -- the skill being enhanced
pal-e-agency -- project that owns agent skills

### Type Feature ### Lineage Discovered during westside roster session 2026-03-28. Review skill checks labels but not backing notes. Decomposition is recommended but not executed. ### Repo `forgejo_admin/claude-custom` ### User Story As Ava, I want the ticket review to verify that architecture and user story notes actually exist in pal-e-docs so that traceability is real, not just labels. ### Context Current `skill-review-ticket` (in pal-e-docs) checks: - Template completeness - Traceability triangle (story: label, arch: label, issue URL) - File targets, decomposition need Gaps identified: 1. `arch:X` label is checked but the corresponding arch note (e.g. `arch-groupme`, `arch-westside-app`) is never verified to exist in pal-e-docs 2. `story:X` label is checked but the backing user story is never verified to exist on the project page 3. When decomposition is recommended (NEEDS_REFINEMENT + DECOMPOSE tag), the sub-tickets are not auto-created -- a human or separate agent must do it manually 4. No check for whether child boards (template-board) are needed for complex work Proposed changes to skill-review-ticket: - Step 4 (traceability): After checking labels, call `search_notes(query="arch-{X}")` and `get_section(slug="project-{project}", anchor_id="user-stories")` to verify backing notes exist. If missing, add `[SCOPE]` recommendation to create them. - Step 10 (decomposition): When verdict is NEEDS_REFINEMENT with `[DECOMPOSE]`, auto-create sub-tickets on the appropriate repos and add to board in backlog. Or alternatively, create a `skill-decompose-ticket` that the review routes to. ### File Targets Files the agent should modify: - `skill-review-ticket` note in pal-e-docs (the skill definition) Potentially create: - `skill-decompose-ticket` note in pal-e-docs (new skill for auto-decomposition) ### Acceptance Criteria - [ ] Review checks that arch note exists in pal-e-docs for the arch: label value - [ ] Review checks that story note/entry exists on project page for the story: label value - [ ] Missing arch/story notes flagged as [SCOPE] recommendations - [ ] Decomposition path is documented (auto-create sub-tickets or route to decompose skill) ### Test Expectations - [ ] Run /review-ticket on a ticket with a nonexistent arch: label -- should flag it - [ ] Run /review-ticket on a ticket needing decomposition -- should provide actionable next step ### Constraints - This is a pal-e-docs note update, not a code change - Must not break existing review flow - Decomposition should be opt-in (recommendation), not forced ### Checklist - [ ] Skill note updated - [ ] Tested with real tickets - [ ] No unrelated changes ### Related - `skill-review-ticket` -- the skill being enhanced - `pal-e-agency` -- project that owns agent skills

forgejo_admin commented

2026-03-29 19:00:02 +00:00

Author

Contributor

Scope Review: NEEDS_REFINEMENT

Review note: review-591-2026-03-29

Traceability labels need correction before this ticket can advance.

story:agency is not a valid story key on project-pal-e-agency. Valid keys: superuser-manage, superuser-onboard, pm-scope, dev-execute, qa-review, dottie-docs. Recommend story:pm-scope.
arch:skills is not documented in convention-architecture-ids. Either register it as a new component or change to an existing ID like arch:review-pipeline.

## Scope Review: NEEDS_REFINEMENT Review note: `review-591-2026-03-29` Traceability labels need correction before this ticket can advance. - `story:agency` is not a valid story key on project-pal-e-agency. Valid keys: superuser-manage, superuser-onboard, pm-scope, dev-execute, qa-review, dottie-docs. Recommend `story:pm-scope`. - `arch:skills` is not documented in convention-architecture-ids. Either register it as a new component or change to an existing ID like `arch:review-pipeline`.

forgejo_admin commented

2026-03-29 19:26:22 +00:00

Author

Contributor

Scope Review: READY

Review note: review-591-2026-03-29

Re-review after label refinements. All three traceability legs verified: story:pm-scope confirmed on project-pal-e-agency user-stories table, arch:skills confirmed registered in convention-architecture-ids, Forgejo issue open. Template complete, 4 verifiable AC, no decomposition needed.

[BODY] User story says "As Betty Sue" -- should be "As Ava" per the Betty Sue-to-Ava rename (claude-custom#224, done). Minor cosmetic fix, non-blocking.

## Scope Review: READY Review note: `review-591-2026-03-29` Re-review after label refinements. All three traceability legs verified: `story:pm-scope` confirmed on project-pal-e-agency user-stories table, `arch:skills` confirmed registered in convention-architecture-ids, Forgejo issue open. Template complete, 4 verifiable AC, no decomposition needed. - `[BODY]` User story says "As Betty Sue" -- should be "As Ava" per the Betty Sue-to-Ava rename (claude-custom#224, done). Minor cosmetic fix, non-blocking.