ldraney/claude-custom

Fork 0

Merge hook fix: board-item-on-merge.sh targets validation column #227

New issue

Closed

opened 2026-03-29 04:26:19 +00:00 by forgejo_admin · 1 comment

forgejo_admin commented

2026-03-29 04:26:19 +00:00

Contributor

Type

Story (sub-ticket of #209)

Lineage

Parent: #209 (right-side validation pipeline)
Sub-ticket 2 of 3. Independent — can be dispatched in parallel with #226.

Repo

forgejo_admin/claude-custom

User Story

As the platform operator
I want merged PRs to move board items to the validation column instead of done
So that every merge triggers the validation pipeline and no ticket bypasses production validation

Context

board-item-on-merge.sh is the hook that fires on mcp__forgejo__merge_approved_pr. Currently line 135 moves items to "done" directly, making the validation column dead on arrival. Lines 54, 89, and 134 also reference "done" in log and fallback messages.

File Targets

Files to modify:

~/.claude/hooks/board-item-on-merge.sh
- Line 135: change column target from "done" to "validation"
- Line 54: update log message referencing "done" to "validation"
- Line 89: update fallback message referencing "done" to "validation"
- Line 134: update log message referencing "done" to "validation"

Files NOT to touch:

~/.claude/settings.json — hook registration unchanged
~/.claude/hooks/check-board-advance.sh — left-side gate, covered by #161
Any pal-e-docs notes — covered by #226
~/.claude/skills/validate-ticket/ — covered by #228

Acceptance Criteria

board-item-on-merge.sh line 135 (or equivalent) moves items to "validation" column instead of "done"
Log messages at lines 54, 89, 134 updated to reference "validation" instead of "done"
No other behavioral changes to the hook

Test Expectations

Read the modified file and verify all 4 lines reference "validation" instead of "done"
Manual test: merge a PR → verify board item lands in validation (not done)
Run command: grep -n '"done"\|"validation"' ~/.claude/hooks/board-item-on-merge.sh

Constraints

validation column must already exist in the board schema. If the column doesn't exist, the hook will fail silently (fail-open pattern). Verify column exists before testing.
This is a code change — requires branch, PR, review cycle
Agent: Dev (Devy)

Checklist

PR opened
Tests pass
No unrelated changes

#209 — parent issue (DECOMPOSED)
#226 — sibling: doc fixes (parallel)
#228 — sibling: validate-ticket skill
#210 — validation→done gate hook (separate scope)
review-518-2026-03-28 — scope review that identified line targets

### Type Story (sub-ticket of #209) ### Lineage Parent: #209 (right-side validation pipeline) Sub-ticket 2 of 3. Independent — can be dispatched in parallel with #226. ### Repo `forgejo_admin/claude-custom` ### User Story As the platform operator I want merged PRs to move board items to the `validation` column instead of `done` So that every merge triggers the validation pipeline and no ticket bypasses production validation ### Context `board-item-on-merge.sh` is the hook that fires on `mcp__forgejo__merge_approved_pr`. Currently line 135 moves items to `"done"` directly, making the `validation` column dead on arrival. Lines 54, 89, and 134 also reference "done" in log and fallback messages. ### File Targets Files to modify: - `~/.claude/hooks/board-item-on-merge.sh` - Line 135: change column target from `"done"` to `"validation"` - Line 54: update log message referencing "done" to "validation" - Line 89: update fallback message referencing "done" to "validation" - Line 134: update log message referencing "done" to "validation" Files NOT to touch: - `~/.claude/settings.json` — hook registration unchanged - `~/.claude/hooks/check-board-advance.sh` — left-side gate, covered by #161 - Any pal-e-docs notes — covered by #226 - `~/.claude/skills/validate-ticket/` — covered by #228 ### Acceptance Criteria - [ ] `board-item-on-merge.sh` line 135 (or equivalent) moves items to `"validation"` column instead of `"done"` - [ ] Log messages at lines 54, 89, 134 updated to reference `"validation"` instead of `"done"` - [ ] No other behavioral changes to the hook ### Test Expectations - [ ] Read the modified file and verify all 4 lines reference "validation" instead of "done" - [ ] Manual test: merge a PR → verify board item lands in `validation` (not `done`) - Run command: `grep -n '"done"\|"validation"' ~/.claude/hooks/board-item-on-merge.sh` ### Constraints - `validation` column must already exist in the board schema. If the column doesn't exist, the hook will fail silently (fail-open pattern). Verify column exists before testing. - This is a code change — requires branch, PR, review cycle - Agent: Dev (Devy) ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - #209 — parent issue (DECOMPOSED) - #226 — sibling: doc fixes (parallel) - #228 — sibling: validate-ticket skill - #210 — validation→done gate hook (separate scope) - `review-518-2026-03-28` — scope review that identified line targets

forgejo_admin referenced this issue

2026-03-29 04:27:19 +00:00

DECOMPOSED: Right-side validation pipeline — /validate-ticket skill, flow diagrams, merge hook fix #209

forgejo_admin referenced this issue

2026-03-29 04:28:31 +00:00

Doc fixes: update validation flow diagrams in sop-board-workflow + agent-workflow #226

forgejo_admin referenced this issue

2026-03-29 04:29:05 +00:00

Create /validate-ticket skill mirroring /review-ticket pattern #228

forgejo_admin referenced this issue

2026-03-29 04:29:14 +00:00

DECOMPOSED: Right-side validation pipeline — /validate-ticket skill, flow diagrams, merge hook fix #209

forgejo_admin commented

2026-03-29 04:29:54 +00:00

Author

Contributor

Closing as redundant

PR #229 (from issue #210, validation-gate hook) already implements this exact change — board-item-on-merge.sh targets validation column instead of done. That PR is currently in QA review.

This ticket was created during #209 decomposition but #210 was already in flight covering the same scope.

## Closing as redundant PR #229 (from issue #210, validation-gate hook) already implements this exact change — `board-item-on-merge.sh` targets `validation` column instead of `done`. That PR is currently in QA review. This ticket was created during #209 decomposition but #210 was already in flight covering the same scope.

forgejo_admin referenced this issue

2026-03-29 04:36:49 +00:00

feat: add /validate-ticket skill for post-merge validation #230

forgejo_admin referenced this issue

2026-03-29 19:01:12 +00:00

DECOMPOSED: Right-side validation pipeline — /validate-ticket skill, flow diagrams, merge hook fix #209

forgejo_admin closed this issue

2026-03-29 19:23:54 +00:00