Epilogue nits: stale refs, jq flag, spawn gate comment #91

New issue

Closed

opened 2026-03-14 18:36:34 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-14 18:36:34 +00:00

Contributor

Lineage

plan-pal-e-agency → Epilogue (nits #14-17)

Repo

forgejo_admin/claude-custom

User Story

As a platform operator
I want hooks and commands to reflect the current operating model
So that there are no stale references that cause confusion

Context

QA reviews of PRs #87, #88, and #90 found 4 non-blocking nits. These are minor fixes batched from the plan-pal-e-agency epilogue.

File Targets

Files to modify:

commands/update-docs.md — replace stale sprint tool references with board tool equivalents (nit #14). Sprint tools were replaced by board tools in MCP v0.3.0.
hooks/check-mcp-servers.sh — handle scoped npm packages without @version suffix that produce empty fingerprint (nit #15). Edge case: @scope/package without version produces empty hash. Not triggered by current config but should be handled defensively.
hooks/check-agent-spawn.sh — remove unnecessary -r flag from jq ... | length call (nit #16). The -r (raw output) flag has no effect on numeric output from length.
hooks/check-agent-spawn.sh — update header comment from "no issue, no agent" to reflect capability-based pass-through model (nit #17). After PR #90 (capability-based spawn gate), Explore agents can spawn without issues. The header comment is misleading.

Acceptance Criteria

update-docs.md references board tools instead of sprint tools
check-mcp-servers.sh handles empty fingerprint for scoped packages
Unnecessary -r flag removed from check-agent-spawn.sh
Header comment in check-agent-spawn.sh updated to reflect capability-based model

Test Expectations

Manual: verify hooks still work after changes (run a test spawn, test commit)
No automated test suite exists for hooks — manual verification only

Constraints

Follow sop-claude-config-development — hooks are hardlinked, changes are live immediately on pull
Minimal changes — these are nits, not redesigns
Do NOT change hook logic, only fix stale references and comments

Checklist

PR opened
Manual verification passes
No unrelated changes

plan-pal-e-agency — epilogue nits #14-17
sop-claude-config-development — development workflow for this repo

### Lineage `plan-pal-e-agency` → Epilogue (nits #14-17) ### Repo `forgejo_admin/claude-custom` ### User Story As a platform operator I want hooks and commands to reflect the current operating model So that there are no stale references that cause confusion ### Context QA reviews of PRs #87, #88, and #90 found 4 non-blocking nits. These are minor fixes batched from the plan-pal-e-agency epilogue. ### File Targets Files to modify: - `commands/update-docs.md` — replace stale sprint tool references with board tool equivalents (nit #14). Sprint tools were replaced by board tools in MCP v0.3.0. - `hooks/check-mcp-servers.sh` — handle scoped npm packages without `@version` suffix that produce empty fingerprint (nit #15). Edge case: `@scope/package` without version produces empty hash. Not triggered by current config but should be handled defensively. - `hooks/check-agent-spawn.sh` — remove unnecessary `-r` flag from `jq ... | length` call (nit #16). The `-r` (raw output) flag has no effect on numeric output from `length`. - `hooks/check-agent-spawn.sh` — update header comment from "no issue, no agent" to reflect capability-based pass-through model (nit #17). After PR #90 (capability-based spawn gate), Explore agents can spawn without issues. The header comment is misleading. ### Acceptance Criteria - [ ] `update-docs.md` references board tools instead of sprint tools - [ ] `check-mcp-servers.sh` handles empty fingerprint for scoped packages - [ ] Unnecessary `-r` flag removed from `check-agent-spawn.sh` - [ ] Header comment in `check-agent-spawn.sh` updated to reflect capability-based model ### Test Expectations - [ ] Manual: verify hooks still work after changes (run a test spawn, test commit) - [ ] No automated test suite exists for hooks — manual verification only ### Constraints - Follow `sop-claude-config-development` — hooks are hardlinked, changes are live immediately on pull - Minimal changes — these are nits, not redesigns - Do NOT change hook logic, only fix stale references and comments ### Checklist - [ ] PR opened - [ ] Manual verification passes - [ ] No unrelated changes ### Related - `plan-pal-e-agency` — epilogue nits #14-17 - `sop-claude-config-development` — development workflow for this repo