Add weekly tracking view, properties tab, and four-tab nav

ldraney commented

2026-05-25 01:45:36 +00:00

Owner

Type

Feature

Lineage

Child of ldraney/landscaping-assistant #8. Phase 2 — depends on #9 (active/inactive column).

Repo

ldraney/landscaping-assistant

User Story

As a landscaper
I want a weekly view showing which active properties I completed and a properties tab to manage active/inactive status
So that I can track my weekly progress and keep my property list clean

Context

Depends on #9 which adds the active column. This issue builds the two new views (Week + Properties) and expands the nav to four tabs. No schema changes — purely views and controllers.

File Targets

Files to modify or create:

app/controllers/weeks_controller.rb — new controller for weekly completion view
app/views/weeks/index.html.erb — weekly completion grid with week nav
app/controllers/properties_controller.rb — add toggle_active action
app/views/properties/manage.html.erb — properties management view with active/inactive toggle
app/views/layouts/application.html.erb — four-tab nav: Today, Week, New, Properties
config/routes.rb — add weeks resource, properties manage route, toggle action
app/assets/stylesheets/application.css — week grid styles, inactive dimming, four-tab layout

Files NOT to touch:

app/javascript/controllers/location_controller.js — GPS flow unchanged
db/migrate/ — no schema changes in this issue

Acceptance Criteria

Week tab shows all active properties with completion status for selected week (Mon-Sun)
Week navigation with prev/next arrows (same pattern as day nav)
Summary line showing completion count (e.g. "12/15 completed")
Properties tab lists all properties with active/inactive toggle
Inactive properties visually dimmed
Four-tab nav: Today, Week, New, Properties — active state correct on all
Toggle persists via Turbo Stream (no full reload)

Test Expectations

Request spec: weeks#index returns 200, shows correct completion data
Request spec: property active toggle persists
Request spec: inactive properties excluded from week view
Run command: bundle exec rspec

Constraints

Week = Monday through Sunday
No new tables — weekly tracking aggregates existing work_queue_items
Match existing design token system and component patterns
Properties tab is lightweight — toggle and search, not full CRUD

Checklist

PR opened
Tests pass
No unrelated changes

project-landscaping-assistant
Parent: #8
Depends on: #9

### Type Feature ### Lineage Child of `ldraney/landscaping-assistant #8`. Phase 2 — depends on #9 (active/inactive column). ### Repo `ldraney/landscaping-assistant` ### User Story As a landscaper I want a weekly view showing which active properties I completed and a properties tab to manage active/inactive status So that I can track my weekly progress and keep my property list clean ### Context Depends on #9 which adds the `active` column. This issue builds the two new views (Week + Properties) and expands the nav to four tabs. No schema changes — purely views and controllers. ### File Targets Files to modify or create: - `app/controllers/weeks_controller.rb` — new controller for weekly completion view - `app/views/weeks/index.html.erb` — weekly completion grid with week nav - `app/controllers/properties_controller.rb` — add toggle_active action - `app/views/properties/manage.html.erb` — properties management view with active/inactive toggle - `app/views/layouts/application.html.erb` — four-tab nav: Today, Week, New, Properties - `config/routes.rb` — add weeks resource, properties manage route, toggle action - `app/assets/stylesheets/application.css` — week grid styles, inactive dimming, four-tab layout Files NOT to touch: - `app/javascript/controllers/location_controller.js` — GPS flow unchanged - `db/migrate/` — no schema changes in this issue ### Acceptance Criteria - [ ] Week tab shows all active properties with completion status for selected week (Mon-Sun) - [ ] Week navigation with prev/next arrows (same pattern as day nav) - [ ] Summary line showing completion count (e.g. "12/15 completed") - [ ] Properties tab lists all properties with active/inactive toggle - [ ] Inactive properties visually dimmed - [ ] Four-tab nav: Today, Week, New, Properties — active state correct on all - [ ] Toggle persists via Turbo Stream (no full reload) ### Test Expectations - [ ] Request spec: weeks#index returns 200, shows correct completion data - [ ] Request spec: property active toggle persists - [ ] Request spec: inactive properties excluded from week view - Run command: `bundle exec rspec` ### Constraints - Week = Monday through Sunday - No new tables — weekly tracking aggregates existing `work_queue_items` - Match existing design token system and component patterns - Properties tab is lightweight — toggle and search, not full CRUD ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - `project-landscaping-assistant` - Parent: #8 - Depends on: #9

ldraney referenced this issue

2026-05-25 01:54:44 +00:00

Add active/inactive status to properties #12

ldraney commented

2026-05-25 01:56:22 +00:00

Author

Owner

Scope Review: NEEDS_REFINEMENT

Review note: review-1252-2026-05-24

Template is complete, all file targets verified against codebase, dependency on #9 correctly documented and #9 is in PR review. Story note exists. Single refinement needed:

[SCOPE] Architecture note arch-rails-app does not exist in pal-e-docs. The arch:rails-app label references a backing note that hasn't been created yet. Create it to document the app's patterns (design tokens, Stimulus, Turbo Streams, controller conventions).

Once the arch note exists, this ticket is READY for implementation (after #9 merges).

## Scope Review: NEEDS_REFINEMENT Review note: `review-1252-2026-05-24` Template is complete, all file targets verified against codebase, dependency on #9 correctly documented and #9 is in PR review. Story note exists. Single refinement needed: - **[SCOPE]** Architecture note `arch-rails-app` does not exist in pal-e-docs. The `arch:rails-app` label references a backing note that hasn't been created yet. Create it to document the app's patterns (design tokens, Stimulus, Turbo Streams, controller conventions). Once the arch note exists, this ticket is READY for implementation (after #9 merges).

ldraney commented

2026-05-25 01:59:55 +00:00

Author

Owner

Scope Review: APPROVED

Review note: review-1252-2026-05-24-b

Re-review passes. All prior NEEDS_REFINEMENT items resolved:

arch-rails-app note confirmed in pal-e-docs (project: pal-enterprises)
Dependency #9 merged as PR #12 (active column available)
Dependency #7 merged as PR #11 (drag-to-reorder)
story:weekly-tracking verified on project page

Template complete, traceability triangle satisfied, file targets verified, no decomposition needed. Ready for implementation.

## Scope Review: APPROVED Review note: `review-1252-2026-05-24-b` Re-review passes. All prior NEEDS_REFINEMENT items resolved: - `arch-rails-app` note confirmed in pal-e-docs (project: pal-enterprises) - Dependency #9 merged as PR #12 (active column available) - Dependency #7 merged as PR #11 (drag-to-reorder) - `story:weekly-tracking` verified on project page Template complete, traceability triangle satisfied, file targets verified, no decomposition needed. Ready for implementation.

ldraney referenced this issue from a commit

2026-05-25 02:06:59 +00:00

Add weekly tracking view, properties tab, and four-tab nav

ldraney referenced this issue from a pull request that will close it,

2026-05-25 02:07:58 +00:00

Add weekly tracking view, properties tab, and four-tab nav #13

ldraney referenced this issue

2026-05-25 02:09:36 +00:00

Add weekly tracking view, properties tab, and four-tab nav #13

ldraney referenced this issue

2026-05-25 02:21:40 +00:00

Add weekly tracking view, properties tab, and four-tab nav #13