ldraney/landscaping-assistant
1
0
Fork 0
Code Issues 32 Pull requests 1 Projects Releases Packages Wiki Activity Actions 4

Revert "Add Person page with profile, property, and platform sections (#145)" #147

Closed
ldraney wants to merge 1 commit from revert-145-person-icon into main
pull from: revert-145-person-icon
merge into: ldraney:main
Conversation 0 Commits 1 Files changed 6 +1 -268
ldraney commented 2026-06-07 03:24:39 +00:00
Owner
Copy link

Summary

  • Reverts PR #145 which was merged without going through the PR review-fix loop

Changes

  • Reverts all 6 files from PR #145: removes PersonController, person view, person spec, person route, person CSS; restores layout line 64 to root_path

Test Plan

  • Revert is clean (no merge conflicts)
  • Existing tests pass after revert
  • Person icon links back to root_path

Review Checklist

  • No secrets committed
  • No unnecessary file changes
  • Commit messages are descriptive
  • Feature flag needed? No — this is a revert

Related Notes

  • Reverts PR #145
  • Issue #137 stays open — work will be re-submitted with proper review
## Summary - Reverts PR #145 which was merged without going through the PR review-fix loop ## Changes - Reverts all 6 files from PR #145: removes PersonController, person view, person spec, person route, person CSS; restores layout line 64 to `root_path` ## Test Plan - [ ] Revert is clean (no merge conflicts) - [ ] Existing tests pass after revert - [ ] Person icon links back to `root_path` ## Review Checklist - [x] No secrets committed - [x] No unnecessary file changes - [x] Commit messages are descriptive - [ ] Feature flag needed? No — this is a revert ## Related Notes - Reverts PR #145 - Issue #137 stays open — work will be re-submitted with proper review
Revert "Add Person page with profile, property, and platform sections (#145)"
Some checks failed
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
CI / scan_ruby (pull_request) Has been cancelled
Details
CI / scan_js (pull_request) Has been cancelled
Details
CI / lint (pull_request) Has been cancelled
Details
202e49128c 
This reverts commit 67a323d1c1.
ldraney closed this pull request 2026-06-07 03:27:29 +00:00
Some checks failed
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
CI / scan_ruby (pull_request) Has been cancelled
Details
CI / scan_js (pull_request) Has been cancelled
Details
CI / lint (pull_request) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/landscaping-assistant!147
No description provided.