Pending completion accordion on weekly view #193

Closed
opened 2026-06-10 00:05:15 +00:00 by ldraney · 0 comments
Owner

Type

Feature

Lineage

Standalone — discovered during weekly scheduling workflow review.

Repo

ldraney/landscaping-assistant

User Story

As an admin
I want to see which properties were scheduled but not completed on past days this week
So that I can quickly identify work that fell through the cracks

Context

During the week, not every property scheduled for a given day gets completed. Currently the only way to spot missed work is scanning each day column in the week grid for queued (not checked) dots on past days. A dedicated "Pending Completion" section surfaces these prominently so nothing gets lost.

File Targets

Files the agent should modify or create:

  • app/controllers/weeks_controller.rb -- query incomplete items from past days
  • app/views/weeks/index.html.erb -- accordion UI with details element
  • app/javascript/controllers/tooltip_controller.js -- Stimulus controller for info icon
  • app/assets/stylesheets/application.css -- PendingCompletion component styles
  • lib/tasks/feature_flags.rake -- register pending_completion flag
  • spec/requests/weeks_spec.rb -- specs for the new section

Files the agent should NOT touch:

  • app/models/work_queue_item.rb -- no model changes needed, existing scopes suffice

Feature Flag

Flag: pending_completion
Type: global
Default: disabled
Visibility: superadmin only (toggle via Platform panel)
Removal: after 2 weeks stable in production

Acceptance Criteria

  • When the flag is enabled and past-day items are incomplete, a "Pending Completion" accordion appears on the Week tab
  • When I tap the info (i) icon, an explanation of what pending completion means is shown
  • When I tap a pending item, I navigate to that property's detail page
  • When all items are complete or the flag is off, the accordion is hidden
  • When viewing a future week, no pending section appears

Test Expectations

  • Request spec: pending items from past days appear when flag is on
  • Request spec: completed items excluded from pending list
  • Request spec: accordion hidden when flag is off
  • Request spec: no pending section for future weeks
  • Run command: bundle exec rspec spec/requests/weeks_spec.rb

Constraints

  • Use native <details> element for accordion (no JS accordion library)
  • Follow existing design tokens and component patterns in application.css
  • Follow feature flag conventions in docs/feature-flags.md

Checklist

  • PR opened
  • Tests pass
  • No unrelated changes
  • landscaping-assistant -- project this affects
### Type Feature ### Lineage Standalone — discovered during weekly scheduling workflow review. ### Repo `ldraney/landscaping-assistant` ### User Story As an admin I want to see which properties were scheduled but not completed on past days this week So that I can quickly identify work that fell through the cracks ### Context During the week, not every property scheduled for a given day gets completed. Currently the only way to spot missed work is scanning each day column in the week grid for queued (not checked) dots on past days. A dedicated "Pending Completion" section surfaces these prominently so nothing gets lost. ### File Targets Files the agent should modify or create: - `app/controllers/weeks_controller.rb` -- query incomplete items from past days - `app/views/weeks/index.html.erb` -- accordion UI with details element - `app/javascript/controllers/tooltip_controller.js` -- Stimulus controller for info icon - `app/assets/stylesheets/application.css` -- PendingCompletion component styles - `lib/tasks/feature_flags.rake` -- register pending_completion flag - `spec/requests/weeks_spec.rb` -- specs for the new section Files the agent should NOT touch: - `app/models/work_queue_item.rb` -- no model changes needed, existing scopes suffice ### Feature Flag Flag: `pending_completion` Type: global Default: disabled Visibility: superadmin only (toggle via Platform panel) Removal: after 2 weeks stable in production ### Acceptance Criteria - [ ] When the flag is enabled and past-day items are incomplete, a "Pending Completion" accordion appears on the Week tab - [ ] When I tap the info (i) icon, an explanation of what pending completion means is shown - [ ] When I tap a pending item, I navigate to that property's detail page - [ ] When all items are complete or the flag is off, the accordion is hidden - [ ] When viewing a future week, no pending section appears ### Test Expectations - [ ] Request spec: pending items from past days appear when flag is on - [ ] Request spec: completed items excluded from pending list - [ ] Request spec: accordion hidden when flag is off - [ ] Request spec: no pending section for future weeks - Run command: `bundle exec rspec spec/requests/weeks_spec.rb` ### Constraints - Use native `<details>` element for accordion (no JS accordion library) - Follow existing design tokens and component patterns in application.css - Follow feature flag conventions in docs/feature-flags.md ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - `landscaping-assistant` -- project this affects
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/landscaping-assistant#193
No description provided.