ldraney/landscaping-assistant
1
0
Fork 0
Code Issues 32 Pull requests 1 Projects Releases Packages Wiki Activity Actions 4

Add "Show Deactivated" toggle to Properties tab #25

New issue
Closed
opened 2026-05-25 03:27:26 +00:00 by ldraney · 1 comment
ldraney commented 2026-05-25 03:27:26 +00:00
Owner
Copy link

Type

Feature

Lineage

Project: landscaping-assistant
Board: board-landscaping-assistant

Repo

ldraney/landscaping-assistant

User Story

As a user, I want to toggle visibility of deactivated properties on the Properties tab so I can review or reactivate them without cluttering my default view.

Context

Properties tab currently shows all properties (active and inactive). Inactive ones appear dimmed with an "Inactive" toggle button. The Today tab correctly hides deactivated properties. The Properties tab should default to showing only active properties, with a toggle to reveal deactivated ones.

Summary

Add a "Show Deactivated" toggle to the Properties (manage) tab that controls visibility of inactive properties.

Acceptance Criteria

  • Properties tab defaults to showing only active properties
  • "Show Deactivated" toggle button at the top reveals inactive properties when enabled
  • Toggle state persists visually (button shows active/inactive state)
  • Inactive properties still appear dimmed with their existing is-inactive styling
  • Reactivating a property from the deactivated list keeps it visible

File Targets

  • app/views/properties/manage.html.erb — add toggle UI
  • app/javascript/controllers/filter_controller.js — add deactivated filter logic
  • app/assets/stylesheets/application.css — toggle button styling

Test Expectations

  • Default view shows only active properties
  • Clicking toggle reveals inactive properties with dimmed styling
  • Search and service filters still work with deactivated properties visible

Scope Boundary

  • Does NOT change the Today tab behavior (already hides inactive)
  • Does NOT change the toggle_active action logic
  • Does NOT persist toggle state across page loads (JS-only)

Constraints

  • Must work with existing Stimulus filter controller
  • No additional server requests — filter client-side only

Checklist

  • Add toggle button to manage.html.erb
  • Update filter_controller.js to handle active/inactive visibility
  • Style the toggle
  • Test with search + service filters

Related

Depends on PR #24 (deactivate from Today tab)

### Type Feature ### Lineage Project: landscaping-assistant Board: board-landscaping-assistant ### Repo ldraney/landscaping-assistant ### User Story As a user, I want to toggle visibility of deactivated properties on the Properties tab so I can review or reactivate them without cluttering my default view. ### Context Properties tab currently shows all properties (active and inactive). Inactive ones appear dimmed with an "Inactive" toggle button. The Today tab correctly hides deactivated properties. The Properties tab should default to showing only active properties, with a toggle to reveal deactivated ones. ### Summary Add a "Show Deactivated" toggle to the Properties (manage) tab that controls visibility of inactive properties. ### Acceptance Criteria - [ ] Properties tab defaults to showing only active properties - [ ] "Show Deactivated" toggle button at the top reveals inactive properties when enabled - [ ] Toggle state persists visually (button shows active/inactive state) - [ ] Inactive properties still appear dimmed with their existing `is-inactive` styling - [ ] Reactivating a property from the deactivated list keeps it visible ### File Targets - `app/views/properties/manage.html.erb` — add toggle UI - `app/javascript/controllers/filter_controller.js` — add deactivated filter logic - `app/assets/stylesheets/application.css` — toggle button styling ### Test Expectations - Default view shows only active properties - Clicking toggle reveals inactive properties with dimmed styling - Search and service filters still work with deactivated properties visible ### Scope Boundary - Does NOT change the Today tab behavior (already hides inactive) - Does NOT change the toggle_active action logic - Does NOT persist toggle state across page loads (JS-only) ### Constraints - Must work with existing Stimulus filter controller - No additional server requests — filter client-side only ### Checklist - [ ] Add toggle button to manage.html.erb - [ ] Update filter_controller.js to handle active/inactive visibility - [ ] Style the toggle - [ ] Test with search + service filters ### Related Depends on PR #24 (deactivate from Today tab)
ldraney commented 2026-06-01 07:35:01 +00:00
Author
Owner
Copy link

This was shipped in PR #36 — the manage page now hides inactive properties by default with a "Show Inactive" filter chip to reveal them. Closing as already implemented.

This was shipped in PR #36 — the manage page now hides inactive properties by default with a "Show Inactive" filter chip to reveal them. Closing as already implemented.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
docs/update-app-architecture
revert-213
move-other-crew-bottom-remove-schedule
feature/today-view-improvements
154-enable-assume-ssl
revert-145-person-icon
docs/user-stories-auth
docs/update-infra-pipeline-post-incident
fix-cache-step-blocking-deploy
fix-kaniko-registry-pull
deactivate-from-today
feature/quick-address-entry
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/landscaping-assistant#25
No description provided.