ldraney/landscaping-assistant
1
0
Fork 0
Code Issues 32 Pull requests 1 Projects Releases Packages Wiki Activity Actions 4

Week tab: show unassigned properties, add to day, move between days [PARENT] #28

New issue
Open
opened 2026-05-25 04:04:27 +00:00 by ldraney · 2 comments
ldraney commented 2026-05-25 04:04:27 +00:00
Owner
Copy link

Type

Feature

Lineage

Standalone — discovered during daily workflow usage. Parent ticket, decomposed into 3 sub-issues.

Repo

ldraney/landscaping-assistant

User Story

As a landscaper
I want to manage my weekly schedule from the Week tab
So that I can plan ahead, see what's unassigned, and move things around without switching tabs

Context

The Week tab currently shows a read-only grid of properties x days with completion checkmarks. It needs to become interactive: show unassigned properties, let me add them to specific days, and move them between days. This is a parent ticket — work is split into 3 sub-issues for independent delivery.

Also needs: Week grid should show client_name as primary (currently shows address_line, inconsistent with Today tab after PR #29).

Sub-issues

  1. Unassigned section — Show properties not queued for any day that week below the grid
  2. Add to day — From the unassigned list (or inline), add a property to a specific day
  3. Move between days — Button-based move (not drag-and-drop) to reassign a property from one day to another

File Targets

Files the agent should modify or create:

  • app/views/weeks/index.html.erb — unassigned section, add/move UI, fix client_name as primary
  • app/controllers/weeks_controller.rb — unassigned query, add/move actions
  • app/javascript/controllers/ — Stimulus controller for week interactions
  • app/assets/stylesheets/application.css — styles for unassigned section and interactions
  • config/routes.rb — new routes for week actions

Files the agent should NOT touch:

  • app/models/property.rb — no model changes needed
  • app/views/work_queue_items/ — Today tab stays as-is

Acceptance Criteria

  • Unassigned properties (not queued for any day that week) visible below the grid
  • Can add an unassigned property to a specific day via button
  • Can move a queued property to a different day via button (not drag-and-drop)
  • Week grid shows client_name as primary display, address as secondary
  • Mobile-friendly — all interactions work on phone

Test Expectations

  • Integration test: unassigned list excludes properties already queued that week
  • Integration test: adding a property to a day creates a work_queue_item
  • Integration test: moving a property between days updates the work_date
  • Run command: bin/rails test

Constraints

  • No Tailwind
  • Button-based interactions (mobile-friendly, no drag-and-drop on week view)
  • Follow existing Turbo Stream and Stimulus patterns
  • Each sub-issue should be independently deployable

Checklist

  • Sub-issues created
  • Each sub-issue PR opened
  • Tests pass
  • No unrelated changes

Related

  • landscaping-assistant — project this affects
  • #26 — optional address (merged)
  • #27 — add from Today tab (merged)
### Type Feature ### Lineage Standalone — discovered during daily workflow usage. Parent ticket, decomposed into 3 sub-issues. ### Repo `ldraney/landscaping-assistant` ### User Story As a landscaper I want to manage my weekly schedule from the Week tab So that I can plan ahead, see what's unassigned, and move things around without switching tabs ### Context The Week tab currently shows a read-only grid of properties x days with completion checkmarks. It needs to become interactive: show unassigned properties, let me add them to specific days, and move them between days. This is a parent ticket — work is split into 3 sub-issues for independent delivery. Also needs: Week grid should show `client_name` as primary (currently shows `address_line`, inconsistent with Today tab after PR #29). ### Sub-issues 1. **Unassigned section** — Show properties not queued for any day that week below the grid 2. **Add to day** — From the unassigned list (or inline), add a property to a specific day 3. **Move between days** — Button-based move (not drag-and-drop) to reassign a property from one day to another ### File Targets Files the agent should modify or create: - `app/views/weeks/index.html.erb` — unassigned section, add/move UI, fix client_name as primary - `app/controllers/weeks_controller.rb` — unassigned query, add/move actions - `app/javascript/controllers/` — Stimulus controller for week interactions - `app/assets/stylesheets/application.css` — styles for unassigned section and interactions - `config/routes.rb` — new routes for week actions Files the agent should NOT touch: - `app/models/property.rb` — no model changes needed - `app/views/work_queue_items/` — Today tab stays as-is ### Acceptance Criteria - [ ] Unassigned properties (not queued for any day that week) visible below the grid - [ ] Can add an unassigned property to a specific day via button - [ ] Can move a queued property to a different day via button (not drag-and-drop) - [ ] Week grid shows client_name as primary display, address as secondary - [ ] Mobile-friendly — all interactions work on phone ### Test Expectations - [ ] Integration test: unassigned list excludes properties already queued that week - [ ] Integration test: adding a property to a day creates a work_queue_item - [ ] Integration test: moving a property between days updates the work_date - Run command: `bin/rails test` ### Constraints - No Tailwind - Button-based interactions (mobile-friendly, no drag-and-drop on week view) - Follow existing Turbo Stream and Stimulus patterns - Each sub-issue should be independently deployable ### Checklist - [ ] Sub-issues created - [ ] Each sub-issue PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - `landscaping-assistant` — project this affects - `#26` — optional address (merged) - `#27` — add from Today tab (merged)
ldraney commented 2026-05-25 04:15:05 +00:00
Author
Owner
Copy link

Scope Review: NEEDS_REFINEMENT

Review note: review-1263-2026-05-24

Ticket is well-structured with all template sections present and file targets verified. However, scope exceeds the 5-minute rule for a single agent pass.

Issues:

  • [SCOPE] Architecture note arch-rails-app does not exist in pal-e-docs (shared across 8+ board items with this label)
  • [BODY] AC #1 "move a property" is ambiguous — drag-and-drop vs. button-based needs clarification (button-based is more mobile-friendly per constraints)
  • [BODY] Unclear whether Week tab actions reuse WorkQueueItemsController or add new WeeksController actions
  • [DECOMPOSE] 6 verifiable items across 3 distinct functional areas (unassigned display, add-to-day, move-between-days), estimated >5 min agent time. Route to skill-decompose-ticket. Suggested split: (1) Unassigned section, (2) Add to day, (3) Move between days.
## Scope Review: NEEDS_REFINEMENT Review note: `review-1263-2026-05-24` Ticket is well-structured with all template sections present and file targets verified. However, scope exceeds the 5-minute rule for a single agent pass. **Issues:** - `[SCOPE]` Architecture note `arch-rails-app` does not exist in pal-e-docs (shared across 8+ board items with this label) - `[BODY]` AC #1 "move a property" is ambiguous — drag-and-drop vs. button-based needs clarification (button-based is more mobile-friendly per constraints) - `[BODY]` Unclear whether Week tab actions reuse WorkQueueItemsController or add new WeeksController actions - `[DECOMPOSE]` 6 verifiable items across 3 distinct functional areas (unassigned display, add-to-day, move-between-days), estimated >5 min agent time. Route to skill-decompose-ticket. Suggested split: (1) Unassigned section, (2) Add to day, (3) Move between days.
ldraney changed title from Week tab: move, add, and show unassigned properties to Week tab: show unassigned properties, add to day, move between days [PARENT] 2026-05-25 04:17:39 +00:00
ldraney commented 2026-05-25 04:18:26 +00:00
Author
Owner
Copy link

Scope review feedback applied (2026-05-24):

Decomposed into 3 sub-issues per review recommendation:

  • #30 — Unassigned properties section (display-only, no new routes)
  • #31 — Add property to a specific day (button-based day picker)
  • #32 — Move property between days (button-based, not drag-and-drop)

Changes from original:

  • Clarified move mechanism: button-based, not drag-and-drop (mobile-friendly constraint)
  • Added: week grid needs client_name as primary display (consistency with PR #29)
  • Each sub-issue is independently deployable
  • Dependency chain: #30 first, then #31 and #32 can be parallel
**Scope review feedback applied (2026-05-24):** Decomposed into 3 sub-issues per review recommendation: - #30 — Unassigned properties section (display-only, no new routes) - #31 — Add property to a specific day (button-based day picker) - #32 — Move property between days (button-based, not drag-and-drop) **Changes from original:** - Clarified move mechanism: button-based, not drag-and-drop (mobile-friendly constraint) - Added: week grid needs `client_name` as primary display (consistency with PR #29) - Each sub-issue is independently deployable - Dependency chain: #30 first, then #31 and #32 can be parallel
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
docs/update-app-architecture
revert-213
move-other-crew-bottom-remove-schedule
feature/today-view-improvements
154-enable-assume-ssl
revert-145-person-icon
docs/user-stories-auth
docs/update-infra-pipeline-post-incident
fix-cache-step-blocking-deploy
fix-kaniko-registry-pull
deactivate-from-today
feature/quick-address-entry
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/landscaping-assistant#28
No description provided.