ldraney/landscaping-assistant
1
0
Fork 0
Code Issues 32 Pull requests 1 Projects Releases Packages Wiki Activity Actions 4

Production 500 on POST /today: fix merged but not deployed #94

New issue
Closed
opened 2026-06-04 12:12:10 +00:00 by ldraney · 0 comments
ldraney commented 2026-06-04 12:12:10 +00:00
Owner
Copy link

Type

Bug

Lineage

Regression from ldraney/landscaping-assistant #75 — fix merged but never deployed due to CI pipeline failures (#76-#91).

Repo

ldraney/landscaping-assistant

What Broke

WorkQueueItemsController#create returns 500 when adding a property to the work queue via turbo stream. Error from Loki:

[ERROR] NoMethodError: undefined method 'include?' for nil
  (handled=false source=application.action_dispatch)
  context={controller: WorkQueueItemsController}

Backtrace: create.turbo_stream.erb:9 -> _property_item.html.erb:11

The deployed create action does not set @queued_property_ids before rendering _property_item, which calls @queued_property_ids.include?(property.id) on line 11.

Two occurrences in 48h:

  • 2026-06-04 06:02 — pod landscaping-assistant-7c4c699554-cpc89
  • 2026-06-03 22:15 — pod landscaping-assistant-7745f8-g4crm

Repro Steps

  1. Navigate to /today
  2. Click the "+" button on any property to add it to the queue
  3. Observe: 500 error, turbo stream response fails

Note: not every create hits this — only when the turbo stream replaces the property item (existing property path, not quick-add).

Expected Behavior

Property is added to the queue and the property list item updates to show "Queued" badge via turbo stream replace.

Environment

  • Cluster/namespace: prod / landscaping-assistant
  • Service version/commit: SHA 3cf5f0f (image tag harbor.tail5b443a.ts.net/landscaping-assistant/app:3cf5f0fafde4484b796ed8a1cdefb1ce5cfff18d)
  • Fix commit: 32171f9 (PR #75, merged to main, 7 commits ahead of deployed)
  • Related alerts: none (no PrometheusRule exists for this app yet — see #17)

Acceptance Criteria

  • CI pipeline runs green on main (blocked by Kaniko registry issue)
  • New image deployed with commit >= 32171f9
  • POST /today returns 200 in production (turbo stream renders without error)
  • No more NoMethodError in Loki for this controller

Related

### Type Bug ### Lineage Regression from `ldraney/landscaping-assistant #75` — fix merged but never deployed due to CI pipeline failures (#76-#91). ### Repo `ldraney/landscaping-assistant` ### What Broke `WorkQueueItemsController#create` returns 500 when adding a property to the work queue via turbo stream. Error from Loki: ``` [ERROR] NoMethodError: undefined method 'include?' for nil (handled=false source=application.action_dispatch) context={controller: WorkQueueItemsController} ``` Backtrace: `create.turbo_stream.erb:9` -> `_property_item.html.erb:11` The deployed `create` action does not set `@queued_property_ids` before rendering `_property_item`, which calls `@queued_property_ids.include?(property.id)` on line 11. Two occurrences in 48h: - 2026-06-04 06:02 — pod `landscaping-assistant-7c4c699554-cpc89` - 2026-06-03 22:15 — pod `landscaping-assistant-7745f8-g4crm` ### Repro Steps 1. Navigate to `/today` 2. Click the "+" button on any property to add it to the queue 3. Observe: 500 error, turbo stream response fails Note: not every create hits this — only when the turbo stream replaces the property item (existing property path, not quick-add). ### Expected Behavior Property is added to the queue and the property list item updates to show "Queued" badge via turbo stream replace. ### Environment - Cluster/namespace: prod / `landscaping-assistant` - Service version/commit: SHA `3cf5f0f` (image tag `harbor.tail5b443a.ts.net/landscaping-assistant/app:3cf5f0fafde4484b796ed8a1cdefb1ce5cfff18d`) - Fix commit: `32171f9` (PR #75, merged to main, 7 commits ahead of deployed) - Related alerts: none (no PrometheusRule exists for this app yet — see #17) ### Acceptance Criteria - [ ] CI pipeline runs green on main (blocked by Kaniko registry issue) - [ ] New image deployed with commit >= `32171f9` - [ ] `POST /today` returns 200 in production (turbo stream renders without error) - [ ] No more `NoMethodError` in Loki for this controller ### Related - Fix PR: #75 - Pipeline fix: #91 - Alert gap: #17 - Parent: #43
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
docs/update-app-architecture
revert-213
move-other-crew-bottom-remove-schedule
feature/today-view-improvements
154-enable-assume-ssl
revert-145-person-icon
docs/user-stories-auth
docs/update-infra-pipeline-post-incident
fix-cache-step-blocking-deploy
fix-kaniko-registry-pull
deactivate-from-today
feature/quick-address-entry
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/landscaping-assistant#94
No description provided.