ldraney/my-vibes-world
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases Packages Wiki Activity Actions

Update pal-e-deployments overlay: port 80/nginx → port 3000/Puma #12

New issue
Open
opened 2026-06-19 04:22:31 +00:00 by ldraney · 3 comments
ldraney commented 2026-06-19 04:22:31 +00:00
Owner
Copy link

Type

Feature

Lineage

PR #207 merged the initial overlay with port 80/nginx. Stack is confirmed as Rails 8 + Puma, so the overlay needs correcting.

Repo

ldraney/pal-e-deployments

User Story

As a deployer, the k3s deployment targets port 3000 (Puma) instead of port 80 (nginx), so the Rails app actually receives traffic.

Context

The Kustomize overlay at overlays/my-vibes-world/ was created based on the my-singing-monsters pattern (port 80, nginx). The correct stack is Rails 8 + Puma on port 3000. All port 80 references across deployment patch, kustomization inline patches, and ingress backend need updating. Probes need to target /up on port 3000.

File Targets

  • overlays/my-vibes-world/prod/deployment-patch.yaml (containerPort 80 → 3000, livenessProbe port 80 → 3000, readinessProbe port 80 → 3000)
  • overlays/my-vibes-world/prod/kustomization.yaml (inline JSON patches: containerPort 80 → 3000, Service targetPort 80 → 3000, Service port 80 → 3000)
  • overlays/my-vibes-world/ingress.yaml (backend port 80 → 3000)

Feature Flag

No

Test Expectations

  • k3s deployment targets port 3000
  • Service routes traffic to Puma on 3000
  • Ingress backend sends to port 3000
  • Health check hits /up on port 3000

Acceptance Criteria

  • containerPort changed from 80 to 3000 in prod/deployment-patch.yaml
  • livenessProbe port changed from 80 to 3000 in prod/deployment-patch.yaml
  • readinessProbe port changed from 80 to 3000 in prod/deployment-patch.yaml
  • containerPort JSON patch changed from 80 to 3000 in prod/kustomization.yaml
  • Service targetPort JSON patch changed from 80 to 3000 in prod/kustomization.yaml
  • Service port JSON patch changed from 80 to 3000 in prod/kustomization.yaml
  • Ingress backend port changed from 80 to 3000 in ingress.yaml
  • Probe paths point to /up on port 3000
  • No other overlays affected

Constraints

  • Only touch overlays/my-vibes-world/ files

Checklist

  • All port 80 references updated to 3000 across 3 files
  • Probe ports and paths updated
  • PR submitted and reviewed
  • No regressions in other overlays

Related

  • my-vibes-world project
  • pal-e-deployments PR #207 (original overlay)
  • arch-k8s architecture note
### Type Feature ### Lineage PR #207 merged the initial overlay with port 80/nginx. Stack is confirmed as Rails 8 + Puma, so the overlay needs correcting. ### Repo `ldraney/pal-e-deployments` ### User Story As a deployer, the k3s deployment targets port 3000 (Puma) instead of port 80 (nginx), so the Rails app actually receives traffic. ### Context The Kustomize overlay at `overlays/my-vibes-world/` was created based on the my-singing-monsters pattern (port 80, nginx). The correct stack is Rails 8 + Puma on port 3000. All port 80 references across deployment patch, kustomization inline patches, and ingress backend need updating. Probes need to target `/up` on port 3000. ### File Targets - `overlays/my-vibes-world/prod/deployment-patch.yaml` (containerPort 80 → 3000, livenessProbe port 80 → 3000, readinessProbe port 80 → 3000) - `overlays/my-vibes-world/prod/kustomization.yaml` (inline JSON patches: containerPort 80 → 3000, Service targetPort 80 → 3000, Service port 80 → 3000) - `overlays/my-vibes-world/ingress.yaml` (backend port 80 → 3000) ### Feature Flag No ### Test Expectations - k3s deployment targets port 3000 - Service routes traffic to Puma on 3000 - Ingress backend sends to port 3000 - Health check hits `/up` on port 3000 ### Acceptance Criteria - [ ] containerPort changed from 80 to 3000 in `prod/deployment-patch.yaml` - [ ] livenessProbe port changed from 80 to 3000 in `prod/deployment-patch.yaml` - [ ] readinessProbe port changed from 80 to 3000 in `prod/deployment-patch.yaml` - [ ] containerPort JSON patch changed from 80 to 3000 in `prod/kustomization.yaml` - [ ] Service targetPort JSON patch changed from 80 to 3000 in `prod/kustomization.yaml` - [ ] Service port JSON patch changed from 80 to 3000 in `prod/kustomization.yaml` - [ ] Ingress backend port changed from 80 to 3000 in `ingress.yaml` - [ ] Probe paths point to `/up` on port 3000 - [ ] No other overlays affected ### Constraints - Only touch `overlays/my-vibes-world/` files ### Checklist - [ ] All port 80 references updated to 3000 across 3 files - [ ] Probe ports and paths updated - [ ] PR submitted and reviewed - [ ] No regressions in other overlays ### Related - `my-vibes-world` project - pal-e-deployments PR #207 (original overlay) - `arch-k8s` architecture note
ldraney commented 2026-06-19 04:25:26 +00:00
Author
Owner
Copy link

Scope Review: NEEDS_REFINEMENT

Review note: review-1519-2026-06-18

File targets in the issue body do not match the actual repo structure. 5 [BODY] fixes and 1 [SCOPE] item needed.

Key issues:

  • deployment-patch.yaml is actually at overlays/my-vibes-world/prod/deployment-patch.yaml (nested under prod/)
  • service.yaml does not exist as a standalone file -- the Service is defined as inline JSON patches in overlays/my-vibes-world/prod/kustomization.yaml
  • Missing file target: overlays/my-vibes-world/prod/kustomization.yaml line 26 has containerPort set to 80 via JSON patch
  • Missing file target: overlays/my-vibes-world/ingress.yaml line 14 has Ingress backend port 80
  • Missing acceptance criterion: Ingress backend port change
  • [SCOPE] Architecture note arch-k8s does not exist in pal-e-docs -- needs creation
## Scope Review: NEEDS_REFINEMENT Review note: `review-1519-2026-06-18` File targets in the issue body do not match the actual repo structure. 5 `[BODY]` fixes and 1 `[SCOPE]` item needed. **Key issues:** - `deployment-patch.yaml` is actually at `overlays/my-vibes-world/prod/deployment-patch.yaml` (nested under `prod/`) - `service.yaml` does not exist as a standalone file -- the Service is defined as inline JSON patches in `overlays/my-vibes-world/prod/kustomization.yaml` - Missing file target: `overlays/my-vibes-world/prod/kustomization.yaml` line 26 has containerPort set to 80 via JSON patch - Missing file target: `overlays/my-vibes-world/ingress.yaml` line 14 has Ingress backend port 80 - Missing acceptance criterion: Ingress backend port change - `[SCOPE]` Architecture note `arch-k8s` does not exist in pal-e-docs -- needs creation
ldraney commented 2026-06-19 04:29:32 +00:00
Author
Owner
Copy link

Scope Review: NEEDS_REFINEMENT

Review note: review-1519-2026-06-18

Issue is well-structured with all Feature template sections present, but has gaps in acceptance criteria coverage.

  • Missing AC: Service port patch — prod/kustomization.yaml patches spec/ports/0/port to 80 in addition to targetPort. This 4th port-80 reference is not covered by any AC.
  • Missing AC: probe ports — prod/deployment-patch.yaml has livenessProbe.port: 80 and readinessProbe.port: 80 that also need changing to 3000. Not called out in ACs.
  • Ambiguous probe path — AC says "valid Rails endpoint" but doesn't specify the path. Test Expectations mention /up. AC should state the exact target path.
  • Missing arch note — arch:k8s label has no backing arch-k8s note in pal-e-docs. [SCOPE] decision needed.
## Scope Review: NEEDS_REFINEMENT Review note: `review-1519-2026-06-18` Issue is well-structured with all Feature template sections present, but has gaps in acceptance criteria coverage. - **Missing AC: Service `port` patch** — `prod/kustomization.yaml` patches `spec/ports/0/port` to 80 in addition to `targetPort`. This 4th port-80 reference is not covered by any AC. - **Missing AC: probe ports** — `prod/deployment-patch.yaml` has `livenessProbe.port: 80` and `readinessProbe.port: 80` that also need changing to 3000. Not called out in ACs. - **Ambiguous probe path** — AC says "valid Rails endpoint" but doesn't specify the path. Test Expectations mention `/up`. AC should state the exact target path. - **Missing arch note** — `arch:k8s` label has no backing `arch-k8s` note in pal-e-docs. [SCOPE] decision needed.
ldraney commented 2026-06-19 04:34:54 +00:00
Author
Owner
Copy link

Scope Review: READY

Review note: review-1519-2026-06-18 (revision 3)

All 5 prior NEEDS_REFINEMENT recommendations resolved:

  • 3 missing ACs added (livenessProbe port, readinessProbe port, Service port JSON patch)
  • Probe AC clarified to specify /up on port 3000
  • arch-k8s architecture note now exists in pal-e-docs

9 ACs verified against codebase -- every port-80 reference across all 3 target files is accounted for. Minor note: AC #1 references containerPort in deployment-patch.yaml where it does not exist (containerPort is set via JSON patch in kustomization.yaml) -- non-blocking for implementation.

## Scope Review: READY Review note: `review-1519-2026-06-18` (revision 3) All 5 prior NEEDS_REFINEMENT recommendations resolved: - 3 missing ACs added (livenessProbe port, readinessProbe port, Service port JSON patch) - Probe AC clarified to specify `/up` on port 3000 - `arch-k8s` architecture note now exists in pal-e-docs 9 ACs verified against codebase -- every port-80 reference across all 3 target files is accounted for. Minor note: AC #1 references containerPort in deployment-patch.yaml where it does not exist (containerPort is set via JSON patch in kustomization.yaml) -- non-blocking for implementation.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/my-vibes-world#12
No description provided.