Fix CI: ruff format failure on migrate_sqlite_to_postgres.py #85

New issue

Closed

opened 2026-03-06 20:57:55 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-06 20:57:55 +00:00

Contributor

Plan

plan-2026-02-26-tf-modularize-postgres -- Phase 5 blocker

Repo

forgejo_admin/pal-e-docs

User Story

As a developer merging PRs
I want CI to pass
So that merged code actually gets built and deployed

Context

CI has been broken since pipeline #111 (PR #82 merge). The ruff format --check . step fails because scripts/migrate_sqlite_to_postgres.py was merged with formatting that doesn't pass ruff.

This blocks Phase 5 deployment — PR #84 (tsvector search) is merged but the image hasn't been built or deployed.

Error: Would reformat: scripts/migrate_sqlite_to_postgres.py — 1 file would be reformatted, 40 files already formatted

File Targets

scripts/migrate_sqlite_to_postgres.py — run ruff format on it

Acceptance Criteria

ruff format --check . passes
CI pipeline succeeds (test + build-and-push)

Test Expectations

ruff format --check . exits 0
ruff check . exits 0
PALDOCS_DATABASE_PATH=":memory:" python -m pytest passes
Run: ruff format --check . && ruff check .

Constraints

This is a formatting-only change. Do NOT modify any logic.

Checklist

PR opened
Tests pass
No unrelated changes

pal-e-docs project
Bug note: bug-ci-ruff-format-migrate-script
Blocks: Phase 5 deployment (phase-postgres-5-fulltext-search)

### Plan `plan-2026-02-26-tf-modularize-postgres` -- Phase 5 blocker ### Repo `forgejo_admin/pal-e-docs` ### User Story As a developer merging PRs I want CI to pass So that merged code actually gets built and deployed ### Context CI has been broken since pipeline #111 (PR #82 merge). The `ruff format --check .` step fails because `scripts/migrate_sqlite_to_postgres.py` was merged with formatting that doesn't pass ruff. This blocks Phase 5 deployment — PR #84 (tsvector search) is merged but the image hasn't been built or deployed. Error: `Would reformat: scripts/migrate_sqlite_to_postgres.py — 1 file would be reformatted, 40 files already formatted` ### File Targets - `scripts/migrate_sqlite_to_postgres.py` — run `ruff format` on it ### Acceptance Criteria - [ ] `ruff format --check .` passes - [ ] CI pipeline succeeds (test + build-and-push) ### Test Expectations - [ ] `ruff format --check .` exits 0 - [ ] `ruff check .` exits 0 - [ ] `PALDOCS_DATABASE_PATH=":memory:" python -m pytest` passes - Run: `ruff format --check . && ruff check .` ### Constraints - This is a formatting-only change. Do NOT modify any logic. ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - `pal-e-docs` project - Bug note: `bug-ci-ruff-format-migrate-script` - Blocks: Phase 5 deployment (`phase-postgres-5-fulltext-search`)