Bug: Admin draft board missing division filter toggle buttons #187

New issue

Open

opened 2026-03-29 19:01:23 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-29 19:01:23 +00:00

Contributor

Type

Bug

Lineage

Discovered during #129 E2E girls draft board validation.

Repo

forgejo_admin/westside-landing

What Broke

The admin teams page (/admin/teams) has division filter logic fully implemented (divisionFilter state, teamMatchesDivision(), playerMatchesDivision(), filteredTeams, filteredUnassigned derivations) but the UI toggle buttons (All/Boys/Girls) are not rendered in the template. The filter defaults to 'all' with no way to change it.

The admin schedule page (/admin/schedule) has a working reference implementation with proper All/Boys/Girls toggle buttons (lines 196-206).

Additionally, the filteredUnassigned derived value is defined but unused — the template uses unassignedPlayers instead.

Repro Steps

Log in as admin
Navigate to /admin/teams (draft board)
Observe: no division filter buttons visible
All teams (boys + girls) shown with no way to filter

Expected Behavior

All/Boys/Girls toggle buttons should appear above the draft board, matching the pattern used on /admin/schedule.

Environment

Cluster/namespace: prod
Service: westside-landing frontend
File: src/routes/(app)/admin/teams/+page.svelte

Acceptance Criteria

Division filter buttons (All/Boys/Girls) visible on admin draft board
Toggling filters teams and unassigned players correctly
Template uses filteredUnassigned instead of unassignedPlayers
Matches visual pattern from /admin/schedule

forgejo_admin/westside-landing#129 — discovered during validation
project-westside-basketball

### Type Bug ### Lineage Discovered during #129 E2E girls draft board validation. ### Repo `forgejo_admin/westside-landing` ### What Broke The admin teams page (`/admin/teams`) has division filter **logic** fully implemented (divisionFilter state, teamMatchesDivision(), playerMatchesDivision(), filteredTeams, filteredUnassigned derivations) but the **UI toggle buttons** (All/Boys/Girls) are not rendered in the template. The filter defaults to 'all' with no way to change it. The admin schedule page (`/admin/schedule`) has a working reference implementation with proper All/Boys/Girls toggle buttons (lines 196-206). Additionally, the `filteredUnassigned` derived value is defined but unused — the template uses `unassignedPlayers` instead. ### Repro Steps 1. Log in as admin 2. Navigate to /admin/teams (draft board) 3. Observe: no division filter buttons visible 4. All teams (boys + girls) shown with no way to filter ### Expected Behavior All/Boys/Girls toggle buttons should appear above the draft board, matching the pattern used on /admin/schedule. ### Environment - Cluster/namespace: prod - Service: westside-landing frontend - File: `src/routes/(app)/admin/teams/+page.svelte` ### Acceptance Criteria - [ ] Division filter buttons (All/Boys/Girls) visible on admin draft board - [ ] Toggling filters teams and unassigned players correctly - [ ] Template uses `filteredUnassigned` instead of `unassignedPlayers` - [ ] Matches visual pattern from /admin/schedule ### Related - `forgejo_admin/westside-landing#129` — discovered during validation - `project-westside-basketball`