fix: count only required practices in fee description #48

Merged

forgejo_admin merged 1 commit from fix-practice-count into main

2026-04-06 15:15:27 +00:00

forgejo_admin commented

2026-04-06 15:11:16 +00:00

Contributor

Summary

Travel teams showed "Includes 3 practices per week" but only 2 are required — the third is optional weights. Now shows "Includes 2 practices per week plus optional weight room sessions."

Changes

Filter practices.filter(p => !p.optional) for the count
Append "plus optional weight room sessions" when any practice has optional: true

Test Plan

38/38 tests pass
Manual: Queens contract shows "2 practices per week plus optional weight room sessions"
Manual: Local Kings shows "2 practices per week" (no optional)

Review Checklist

One line changed

Closes #37

## Summary Travel teams showed "Includes 3 practices per week" but only 2 are required — the third is optional weights. Now shows "Includes 2 practices per week plus optional weight room sessions." ## Changes - Filter `practices.filter(p => !p.optional)` for the count - Append "plus optional weight room sessions" when any practice has `optional: true` ## Test Plan - [x] 38/38 tests pass - [ ] Manual: Queens contract shows "2 practices per week plus optional weight room sessions" - [ ] Manual: Local Kings shows "2 practices per week" (no optional) ## Review Checklist - [x] One line changed ## Related Notes - Closes #37

forgejo_admin added 1 commit

2026-04-06 15:11:16 +00:00

fix: count only required practices in fee description 944c42e106

Optional practices (weight room sessions) were counted in the
"Includes N practices per week" text. Now filters to non-optional
only and appends "plus optional weight room sessions" when applicable.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>