forgejo_admin/basketball-api
1
0
Fork 1
Code Issues 10 Pull requests 3 Projects Releases Packages Wiki Activity Actions

Schedule data model + migration + seed (practices, events) #232

New issue
Closed
opened 2026-03-28 22:37:53 +00:00 by forgejo_admin · 1 comment
forgejo_admin commented 2026-03-28 22:37:53 +00:00
Owner
Copy link

Type

Feature

Lineage

Child of forgejo_admin/basketball-api#230 (decomposed parent).

Repo

forgejo_admin/basketball-api

User Story

story:WS-S13 As an admin, I want schedule data stored in the database so that practices and events are managed programmatically instead of hardcoded HTML.

Context

No schedule entities exist in the domain model. This ticket adds the data layer only — models, migration, and seed data. API endpoints are a separate ticket (#233).

Key design decisions (from review of #230):

  • Reuse existing Division(boys/girls) enum — Kings=boys, Queens=girls. No new enum needed.
  • Two tables: practice_schedules (recurring weekly) and events (date-specific). Different data shapes warrant separate tables.
  • String(10) for time fields ("14:00" format) — avoids Time type serialization complexity.
  • Self-referencing FK on events.parent_event_id for tournament→game nesting.

File Targets

Files to create or modify:

  • src/basketball_api/models.py — add EventType enum, PracticeSchedule model, Event model. Add relationships to Tenant model.
  • alembic/versions/xxx_add_schedule_tables.py — migration creating both tables
  • scripts/seed_schedule.py — populate current hardcoded schedule data

Pattern reference (do NOT modify):

  • src/basketball_api/models.py lines 1-50 for import/enum style
  • src/basketball_api/models.py lines 146-160 for Tenant relationship pattern
  • src/basketball_api/models.py lines 327-346 for Team model (FK target)

Files NOT to touch:

  • src/basketball_api/routes/* — endpoints are a separate ticket
  • src/basketball_api/schemas.py — does not exist, not part of this ticket

Acceptance Criteria

  • EventType enum added with values: tournament, game, camp, tryout, other
  • PracticeSchedule model created with columns: id, tenant_id (FK), team_id (FK nullable), division (Enum(Division) nullable), label (String 200), day_of_week (Integer 0-6), start_time (String 10), end_time (String 10), location (String 300), notes (Text nullable), is_active (Boolean default true), created_at
  • Event model created with columns: id, tenant_id (FK), title (String 300), event_type (Enum(EventType)), division (Enum(Division) nullable), start_date (Date), end_date (Date nullable), location (String 300 nullable), team_id (FK nullable), parent_event_id (FK self-ref nullable), opponent (String 200 nullable), notes (Text nullable), created_at
  • Alembic migration runs cleanly (upgrade and downgrade)
  • Seed script populates: 8 Kings practice slots, 3 Kings tournaments, 5 Queens tournaments
  • Existing tests still pass

Test Expectations

  • Migration test: upgrade creates tables, downgrade drops them
  • Model test: can create PracticeSchedule and Event instances with required fields
  • Seed test: script is idempotent (running twice doesn't duplicate)
  • Run command: pytest tests/ -v

Constraints

  • Follow Mapped[type] = mapped_column() pattern used throughout models.py
  • Use server_default=func.now() for created_at (not Python default)
  • Use server_default=text("true") for is_active (matches is_public pattern on Player)
  • Tenant FK with index=True (matches every other model)
  • Add practice_schedules and events relationships to Tenant model

Checklist

  • PR opened
  • Tests pass
  • No unrelated changes
  • Migration tested (up and down)

Related

  • Parent: forgejo_admin/basketball-api#230
  • Sibling: forgejo_admin/basketball-api#233 (API endpoints)
  • project-westside-basketball
  • arch-domain-westside-basketball — update after merge
### Type Feature ### Lineage Child of `forgejo_admin/basketball-api#230` (decomposed parent). ### Repo `forgejo_admin/basketball-api` ### User Story `story:WS-S13` As an admin, I want schedule data stored in the database so that practices and events are managed programmatically instead of hardcoded HTML. ### Context No schedule entities exist in the domain model. This ticket adds the data layer only — models, migration, and seed data. API endpoints are a separate ticket (#233). **Key design decisions (from review of #230):** - Reuse existing `Division(boys/girls)` enum — Kings=boys, Queens=girls. No new enum needed. - Two tables: `practice_schedules` (recurring weekly) and `events` (date-specific). Different data shapes warrant separate tables. - `String(10)` for time fields ("14:00" format) — avoids Time type serialization complexity. - Self-referencing FK on `events.parent_event_id` for tournament→game nesting. ### File Targets Files to create or modify: - `src/basketball_api/models.py` — add `EventType` enum, `PracticeSchedule` model, `Event` model. Add relationships to `Tenant` model. - `alembic/versions/xxx_add_schedule_tables.py` — migration creating both tables - `scripts/seed_schedule.py` — populate current hardcoded schedule data Pattern reference (do NOT modify): - `src/basketball_api/models.py` lines 1-50 for import/enum style - `src/basketball_api/models.py` lines 146-160 for Tenant relationship pattern - `src/basketball_api/models.py` lines 327-346 for Team model (FK target) Files NOT to touch: - `src/basketball_api/routes/*` — endpoints are a separate ticket - `src/basketball_api/schemas.py` — does not exist, not part of this ticket ### Acceptance Criteria - [ ] `EventType` enum added with values: tournament, game, camp, tryout, other - [ ] `PracticeSchedule` model created with columns: id, tenant_id (FK), team_id (FK nullable), division (Enum(Division) nullable), label (String 200), day_of_week (Integer 0-6), start_time (String 10), end_time (String 10), location (String 300), notes (Text nullable), is_active (Boolean default true), created_at - [ ] `Event` model created with columns: id, tenant_id (FK), title (String 300), event_type (Enum(EventType)), division (Enum(Division) nullable), start_date (Date), end_date (Date nullable), location (String 300 nullable), team_id (FK nullable), parent_event_id (FK self-ref nullable), opponent (String 200 nullable), notes (Text nullable), created_at - [ ] Alembic migration runs cleanly (upgrade and downgrade) - [ ] Seed script populates: 8 Kings practice slots, 3 Kings tournaments, 5 Queens tournaments - [ ] Existing tests still pass ### Test Expectations - [ ] Migration test: upgrade creates tables, downgrade drops them - [ ] Model test: can create PracticeSchedule and Event instances with required fields - [ ] Seed test: script is idempotent (running twice doesn't duplicate) - Run command: `pytest tests/ -v` ### Constraints - Follow `Mapped[type] = mapped_column()` pattern used throughout models.py - Use `server_default=func.now()` for created_at (not Python default) - Use `server_default=text("true")` for is_active (matches is_public pattern on Player) - Tenant FK with `index=True` (matches every other model) - Add `practice_schedules` and `events` relationships to Tenant model ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes - [ ] Migration tested (up and down) ### Related - Parent: `forgejo_admin/basketball-api#230` - Sibling: `forgejo_admin/basketball-api#233` (API endpoints) - `project-westside-basketball` - `arch-domain-westside-basketball` — update after merge
forgejo_admin commented 2026-03-28 22:41:44 +00:00
Author
Owner
Copy link

Scope Review: READY

Review note: review-629-2026-03-28

All template sections present, traceability triangle complete (story:WS-S13, arch:basketball-api, Forgejo #232). All file targets verified against codebase — line references accurate, patterns confirmed, schemas.py absence confirmed.

Minor nit (non-blocking): Constraints section says server_default=text("true") for is_active "matches is_public pattern on Player" — but Player.is_public defaults to text("false"). The actual match is Product.active (line 382). Consider updating the reference text.

## Scope Review: READY Review note: `review-629-2026-03-28` All template sections present, traceability triangle complete (story:WS-S13, arch:basketball-api, Forgejo #232). All file targets verified against codebase — line references accurate, patterns confirmed, schemas.py absence confirmed. **Minor nit (non-blocking):** Constraints section says `server_default=text("true")` for is_active "matches is_public pattern on Player" — but `Player.is_public` defaults to `text("false")`. The actual match is `Product.active` (line 382). Consider updating the reference text.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
hotfix-029-division-enum
205-clean-test-data-from-production-db-playe
114-email-verification
147-feat-add-get-jersey-player-info-endpoint
124-feat-many-to-many-player-team-assignment
125-feat-add-new-players-manually-seydou-gou
126-feat-team-placement-congratulations-emai
121-admin-teams-spa-endpoints
70-add-graduating-class-to-roster-api-respo
59-fix-auth-test
62-phase-4l-sveltekit-dashboard-wkq-tailsca
11-phase-1a-fix-ci-pipeline-venv-in-test-st
No results found.
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend

   
status:approved

QA passed, awaiting merge approval

  
status:in-progress

Dev agent is actively working

  
status:needs-fix

QA found issues, back to dev

  
status:qa

PR submitted, awaiting QA review

  
type:bug

Bug fix

  
type:devops

Infrastructure/CI/config work

  
type:feature

New functionality

No labels
domain:backend
domain:devops
domain:frontend
status:approved
status:in-progress
status:needs-fix
status:qa
type:bug
type:devops
type:feature
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo_admin/basketball-api#232
No description provided.