Remove opt-out from jersey ordering options #263

New issue

Closed

opened 2026-03-30 23:42:40 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-30 23:42:40 +00:00

Owner

Type

Bug

Lineage

Standalone -- Lucas flagged during jersey ordering validation 2026-03-30. Opt-out should no longer be available.

Repo

forgejo_admin/basketball-api

What Broke

The jersey ordering flow still offers "Opt Out (Bring Your Own)" as an option. This should no longer be available -- all players must order a jersey. At least one player (Zion Odejinmi, id=113) already selected opt-out and has status paid with no jersey data.

Repro Steps

Navigate to jersey ordering page (via email link or player profile)
Observe: "Opt Out (Bring Your Own)" appears as a selectable option at $0.00
Player can select opt-out, bypassing jersey ordering entirely

Expected Behavior

Opt-out option should not appear in the jersey options list. Only "Reversible Jersey" ($90) and "Jersey + Warmup Package" ($130) should be available.

Environment

Cluster/namespace: prod / basketball-api
Service version: commit 4cd0e1b5 (latest main)
Affected player: Zion Odejinmi (id=113), jersey_option=opt_out, jersey_order_status=paid

Acceptance Criteria

Opt-out no longer appears in GET /jersey/options response
POST /jersey/checkout rejects opt_out as an invalid option
POST /checkout/create-session rejects opt_out for jersey-category products
Existing opt-out records are not deleted (data preservation)

project-westside-basketball
story:WS-S18

### Type Bug ### Lineage Standalone -- Lucas flagged during jersey ordering validation 2026-03-30. Opt-out should no longer be available. ### Repo `forgejo_admin/basketball-api` ### What Broke The jersey ordering flow still offers "Opt Out (Bring Your Own)" as an option. This should no longer be available -- all players must order a jersey. At least one player (Zion Odejinmi, id=113) already selected opt-out and has status `paid` with no jersey data. ### Repro Steps 1. Navigate to jersey ordering page (via email link or player profile) 2. Observe: "Opt Out (Bring Your Own)" appears as a selectable option at $0.00 3. Player can select opt-out, bypassing jersey ordering entirely ### Expected Behavior Opt-out option should not appear in the jersey options list. Only "Reversible Jersey" ($90) and "Jersey + Warmup Package" ($130) should be available. ### Environment - Cluster/namespace: prod / basketball-api - Service version: commit `4cd0e1b5` (latest main) - Affected player: Zion Odejinmi (id=113), jersey_option=opt_out, jersey_order_status=paid ### Acceptance Criteria - [ ] Opt-out no longer appears in GET /jersey/options response - [ ] POST /jersey/checkout rejects opt_out as an invalid option - [ ] POST /checkout/create-session rejects opt_out for jersey-category products - [ ] Existing opt-out records are not deleted (data preservation) ### Related - `project-westside-basketball` - story:WS-S18