Bug: 9 pre-existing test failures from removed opt_out jersey option #300

New issue

Open

opened 2026-04-03 19:54:40 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-04-03 19:54:40 +00:00

Owner

Type

Bug

Lineage

Standalone — discovered during email architecture validation (2026-04-03). Pre-existing regression, not caused by email work. Traced to removal of opt_out jersey option (likely #263).

Repo

forgejo_admin/basketball-api

What Broke

9 tests fail on main because they send {"option": "opt_out"} which is no longer a valid JerseyOption enum value. The API returns 422 (validation error) instead of the expected 200 or 403. This blocks the CI pipeline — the update-kustomize-tag step skips when tests fail, requiring manual image tag updates to deploy.

Failing tests:

test_checkout.py::TestPlayerIdCheckoutCreateSession — 3 failures
test_dual_auth.py::TestJerseyCheckoutDualAuth — 2 failures
test_dual_auth.py::TestCheckoutCreateSessionDualAuth — 1 failure
test_jersey.py::TestPlayerIdJerseyCheckout — 3 failures

Repro Steps

git checkout main && git pull
pytest tests/test_checkout.py tests/test_dual_auth.py tests/test_jersey.py -v
Observe: 9 failures, all with assert 422 == 200 or assert 422 == 403

Expected Behavior

All tests pass. CI pipeline goes green. update-kustomize-tag step runs automatically on merge.

Environment

Cluster/namespace: prod (basketball-api)
Service version/commit: fb24245 (latest main)
Related alerts: none — tests fail, not production
Pipeline: #294 (failure)

Acceptance Criteria

All 9 failing tests either pass with valid option or are removed
pytest runs green on main (748+ pass, 0 fail)
CI pipeline #295+ completes successfully including update-kustomize-tag step

project-westside-basketball — parent project
Pipeline 294 — the failing pipeline

### Type Bug ### Lineage Standalone — discovered during email architecture validation (2026-04-03). Pre-existing regression, not caused by email work. Traced to removal of `opt_out` jersey option (likely #263). ### Repo `forgejo_admin/basketball-api` ### What Broke 9 tests fail on main because they send `{"option": "opt_out"}` which is no longer a valid `JerseyOption` enum value. The API returns 422 (validation error) instead of the expected 200 or 403. This blocks the CI pipeline — the `update-kustomize-tag` step skips when tests fail, requiring manual image tag updates to deploy. Failing tests: - `test_checkout.py::TestPlayerIdCheckoutCreateSession` — 3 failures - `test_dual_auth.py::TestJerseyCheckoutDualAuth` — 2 failures - `test_dual_auth.py::TestCheckoutCreateSessionDualAuth` — 1 failure - `test_jersey.py::TestPlayerIdJerseyCheckout` — 3 failures ### Repro Steps 1. `git checkout main && git pull` 2. `pytest tests/test_checkout.py tests/test_dual_auth.py tests/test_jersey.py -v` 3. Observe: 9 failures, all with `assert 422 == 200` or `assert 422 == 403` ### Expected Behavior All tests pass. CI pipeline goes green. `update-kustomize-tag` step runs automatically on merge. ### Environment - Cluster/namespace: prod (basketball-api) - Service version/commit: `fb24245` (latest main) - Related alerts: none — tests fail, not production - Pipeline: #294 (failure) ### Acceptance Criteria - [ ] All 9 failing tests either pass with valid option or are removed - [ ] `pytest` runs green on main (748+ pass, 0 fail) - [ ] CI pipeline #295+ completes successfully including `update-kustomize-tag` step ### Related - `project-westside-basketball` — parent project - Pipeline 294 — the failing pipeline