forgejo_admin/basketball-api
1
0
Fork 1
Code Issues 88 Pull requests 9 Projects Releases Packages Wiki Activity Actions

fix: add mkdir for MJML compiled output directory #297

Merged
forgejo_admin merged 1 commit from 293-fix-dockerfile-mkdir into main 2026-04-03 19:30:14 +00:00
Conversation 1 Commits 1 Files changed 1 +1
forgejo_admin commented 2026-04-03 19:25:11 +00:00
Owner
Copy link

Summary

Follow-up fix for #293 -- the email-compiler Docker stage runs npx mjml ... -o templates/email/compiled/ but the compiled/ directory does not exist. MJML CLI requires the output directory to pre-exist for multi-file input, causing docker build to fail.

Changes

  • Dockerfile: Added RUN mkdir -p templates/email/compiled before the npx mjml invocation in the email-compiler stage

Test Plan

  • docker build --target email-compiler succeeds with the fix
  • Full docker build passes in CI

Review Checklist

  • One-line change, isolated to Dockerfile email-compiler stage
  • No application logic changes

Related Notes

None.

Related

Closes #293

## Summary Follow-up fix for #293 -- the email-compiler Docker stage runs `npx mjml ... -o templates/email/compiled/` but the `compiled/` directory does not exist. MJML CLI requires the output directory to pre-exist for multi-file input, causing docker build to fail. ## Changes - `Dockerfile`: Added `RUN mkdir -p templates/email/compiled` before the `npx mjml` invocation in the email-compiler stage ## Test Plan - [x] `docker build --target email-compiler` succeeds with the fix - [ ] Full `docker build` passes in CI ## Review Checklist - [x] One-line change, isolated to Dockerfile email-compiler stage - [x] No application logic changes ## Related Notes None. ## Related Closes #293
fix: add mkdir for MJML compiled output directory in Dockerfile
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
Details
b42a425020 
MJML CLI requires the output directory to pre-exist for multi-file input.
The email-compiler stage was missing the directory creation step, causing
docker build to fail.

Follow-up fix for #293.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
forgejo_admin commented 2026-04-03 19:25:47 +00:00
Author
Owner
Copy link

QA Review -- PR #297

Scope: One-line Dockerfile fix in the email-compiler build stage.

Diff Review

The change adds RUN mkdir -p templates/email/compiled before the npx mjml invocation. This is correct -- MJML CLI does not auto-create output directories when processing glob patterns.

Checklist

  • Fix is minimal and scoped to the reported bug
  • No application logic changes
  • mkdir -p is idempotent (safe if directory already exists)
  • Placement is correct (after COPY, before npx mjml)
  • Branch naming follows convention: 293-fix-dockerfile-mkdir
  • PR body has all required sections
  • Closes #293 present for auto-close
  • docker build --target email-compiler verified passing by author

Findings

No issues found. This is a straightforward one-line fix for a missing directory that causes the Docker build to fail.

VERDICT: APPROVED

## QA Review -- PR #297 **Scope:** One-line Dockerfile fix in the `email-compiler` build stage. ### Diff Review The change adds `RUN mkdir -p templates/email/compiled` before the `npx mjml` invocation. This is correct -- MJML CLI does not auto-create output directories when processing glob patterns. ### Checklist - [x] Fix is minimal and scoped to the reported bug - [x] No application logic changes - [x] `mkdir -p` is idempotent (safe if directory already exists) - [x] Placement is correct (after COPY, before npx mjml) - [x] Branch naming follows convention: `293-fix-dockerfile-mkdir` - [x] PR body has all required sections - [x] `Closes #293` present for auto-close - [x] `docker build --target email-compiler` verified passing by author ### Findings No issues found. This is a straightforward one-line fix for a missing directory that causes the Docker build to fail. **VERDICT: APPROVED**
forgejo_admin deleted branch 293-fix-dockerfile-mkdir 2026-04-03 19:30:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend

   
status:approved

QA passed, awaiting merge approval

  
status:in-progress

Dev agent is actively working

  
status:needs-fix

QA found issues, back to dev

  
status:qa

PR submitted, awaiting QA review

  
type:bug

Bug fix

  
type:devops

Infrastructure/CI/config work

  
type:feature

New functionality

No labels
domain:backend
domain:devops
domain:frontend
status:approved
status:in-progress
status:needs-fix
status:qa
type:bug
type:devops
type:feature
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo_admin/basketball-api!297
No description provided.