forgejo_admin/basketball-api
1
0
Fork 1
Code Issues 88 Pull requests 9 Projects Releases Packages Wiki Activity Actions

Email: Welcome to first practice — all teams, parent-player meeting Tuesday Apr 7 #312

New issue
Closed
opened 2026-04-03 23:22:40 +00:00 by forgejo_admin · 3 comments
forgejo_admin commented 2026-04-03 23:22:40 +00:00
Owner
Copy link

Type

Feature

Lineage

Standalone — season starts Apr 7, all 51 parents need welcome email with schedule and parent-player meeting info.

Repo

forgejo_admin/basketball-api

User Story

As an admin,
I want to email all parents welcoming them to the season
So that every family knows about the parent-player meeting and their team's practice schedule.

Context

Season starts Tuesday Apr 7 at West High. Parent-player meeting first 10-15 minutes, then practice. 51 unique parents across 7 teams. Email should include the full weekly schedule for their team (queried from practice_schedules table) and the parent-player meeting details.

Email templates in this codebase are MJML-compiled HTML loaded at runtime from /data/email-templates/ via load_email_template() (defined at email.py:1107). New templates follow this pipeline: write MJML → compile to HTML → mount into container at /data/email-templates/.

Environment

File Targets

Files to create/modify:

  • src/basketball_api/services/email.py — add send_welcome_practice_email() function using load_email_template() or inline HTML following existing patterns
  • src/basketball_api/routes/admin.py — add POST /admin/email/welcome-practice endpoint with optional team/division filter and test_email param
  • Email template file (if using MJML pipeline: add to email-templates build, if inline: include in email.py function)

Files NOT to touch:

  • src/basketball_api/models.py
  • src/basketball_api/routes/schedule.py

Acceptance Criteria

  • Email includes: parent-player meeting (Tue Apr 7, West High, 6-8 PM, first 10-15 min), team-specific practice schedule from DB
  • Personalized per parent: shows their player's team schedule
  • Supports filter by team_id or division, and test_email param
  • Excludes test players (name contains "TEST")
  • Logs to email_log table

Test Expectations

  • Test email to draneylucas@gmail.com renders correctly with sample team data
  • pytest tests/ -k email passes
  • Run command: pytest tests/

Constraints

  • Follow existing email patterns (see send_jersey_reminder_email for reference)
  • Use gmail-sdk via get_gmail_client(tenant, db)
  • Use load_email_template() from email.py:1107 for template loading, OR inline HTML if simpler
  • Query practice_schedules table to build per-team schedule dynamically
  • Must support test_email param for approval gate

Checklist

  • PR opened
  • Tests pass
  • No unrelated changes

Related

  • westside-basketball — project this affects
  • basketball-api#279 — practice schedule data seeding
### Type Feature ### Lineage Standalone — season starts Apr 7, all 51 parents need welcome email with schedule and parent-player meeting info. ### Repo `forgejo_admin/basketball-api` ### User Story As an admin, I want to email all parents welcoming them to the season So that every family knows about the parent-player meeting and their team's practice schedule. ### Context Season starts Tuesday Apr 7 at West High. Parent-player meeting first 10-15 minutes, then practice. 51 unique parents across 7 teams. Email should include the full weekly schedule for their team (queried from practice_schedules table) and the parent-player meeting details. Email templates in this codebase are MJML-compiled HTML loaded at runtime from `/data/email-templates/` via `load_email_template()` (defined at `email.py:1107`). New templates follow this pipeline: write MJML → compile to HTML → mount into container at `/data/email-templates/`. ### Environment - Cluster/namespace: prod / basketball-api - Service: basketball-api email service (gmail-sdk, westsidebasketball@gmail.com) ### File Targets Files to create/modify: - `src/basketball_api/services/email.py` — add `send_welcome_practice_email()` function using `load_email_template()` or inline HTML following existing patterns - `src/basketball_api/routes/admin.py` — add `POST /admin/email/welcome-practice` endpoint with optional team/division filter and test_email param - Email template file (if using MJML pipeline: add to email-templates build, if inline: include in email.py function) Files NOT to touch: - `src/basketball_api/models.py` - `src/basketball_api/routes/schedule.py` ### Acceptance Criteria - [ ] Email includes: parent-player meeting (Tue Apr 7, West High, 6-8 PM, first 10-15 min), team-specific practice schedule from DB - [ ] Personalized per parent: shows their player's team schedule - [ ] Supports filter by team_id or division, and test_email param - [ ] Excludes test players (name contains "TEST") - [ ] Logs to email_log table ### Test Expectations - [ ] Test email to draneylucas@gmail.com renders correctly with sample team data - [ ] `pytest tests/ -k email` passes - Run command: `pytest tests/` ### Constraints - Follow existing email patterns (see `send_jersey_reminder_email` for reference) - Use gmail-sdk via `get_gmail_client(tenant, db)` - Use `load_email_template()` from email.py:1107 for template loading, OR inline HTML if simpler - Query practice_schedules table to build per-team schedule dynamically - Must support test_email param for approval gate ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - `westside-basketball` — project this affects - `basketball-api#279` — practice schedule data seeding
forgejo_admin commented 2026-04-03 23:28:57 +00:00
Author
Owner
Copy link

Scope Review: NEEDS_REFINEMENT

Review note: review-763-2026-04-03
One file target is incorrect and an architecture note is missing.

  • [BODY] src/basketball_api/templates/ does not exist. Email templates are MJML-compiled HTML loaded from /data/email-templates/ at runtime via load_email_template(). Fix the file target to reference the email build pipeline (Dockerfile) instead.
  • [SCOPE] Architecture note arch-basketball-api does not exist in pal-e-docs. Cross-cutting gap affecting all basketball-api tickets.
## Scope Review: NEEDS_REFINEMENT Review note: `review-763-2026-04-03` One file target is incorrect and an architecture note is missing. - **[BODY]** `src/basketball_api/templates/` does not exist. Email templates are MJML-compiled HTML loaded from `/data/email-templates/` at runtime via `load_email_template()`. Fix the file target to reference the email build pipeline (Dockerfile) instead. - **[SCOPE]** Architecture note `arch-basketball-api` does not exist in pal-e-docs. Cross-cutting gap affecting all basketball-api tickets.
forgejo_admin commented 2026-04-03 23:30:02 +00:00
Author
Owner
Copy link

Scope refinement (review-763-2026-04-03):

  1. Template path fixed — removed reference to nonexistent src/basketball_api/templates/. Corrected to document the actual pipeline: MJML-compiled HTML loaded via load_email_template() at email.py:1107, mounted at /data/email-templates/. File Targets and Constraints updated.
**Scope refinement (review-763-2026-04-03):** 1. **Template path fixed** — removed reference to nonexistent `src/basketball_api/templates/`. Corrected to document the actual pipeline: MJML-compiled HTML loaded via `load_email_template()` at `email.py:1107`, mounted at `/data/email-templates/`. File Targets and Constraints updated.
forgejo_admin commented 2026-04-03 23:31:54 +00:00
Author
Owner
Copy link

Scope Review: APPROVED

Review note: review-763-2026-04-03-v2
Re-review after refinement. Both previous issues resolved: template path corrected to document load_email_template() pipeline, arch note gap acknowledged as non-blocking backlog item. All file targets verified, traceability complete, 5 testable AC, single-repo scope. Ready for execution.

## Scope Review: APPROVED Review note: `review-763-2026-04-03-v2` Re-review after refinement. Both previous issues resolved: template path corrected to document `load_email_template()` pipeline, arch note gap acknowledged as non-blocking backlog item. All file targets verified, traceability complete, 5 testable AC, single-repo scope. Ready for execution.
forgejo_admin 2026-04-03 23:49:04 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
510-grant-tournament-tables-to-ro-role
458-skip-proration-v2
458-skip-proration
466-cherry-pick-first-payment
458-merge-first-payment-blast
369-first-payment-email-blast
408-player-nickname
313-local-first-week-email
320-mjml-sponsor-outreach-template
270-contract-reminder-email
205-clean-test-data-from-production-db-playe
114-email-verification
147-feat-add-get-jersey-player-info-endpoint
124-feat-many-to-many-player-team-assignment
125-feat-add-new-players-manually-seydou-gou
126-feat-team-placement-congratulations-emai
121-admin-teams-spa-endpoints
70-add-graduating-class-to-roster-api-respo
59-fix-auth-test
62-phase-4l-sveltekit-dashboard-wkq-tailsca
11-phase-1a-fix-ci-pipeline-venv-in-test-st
No results found.
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend

   
status:approved

QA passed, awaiting merge approval

  
status:in-progress

Dev agent is actively working

  
status:needs-fix

QA found issues, back to dev

  
status:qa

PR submitted, awaiting QA review

  
type:bug

Bug fix

  
type:devops

Infrastructure/CI/config work

  
type:feature

New functionality

No labels
domain:backend
domain:devops
domain:frontend
status:approved
status:in-progress
status:needs-fix
status:qa
type:bug
type:devops
type:feature
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo_admin/basketball-api#312
No description provided.