feat: add welcome practice email with parent-player meeting info #318

Merged

forgejo_admin merged 2 commits from 312-welcome-practice-email into main 2026-04-04 02:13:41 +00:00

Conversation 3 Commits 2 Files changed 3 +776

forgejo_admin commented 2026-04-03 23:40:17 +00:00

Owner

Copy link

Summary

Add a welcome-to-the-season email that includes the April 7 parent-player meeting details and each team's weekly practice schedule queried dynamically from the practice_schedules table.

Changes

• src/basketball_api/services/email.py — added send_welcome_practice_email(), _format_day(), _format_time_12h() helpers. Uses branded inline HTML with meeting card and schedule table. Logs to email_log with EmailType.announcement.
• src/basketball_api/routes/admin.py — added POST /admin/email/welcome-practice endpoint with test_email, division (boys/girls/all), and team_id query params. Excludes TEST players, deduplicates by parent, queries practice_schedules per team.

Test Plan

• pytest tests/ passes (467 passed; pre-existing failures in test_checkout and test_schedule unrelated to this change)
• Use test_email=draneylucas@gmail.com to verify rendering before bulk send
• Verify email contains: parent-player meeting (Tue Apr 7, West High, 6-8 PM), team practice schedule with day names and 12-hour times

Review Checklist

• ruff format and ruff check pass
• No new models or migrations needed (reuses EmailType.announcement)
• Follows existing email patterns (send_jersey_reminder_email)
• Test players excluded (name contains "TEST")
• Pre-existing test failures confirmed on main

Related Notes

None.

Related

Closes #312

## Summary Add a welcome-to-the-season email that includes the April 7 parent-player meeting details and each team's weekly practice schedule queried dynamically from the `practice_schedules` table. ## Changes - `src/basketball_api/services/email.py` — added `send_welcome_practice_email()`, `_format_day()`, `_format_time_12h()` helpers. Uses branded inline HTML with meeting card and schedule table. Logs to `email_log` with `EmailType.announcement`. - `src/basketball_api/routes/admin.py` — added `POST /admin/email/welcome-practice` endpoint with `test_email`, `division` (boys/girls/all), and `team_id` query params. Excludes TEST players, deduplicates by parent, queries `practice_schedules` per team. ## Test Plan - `pytest tests/` passes (467 passed; pre-existing failures in test_checkout and test_schedule unrelated to this change) - Use `test_email=draneylucas@gmail.com` to verify rendering before bulk send - Verify email contains: parent-player meeting (Tue Apr 7, West High, 6-8 PM), team practice schedule with day names and 12-hour times ## Review Checklist - [x] ruff format and ruff check pass - [x] No new models or migrations needed (reuses `EmailType.announcement`) - [x] Follows existing email patterns (`send_jersey_reminder_email`) - [x] Test players excluded (name contains "TEST") - [x] Pre-existing test failures confirmed on main ## Related Notes None. ## Related Closes #312

forgejo_admin added 2 commits 2026-04-03 23:40:17 +00:00

feat: include is_public in admin players list response ... 3c167eae94

The AdminPlayerItem model and GET /admin/players response now include
the is_public boolean field, enabling the westside-app admin UI to
display and toggle player visibility state.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

feat: add welcome practice email with parent-player meeting info (#312) ... c5ebf31edf

Add send_welcome_practice_email() to email service and POST /admin/email/welcome-practice
endpoint. Email includes Apr 7 parent-player meeting details and team-specific practice
schedule queried from practice_schedules table. Supports division/team_id filters and
test_email param.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin force-pushed 312-welcome-practice-email from c5ebf31edf to 078bf6c34c 2026-04-03 23:45:52 +00:00 Compare

forgejo_admin commented 2026-04-03 23:46:31 +00:00

Author

Owner

Copy link

QA Review

Scope Check

• send_welcome_practice_email() added to email.py with meeting info + dynamic schedule
• POST /admin/email/welcome-practice added to admin.py with division/team_id/test_email filters
• TEST player exclusion via "TEST" in player.name.upper()
• Parent deduplication via emailed_parents set
• Practice schedule query: is_active=True, ORDER BY day_of_week
• Email logged with EmailType.announcement (reuses existing enum -- no migration needed)
• _format_day() and _format_time_12h() helpers handle edge cases

Pattern Compliance

• Follows send_jersey_reminder_email pattern exactly (client, subject, plain+html, send, log, commit)
• Branded HTML uses _brand_wrapper + inline styles consistent with existing emails
• Endpoint follows existing /email/* patterns (tenant lookup, query builder, test_email filter, error collection)
• Import additions are minimal and correct (Team in email.py, PracticeSchedule + send_welcome_practice_email in admin.py)

Nits

1. Division validation HTTPException(400) is raised inside the player loop -- if an invalid division string is passed, it raises on the first player iteration rather than upfront. Functionally correct but could be moved before the loop for clarity. Low priority.

Tests

• 652 passed, pre-existing failures only (test_checkout, test_contract, test_schedule, test_email_blast, test_templated_email -- all confirmed failing on main)

VERDICT: APPROVED

## QA Review ### Scope Check - [x] `send_welcome_practice_email()` added to email.py with meeting info + dynamic schedule - [x] `POST /admin/email/welcome-practice` added to admin.py with division/team_id/test_email filters - [x] TEST player exclusion via `"TEST" in player.name.upper()` - [x] Parent deduplication via `emailed_parents` set - [x] Practice schedule query: `is_active=True`, `ORDER BY day_of_week` - [x] Email logged with `EmailType.announcement` (reuses existing enum -- no migration needed) - [x] `_format_day()` and `_format_time_12h()` helpers handle edge cases ### Pattern Compliance - [x] Follows `send_jersey_reminder_email` pattern exactly (client, subject, plain+html, send, log, commit) - [x] Branded HTML uses `_brand_wrapper` + inline styles consistent with existing emails - [x] Endpoint follows existing `/email/*` patterns (tenant lookup, query builder, test_email filter, error collection) - [x] Import additions are minimal and correct (`Team` in email.py, `PracticeSchedule` + `send_welcome_practice_email` in admin.py) ### Nits 1. Division validation `HTTPException(400)` is raised inside the player loop -- if an invalid division string is passed, it raises on the first player iteration rather than upfront. Functionally correct but could be moved before the loop for clarity. Low priority. ### Tests - 652 passed, pre-existing failures only (test_checkout, test_contract, test_schedule, test_email_blast, test_templated_email -- all confirmed failing on main) **VERDICT: APPROVED**

forgejo_admin commented 2026-04-03 23:49:03 +00:00

Author

Owner

Copy link

PR #318 Review

DOMAIN REVIEW

Tech stack: Python / FastAPI / SQLAlchemy / Gmail SDK (inline HTML email)

Python/FastAPI quality:

• PEP 484 type hints present on both new functions and the endpoint. Return type annotation on send_welcome_practice_email is str | None, matching the pattern.
• PEP 257 docstrings present on the endpoint and the service function.
• _format_day() and _format_time_12h() are clean, well-scoped helpers with proper fallback behavior.
• escape() from html module is used on all user-supplied data interpolated into HTML (parent name, player name, team name, location, day, times). XSS risk is mitigated.
• Pydantic WelcomePracticeResponse model is correctly defined for the response.

SQLAlchemy patterns:

• Query uses joinedload(Parent.players).joinedload(Player.teams) which is redundant since Player.teams already has lazy="selectin" on the model relationship (line 257 of models.py). Not harmful, but unnecessary -- the selectin strategy will fire regardless. This is a nit, not a blocker.
• PracticeSchedule query per-player inside the loop is an N+1 pattern. For the expected scale (dozens of parents, not thousands), this is acceptable. If the roster grows significantly, this could be batched by pre-fetching all active schedules keyed by team_id. Acceptable for now.
• Session management follows existing patterns: db.add() + db.commit() per email sent, consistent with send_contract_reminder_email and other senders.

Email pattern consistency:

• Follows the established _brand_wrapper() + inline HTML + EmailLog pattern used by send_jersey_reminder_email and send_contract_reminder_email. Good consistency.
• Logs to email_log with EmailType.announcement -- reuses existing enum value, no migration needed. Correct.
• Plain text body provided alongside HTML body. Good practice for email deliverability.

Logic review:

• The deduplication logic (emailed_parents set + break after first eligible player) means each parent gets exactly one email for their first eligible player/team. This is documented in the docstring. The intent is clear.
• Parent.registration_token.isnot(None) filter ensures only registered parents receive emails. Reasonable gate.
• TEST player filtering uses "TEST" in player.name.upper() which is consistent with existing patterns in this codebase.
• Division validation correctly raises HTTPException(400) for invalid values. Good.

Hardcoded values concern:

• The parent-player meeting details (Tuesday April 7, West High Field House, 241 N 300 W SLC, 6-8 PM) are hardcoded in both the plain text and HTML bodies. This is a one-time seasonal email, so hardcoding is pragmatically acceptable -- but it means this endpoint is not reusable for future seasons without code changes. This matches the pattern of other seasonal emails in this repo (e.g., jersey reminder with specific details). Noted as a nit, not a blocker.

BLOCKERS

1. No test coverage for new endpoint or service function.

This PR adds 306 lines of new functionality across two files:

• A new admin endpoint POST /admin/email/welcome-practice with three query params and complex filtering logic (division, team_id, TEST player exclusion, deduplication)
• A new service function send_welcome_practice_email() with HTML generation and email logging
• Two helper functions _format_day() and _format_time_12h()

Zero tests were added. The test file tests/test_admin_email.py already has extensive test patterns for similar email endpoints (profile reminders, roster export) that could be followed. At minimum:

• Happy path: parent with player on team with practice schedules receives email
• Division filter: only matching division gets emails
• Team ID filter: only matching team gets emails
• TEST player exclusion
• Deduplication: parent with multiple players gets only one email
• _format_day() edge cases (0-6 valid, out of range returns string)
• _format_time_12h() conversions (midnight, noon, PM, invalid input fallback)
• Error handling: send failure logged and returned in errors list

Per BLOCKER criteria: "New functionality with zero test coverage" is a blocker.

NITS

1. Redundant joinedload chain (line ~1196 of admin.py): .joinedload(Player.teams) is redundant given lazy="selectin" on the Player.teams relationship. Removing it would reduce query complexity without changing behavior.

2. Hardcoded meeting details: The April 7 meeting info is baked into the email template. For future seasons, consider making meeting details configurable (query params or a config table). Low priority since this is a one-shot seasonal email.

3. practices parameter typed as list (line ~1741 of email.py): The practices parameter is typed as bare list rather than list[PracticeSchedule]. Adding the type parameter would improve IDE support and documentation.

SOP COMPLIANCE

• Branch named after issue: 312-welcome-practice-email follows {issue-number}-{kebab-case-purpose} convention
• PR body has Summary, Changes, Test Plan, Related sections
• Related references plan slug -- PR states "None" for Related Notes, no plan slug. Acceptable since this is standalone work without a plan.
• No secrets committed
• No unnecessary file changes (2 files changed, both directly related to the feature)
• Commit messages are descriptive

PROCESS OBSERVATIONS

• Change failure risk: Medium. Email endpoints that send to real parents carry inherent risk. The test_email param mitigates this for manual testing, but automated tests would catch regression in filtering logic (division, deduplication, TEST exclusion) that manual testing might miss.
• Deployment frequency: No impact -- this is additive (new endpoint, no changes to existing code).
• Documentation: The endpoint docstring is thorough with query param descriptions. Good.

VERDICT: NOT APPROVED

One blocker: zero test coverage for 306 lines of new functionality. The existing test_admin_email.py provides clear patterns to follow. Add tests covering at minimum: happy path, division/team filtering, TEST player exclusion, deduplication, helper function edge cases, and error handling.

## PR #318 Review ### DOMAIN REVIEW **Tech stack**: Python / FastAPI / SQLAlchemy / Gmail SDK (inline HTML email) **Python/FastAPI quality:** - PEP 484 type hints present on both new functions and the endpoint. Return type annotation on `send_welcome_practice_email` is `str | None`, matching the pattern. - PEP 257 docstrings present on the endpoint and the service function. - `_format_day()` and `_format_time_12h()` are clean, well-scoped helpers with proper fallback behavior. - `escape()` from `html` module is used on all user-supplied data interpolated into HTML (parent name, player name, team name, location, day, times). XSS risk is mitigated. - Pydantic `WelcomePracticeResponse` model is correctly defined for the response. **SQLAlchemy patterns:** - Query uses `joinedload(Parent.players).joinedload(Player.teams)` which is redundant since `Player.teams` already has `lazy="selectin"` on the model relationship (line 257 of `models.py`). Not harmful, but unnecessary -- the selectin strategy will fire regardless. This is a nit, not a blocker. - `PracticeSchedule` query per-player inside the loop is an N+1 pattern. For the expected scale (dozens of parents, not thousands), this is acceptable. If the roster grows significantly, this could be batched by pre-fetching all active schedules keyed by `team_id`. Acceptable for now. - Session management follows existing patterns: `db.add()` + `db.commit()` per email sent, consistent with `send_contract_reminder_email` and other senders. **Email pattern consistency:** - Follows the established `_brand_wrapper()` + inline HTML + `EmailLog` pattern used by `send_jersey_reminder_email` and `send_contract_reminder_email`. Good consistency. - Logs to `email_log` with `EmailType.announcement` -- reuses existing enum value, no migration needed. Correct. - Plain text body provided alongside HTML body. Good practice for email deliverability. **Logic review:** - The deduplication logic (`emailed_parents` set + `break` after first eligible player) means each parent gets exactly one email for their first eligible player/team. This is documented in the docstring. The intent is clear. - `Parent.registration_token.isnot(None)` filter ensures only registered parents receive emails. Reasonable gate. - TEST player filtering uses `"TEST" in player.name.upper()` which is consistent with existing patterns in this codebase. - Division validation correctly raises `HTTPException(400)` for invalid values. Good. **Hardcoded values concern:** - The parent-player meeting details (Tuesday April 7, West High Field House, 241 N 300 W SLC, 6-8 PM) are hardcoded in both the plain text and HTML bodies. This is a one-time seasonal email, so hardcoding is pragmatically acceptable -- but it means this endpoint is not reusable for future seasons without code changes. This matches the pattern of other seasonal emails in this repo (e.g., jersey reminder with specific details). Noted as a nit, not a blocker. ### BLOCKERS **1. No test coverage for new endpoint or service function.** This PR adds 306 lines of new functionality across two files: - A new admin endpoint `POST /admin/email/welcome-practice` with three query params and complex filtering logic (division, team_id, TEST player exclusion, deduplication) - A new service function `send_welcome_practice_email()` with HTML generation and email logging - Two helper functions `_format_day()` and `_format_time_12h()` Zero tests were added. The test file `tests/test_admin_email.py` already has extensive test patterns for similar email endpoints (profile reminders, roster export) that could be followed. At minimum: - Happy path: parent with player on team with practice schedules receives email - Division filter: only matching division gets emails - Team ID filter: only matching team gets emails - TEST player exclusion - Deduplication: parent with multiple players gets only one email - `_format_day()` edge cases (0-6 valid, out of range returns string) - `_format_time_12h()` conversions (midnight, noon, PM, invalid input fallback) - Error handling: send failure logged and returned in errors list Per BLOCKER criteria: "New functionality with zero test coverage" is a blocker. ### NITS 1. **Redundant joinedload chain** (line ~1196 of admin.py): `.joinedload(Player.teams)` is redundant given `lazy="selectin"` on the `Player.teams` relationship. Removing it would reduce query complexity without changing behavior. 2. **Hardcoded meeting details**: The April 7 meeting info is baked into the email template. For future seasons, consider making meeting details configurable (query params or a config table). Low priority since this is a one-shot seasonal email. 3. **`practices` parameter typed as `list`** (line ~1741 of email.py): The `practices` parameter is typed as bare `list` rather than `list[PracticeSchedule]`. Adding the type parameter would improve IDE support and documentation. ### SOP COMPLIANCE - [x] Branch named after issue: `312-welcome-practice-email` follows `{issue-number}-{kebab-case-purpose}` convention - [x] PR body has Summary, Changes, Test Plan, Related sections - [ ] Related references plan slug -- PR states "None" for Related Notes, no plan slug. Acceptable since this is standalone work without a plan. - [x] No secrets committed - [x] No unnecessary file changes (2 files changed, both directly related to the feature) - [x] Commit messages are descriptive ### PROCESS OBSERVATIONS - **Change failure risk**: Medium. Email endpoints that send to real parents carry inherent risk. The `test_email` param mitigates this for manual testing, but automated tests would catch regression in filtering logic (division, deduplication, TEST exclusion) that manual testing might miss. - **Deployment frequency**: No impact -- this is additive (new endpoint, no changes to existing code). - **Documentation**: The endpoint docstring is thorough with query param descriptions. Good. ### VERDICT: NOT APPROVED One blocker: zero test coverage for 306 lines of new functionality. The existing `test_admin_email.py` provides clear patterns to follow. Add tests covering at minimum: happy path, division/team filtering, TEST player exclusion, deduplication, helper function edge cases, and error handling.

forgejo_admin referenced this pull request from a commit 2026-04-04 00:02:14 +00:00

fix: add 23 tests for welcome-practice email, fix type hints and redundant joinedload

forgejo_admin added 1 commit 2026-04-04 00:02:14 +00:00

fix: add 23 tests for welcome-practice email, fix type hints and redundant joinedload ... c4bf56846f

- Add tests/test_welcome_practice_email.py covering endpoint (200 status,
  division filter, team_id filter, TEST player exclusion, parent dedup,
  registration_token gate, error handling, auth) and helpers (_format_day,
  _format_time_12h)
- Remove redundant joinedload(Player.teams) since Player.teams uses
  lazy="selectin"
- Type practices param as list[PracticeSchedule] instead of bare list

Addresses QA review items 1-3 on PR #318.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented 2026-04-04 00:05:10 +00:00

Author

Owner

Copy link

PR #318 Re-Review

DOMAIN REVIEW

Stack: Python / FastAPI / SQLAlchemy

Previous findings -- verification:

1. No tests (BLOCKER) -- FIXED. 23 tests added in tests/test_welcome_practice_email.py covering: helper functions (_format_day, _format_time_12h) with happy path + edge cases, endpoint logic (division filtering, team_id filtering, TEST player exclusion, parent deduplication, registration token gating, auth enforcement, invalid division 400, send failure error capture). Solid coverage.

2. Redundant joinedload -- On re-examination, this was a false finding in the original review. Parent.players uses default lazy loading (lazy="select"), so the explicit joinedload(Parent.players) is correct and prevents N+1 queries. Correctly retained.

3. Bare list type hint -- FIXED. Response model uses list[str] (parametrized). Route-level variables use list[str] and set[int].

New observations:

• player.team accessor: valid -- Player model defines a @property team (line 260-263 in models.py) that returns self.teams[0] from the many-to-many. Used consistently across the codebase.
• HTML escaping: html.escape() applied to all user-supplied strings (parent name, player name, team name, location, day, time) in the HTML template. XSS-safe.
• Error handling: send failures caught per-parent, logged, and returned in the errors list. Does not abort the loop on single failure.
• Email logging: EmailLog entry created with EmailType.announcement. Matches existing patterns (send_jersey_reminder_email, send_contract_reminder_email).
• Auth: endpoint uses require_admin dependency. Test verifies 401/403 without auth.
• PEP 484 type hints: present on all function signatures. Docstrings present on public functions and helpers.

BLOCKERS

None.

NITS

1. Hardcoded event date: "Tuesday, April 7" and "West High Field House (241 N 300 W, SLC)" are hardcoded in the email template (both plain text and HTML). Acceptable for a one-time operational email, but if this pattern recurs, consider parameterizing meeting details as endpoint arguments or a config table.

2. One email per parent uses first eligible player only: The break after sending means if a parent has two players on different teams, only the first player's team schedule is included. The deduplication test verifies this behavior, so it is intentional. Worth documenting in the endpoint docstring that only the first eligible player/team is used (not all of them).

3. Division validation location: The Division(division) enum validation happens inside the per-player loop, meaning it re-validates on every iteration. Moving it before the loop (once) would be marginally cleaner, though functionally equivalent since it raises HTTPException on first hit.

SOP COMPLIANCE

• Branch named after issue (312-welcome-practice-email)
• PR body follows template (Summary, Changes, Test Plan, Related)
• Related section references issue (Closes #312)
• Related section does not reference a plan slug (none applicable -- standalone ticket)
• No secrets committed
• No unnecessary file changes (3 files, all directly related)
• Commit messages are descriptive (PR title follows conventional commit: feat:)

PROCESS OBSERVATIONS

• 776 additions, 0 deletions -- clean additive feature with no regressions to existing code.
• 23 tests cover all endpoint paths including error and edge cases. Test-to-code ratio is healthy.
• Follows established email patterns in the codebase (same brand wrapper, same EmailLog pattern, same error handling structure).
• Pre-existing test failures noted in test plan (test_checkout, test_schedule) -- not introduced by this PR.

VERDICT: APPROVED

## PR #318 Re-Review ### DOMAIN REVIEW **Stack**: Python / FastAPI / SQLAlchemy **Previous findings -- verification:** 1. **No tests (BLOCKER)** -- FIXED. 23 tests added in `tests/test_welcome_practice_email.py` covering: helper functions (`_format_day`, `_format_time_12h`) with happy path + edge cases, endpoint logic (division filtering, team_id filtering, TEST player exclusion, parent deduplication, registration token gating, auth enforcement, invalid division 400, send failure error capture). Solid coverage. 2. **Redundant joinedload** -- On re-examination, this was a false finding in the original review. `Parent.players` uses default lazy loading (`lazy="select"`), so the explicit `joinedload(Parent.players)` is correct and prevents N+1 queries. Correctly retained. 3. **Bare `list` type hint** -- FIXED. Response model uses `list[str]` (parametrized). Route-level variables use `list[str]` and `set[int]`. **New observations:** - `player.team` accessor: valid -- `Player` model defines a `@property team` (line 260-263 in models.py) that returns `self.teams[0]` from the many-to-many. Used consistently across the codebase. - HTML escaping: `html.escape()` applied to all user-supplied strings (parent name, player name, team name, location, day, time) in the HTML template. XSS-safe. - Error handling: send failures caught per-parent, logged, and returned in the `errors` list. Does not abort the loop on single failure. - Email logging: `EmailLog` entry created with `EmailType.announcement`. Matches existing patterns (`send_jersey_reminder_email`, `send_contract_reminder_email`). - Auth: endpoint uses `require_admin` dependency. Test verifies 401/403 without auth. - PEP 484 type hints: present on all function signatures. Docstrings present on public functions and helpers. ### BLOCKERS None. ### NITS 1. **Hardcoded event date**: "Tuesday, April 7" and "West High Field House (241 N 300 W, SLC)" are hardcoded in the email template (both plain text and HTML). Acceptable for a one-time operational email, but if this pattern recurs, consider parameterizing meeting details as endpoint arguments or a config table. 2. **One email per parent uses first eligible player only**: The `break` after sending means if a parent has two players on different teams, only the first player's team schedule is included. The deduplication test verifies this behavior, so it is intentional. Worth documenting in the endpoint docstring that only the first eligible player/team is used (not all of them). 3. **Division validation location**: The `Division(division)` enum validation happens inside the per-player loop, meaning it re-validates on every iteration. Moving it before the loop (once) would be marginally cleaner, though functionally equivalent since it raises HTTPException on first hit. ### SOP COMPLIANCE - [x] Branch named after issue (`312-welcome-practice-email`) - [x] PR body follows template (Summary, Changes, Test Plan, Related) - [x] Related section references issue (`Closes #312`) - [ ] Related section does not reference a plan slug (none applicable -- standalone ticket) - [x] No secrets committed - [x] No unnecessary file changes (3 files, all directly related) - [x] Commit messages are descriptive (PR title follows conventional commit: `feat:`) ### PROCESS OBSERVATIONS - 776 additions, 0 deletions -- clean additive feature with no regressions to existing code. - 23 tests cover all endpoint paths including error and edge cases. Test-to-code ratio is healthy. - Follows established email patterns in the codebase (same brand wrapper, same EmailLog pattern, same error handling structure). - Pre-existing test failures noted in test plan (test_checkout, test_schedule) -- not introduced by this PR. ### VERDICT: APPROVED

forgejo_admin merged commit 242282a628 into main 2026-04-04 02:13:41 +00:00

forgejo_admin deleted branch 312-welcome-practice-email 2026-04-04 02:13:41 +00:00

forgejo_admin referenced this pull request from a commit 2026-04-04 02:13:42 +00:00

feat: add welcome practice email with parent-player meeting info (#318)

forgejo_admin referenced this pull request 2026-04-04 02:24:24 +00:00

feat: add local teams first-week schedule exception email #329

forgejo_admin referenced this pull request 2026-04-04 02:25:05 +00:00

feat: add local teams first-week schedule exception email #329

forgejo_admin referenced this pull request 2026-04-04 02:27:51 +00:00

feat: add local teams first-week schedule exception email #329

forgejo_admin referenced this pull request 2026-04-04 05:49:07 +00:00

Fix ruff format on email.py — CI deploy blocker #332

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

domain:backend

  

domain:devops

  

domain:frontend

  

status:approved

QA passed, awaiting merge approval

  

status:in-progress

Dev agent is actively working

  

status:needs-fix

QA found issues, back to dev

  

status:qa

PR submitted, awaiting QA review

  

type:bug

Bug fix

  

type:devops

Infrastructure/CI/config work

  

type:feature

New functionality

No labels

domain:backend

domain:devops

domain:frontend

status:approved

status:in-progress

status:needs-fix

status:qa

type:bug

type:devops

type:feature

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

forgejo_admin/basketball-api!318

No description provided.